Chore/891 eliminate any usage (#994)

* fix(auth): eliminate any type usage in auth.service.ts

Replace 8 any annotations with Prisma-derived and explicit types:
- transactionsToActivityItems: TransactionWithPropertyTitle[]
- handleTokenReuse: Prisma.BlacklistedToken
- document/apiKey/passwordHistory map callbacks: Prisma model types
- recaptcha response: new RecaptchaVerifyResponse interface

Part of #891

* fix(transactions): eliminate any type usage in transactions.service.ts

Replace 24 any annotations with Prisma-derived and explicit types:
- create/update DTO fields: Prisma.TransactionType, Prisma.TransactionStatus
- where clauses: Prisma.TransactionWhereInput
- update data: Prisma.TransactionUpdateInput
- blockchain methods: BlockchainTransactionDto, BlockchainVerificationResultDto
- new TransactionWithFullRelations type for createTransaction return
- new UpdateEscrowDto interface
- toResponseDto param: Prisma.Transaction
- removed unnecessary any casts, let TS infer map/filter/reduce callbacks
- tax strategy methods: Prisma.TransactionTaxStrategy

Verified clean with npx tsc --noEmit --skipLibCheck

Part of #891

* fix(dashboard): eliminate any type usage in dashboard.service.ts

Remove 4 any annotations from map/filter callbacks over Prisma query
results, letting TS infer the correct type from the source array
instead. admin.service.ts already had zero any usages — no change
needed there.

This completes the 4 files named directly in the issue. Verified
clean with npx tsc --noEmit --skipLibCheck.

Part of #891

* fix(search): eliminate any type usage in search-filters.service.ts

Replace 19 any annotations:
- whereClause params and return types: Prisma.PropertyWhereInput
- individual filter values (price/bedrooms/city/etc): unknown, since
  they're genuinely polymorphic and already narrowed via typeof/
  property checks in each method body
- Record<string, any> in SavedFilter/FilterCombination: Record<string, unknown>
- new SaveFilterDto interface for saveFilter's input shape

Verified clean with npx tsc --noEmit --skipLibCheck

Part of #891

* fix: eliminate any type usage across 34 small/simple files

Batch of straightforward any removals across interceptors, controllers,
and small services:
- 6 NestJS interceptors: Observable<any> -> Observable<unknown>
- Express Request augmentation for custom properties (apiVersion,
  openAPIDocument) via local extended interfaces instead of casts to any
- Prisma-derived where/update input types (User, TransactionMilestone,
  TransactionNote, VerificationDocument)
- New interfaces for previously-untyped payloads (EmailBouncePayload,
  EmailJobData, CreateDocumentDto wiring)
- redisStore cast in cache.config.ts documented as unavoidable
  third-party interop rather than silently any
- Fixed 2 downstream type errors surfaced by these changes:
  activity-log metadata (object, not string, despite @IsJSON decorator)
  and a spec.ts mock missing required CreateDocumentDto fields

Note: activity-log.controller.ts now correctly types user as
AuthUserPayload, which exposes (but does not fix) a pre-existing bug
where the code reads user.id but the payload only has .sub -- flagging
for a separate issue, out of scope here.

Verified clean with npx tsc --noEmit --skipLibCheck

Part of #891

* test: eliminate remaining any usage across 18 spec files (#891)

* fix: move EmailBouncePayload interface above decorators to fix ESLint parse error (#891)

The interface was inserted directly between @apitags and @controller,
which is invalid -- a decorator must be immediately followed by the
declaration it decorates. This passed tsc --noEmit (suppressed by
// @ts-nocheck in this file) but failed ESLint parsing with
Decorators are not valid here.

* test: fix stale specs exposed by main merge (unrelated to #891)

PR #994's test check failed after merging upstream main, but not from
the any-removal work -- two pre-existing test/implementation gaps got
exposed:

- webhooks.service.spec.ts: create() test still expected a 'not yet
  implemented' throw, but the service has a real implementation
  (generates a secret, writes to DB) merged in from upstream. Rewrote
  the test to assert the real behavior.
- trust-score.service.spec.ts: mockPrismaService was missing a
  verificationDocument mock that calculateBreakdown's new ID-verification
  check (also from an upstream merge) calls. Added the missing mock.

Verified locally: npx jest src/trust-score/trust-score.service.spec.ts
src/webhooks/webhooks.service.spec.ts -> 2 suites, 15 tests, all passing.

* test: pass missing I18nService mock to EmailService constructor

EmailService's constructor gained an I18nService parameter (from a
merged i18n feature) but this spec still called it with only 4
positional args, misassigning the queue mock into the i18nService
slot and leaving mailQueue undefined -- caught by nest build's
TS2554 'Expected 5 arguments, but got 4'.

Verified: npx jest src/email/email.service.spec.ts and npx nest build
both pass clean.

Follow-up to the earlier trust-score/webhooks stale-test fix -- same
root cause pattern (upstream merge outpacing tests), unrelated to #891.

* fix: resolve merge regressions and Prisma type gaps in transactions/auth services (#891)

- Restore two try blocks left without catch handlers after merging main

  (transactions.service.ts: recordOnBlockchain, verifyOnBlockchain)

- Remove duplicate/conflicting 'updated' declaration in update()

- Restore transaction-not-found check dropped from update() during the merge

- Restore nextCursor/previousCursor pagination fields dropped from findAll()

  during the merge

- Fix TypeScript errors from Prisma client not re-exporting model types

  and enums under the Prisma namespace in this generator version

  (Transaction, TransactionTaxStrategy, TransactionType, TransactionStatus

  in transactions.service.ts; BlacklistedToken, Document, ApiKey,

  PasswordHistory in auth.service.ts)

- Add explicit guard rejecting TransactionStatusDto.FAILED, which has no

  corresponding value in the Prisma schema's TransactionStatus enum

- Use existing this.toNumber() helper for Decimal conversion instead of

  calling .toNumber() directly, matching the pattern already used in

  getAnalytics()

- Normalize nullable Prisma fields (blockchainHash, contractAddress,

  notes) to undefined to match TransactionResponseDto's optional fields

- Remove remaining 'as any' cast in findAll()'s cursor construction

- Fix misplaced docstring on updateEscrow() and restore its unused-param

  lint suppression

* fix: complete Keyv/redis cache migration and rbac.spec AuthUserPayload fixture (#891)

- Finish migrating REDIS_CONFIG from the old cache-manager-redis-store
  store-based API (incompatible with cache-manager v7 / @nestjs/cache-manager
  v3) to the Keyv-based stores API using @keyv/redis
- Add missing UserTier import and tier field to rbac.spec.ts's mock
  AuthUserPayload, which became a required field on the type

* fix: remove unused imports/vars flagged by CI lint (zero-warnings gate)

- rate-limit-headers.interceptor.ts: remove unused 'request' const
- api-docs.controller.ts: remove unused ApiVersionEnum import
- notifications.gateway.ts: remove unused SubscribeMessage, ConnectedSocket,
  MessageBody imports
- webhooks.service.spec.ts: remove unused NotFoundException import and
  unused mockPrisma declaration

* fix: remove duplicate/orphaned code left by merge conflict resolution in getQuickStats

The conflict resolution for #994 merged in both the old per-role query
code and the new #911 single-query optimization instead of cleanly
replacing one with the other, leaving an unused buyerTransactions
variable and a duplicate totalProperties/activeListings declaration.

* test: add coverage for NotificationsGateway to clear src/notifications/ coverage threshold

Was at 19.77% lines (threshold: 20%), driven almost entirely by
notifications.gateway.ts sitting at 9.61%. Covers connection tracking
and all emit helper methods.

---------

Co-authored-by: nanaf6203-bit <nanaf6203@gmail.com>

Author: abdoolyaro

issue-891-test-files-fix.patch

@@ -1,21 +1,28 @@
 import { AdminAuditInterceptor } from './admin-audit.interceptor';
 import { ExecutionContext, CallHandler } from '@nestjs/common';
 import { of } from 'rxjs';
+import { PrismaService } from '../database/prisma.service';
+
+interface MockPrisma {
+  activityLog: {
+    create: jest.Mock;
+  };
+}
 
 describe('AdminAuditInterceptor', () => {
   let interceptor: AdminAuditInterceptor;
-  let mockPrisma: any;
+  let mockPrisma: MockPrisma;
 
   beforeEach(() => {
     mockPrisma = {
       activityLog: {
         create: jest.fn().mockResolvedValue({}),
       },
     };
-    interceptor = new AdminAuditInterceptor(mockPrisma);
+    interceptor = new AdminAuditInterceptor(mockPrisma as unknown as PrismaService);
   });
 
-  function makeContext(overrides: Partial<any> = {}): ExecutionContext {
+  function makeContext(overrides: Record<string, unknown> = {}): ExecutionContext {
     const request = {
       authUser: { sub: 'admin-1' },
       headers: { 'user-agent': 'test-agent' },

src/admin/admin-audit.interceptor.spec.ts

@@ -6,7 +6,7 @@ import { PrismaService } from '../database/prisma.service';
 export class AdminAuditInterceptor implements NestInterceptor {
   constructor(private readonly prisma: PrismaService) {}
 
-  intercept(context: ExecutionContext, next: CallHandler): Observable<any> {
+  intercept(context: ExecutionContext, next: CallHandler): Observable<unknown> {
     const request = context.switchToHttp().getRequest();
     const user = request.authUser;
     const ip =

src/admin/admin-audit.interceptor.ts

@@ -256,11 +256,7 @@ export class AdminController {
   }
 
   @Get('email/preview/:templateName')
-  async previewEmailTemplate(@Param('templateName') templateName: string): Promise<{
-    templateName: string;
-    sampleData: Record<string, unknown>;
-    note: string;
-  }> {
+  async previewEmailTemplate(@Param('templateName') templateName: string) {
     const sampleDataMap: Record<string, Record<string, unknown>> = {
       'password-reset': {
         resetUrl: 'http://localhost:3000/reset-password?token=sample-token-123',

src/admin/admin.controller.ts

@@ -11,7 +11,7 @@ import { AuditService } from '../../audit/audit.service';
 export class AdminAccessLoggingInterceptor implements NestInterceptor {
   constructor(private readonly auditService: AuditService) {}
 
-  intercept(context: ExecutionContext, next: CallHandler): Observable<any> {
+  intercept(context: ExecutionContext, next: CallHandler): Observable<unknown> {
     const request = context.switchToHttp().getRequest();
 
     const response = context.switchToHttp().getResponse();

src/admin/interceptors/admin-access-logging.interceptor.ts

@@ -11,7 +11,7 @@ import { AuthUserPayload } from '../auth/types/auth-user.type';
 export class AnalyticsInterceptor implements NestInterceptor {
   constructor(private readonly analytics: AnalyticsService) {}
 
-  intercept(context: ExecutionContext, next: CallHandler): Observable<any> {
+  intercept(context: ExecutionContext, next: CallHandler): Observable<unknown> {
     const req = context.switchToHttp().getRequest();
     const res = context.switchToHttp().getResponse();
     const start = Date.now();

src/analytics/analytics.interceptor.ts

@@ -7,7 +7,7 @@ import {
   UnauthorizedException,
 } from '@nestjs/common';
 import { ConfigService } from '@nestjs/config';
-import { Prisma } from '@prisma/client';
+import { Prisma, BlacklistedToken, Document, ApiKey, PasswordHistory } from '@prisma/client';
 import { randomUUID } from 'crypto';
 import * as jwt from 'jsonwebtoken';
 import { PrismaService } from '../database/prisma.service';
@@ -63,6 +63,23 @@ type JwtPayload = {
   exp?: number;
 };
 
+type TransactionWithPropertyTitle = Prisma.TransactionGetPayload<{
+  include: { property: { select: { title: true } } };
+}>;
+
+type PropertyWithOwnerName = Prisma.PropertyGetPayload<{
+  include: { owner: { select: { firstName: true; lastName: true } } };
+}>;
+
+interface RecaptchaVerifyResponse {
+  success: boolean;
+  score?: number;
+  action?: string;
+  challenge_ts?: string;
+  hostname?: string;
+  'error-codes'?: string[];
+}
+
 @Injectable()
 export class AuthService {
   private readonly logger = new Logger(AuthService.name);
@@ -123,7 +140,10 @@ export class AuthService {
   /**
    * Helper to map transactions to activity items for dashboard
    */
-  private transactionsToActivityItems(transactions: any[], type: 'purchase' | 'sale') {
+  private transactionsToActivityItems(
+    transactions: TransactionWithPropertyTitle[],
+    type: 'purchase' | 'sale',
+  ) {
     return transactions.map((tx) => ({
       type: 'transaction' as const,
       id: tx.id,
@@ -495,7 +515,7 @@ export class AuthService {
    * Handle token reuse detection - invalidate entire token family
    */
   private async handleTokenReuse(
-    blacklistedToken: any,
+    blacklistedToken: BlacklistedToken,
     reusedJti: string,
     ipAddress?: string,
     userAgent?: string,
@@ -776,7 +796,7 @@ export class AuthService {
     const recentActivity = [
       ...this.transactionsToActivityItems(buyerTransactions, 'purchase'),
       ...this.transactionsToActivityItems(sellerTransactions, 'sale'),
-      ...documents.map((doc: any) => ({
+      ...documents.map((doc: Document) => ({
         type: 'document' as const,
         id: doc.id,
         title: doc.fileName,
@@ -800,7 +820,7 @@ export class AuthService {
         apiKeysCount: apiKeys.length,
       },
       recentActivity,
-      recommendations: recommendationProperties.map((p: any) => ({
+      recommendations: recommendationProperties.map((p: PropertyWithOwnerName) => ({
         id: p.id,
         title: p.title,
         address: p.address,
@@ -1061,7 +1081,7 @@ export class AuthService {
       orderBy: { createdAt: 'desc' },
     });
 
-    return apiKeys.map((apiKey: any) => this.toApiKeyResponse(apiKey));
+    return apiKeys.map((apiKey: ApiKey) => this.toApiKeyResponse(apiKey));
   }
 
   async rotateApiKey(user: AuthUserPayload, apiKeyId: string) {
@@ -1431,7 +1451,7 @@ export class AuthService {
     return `pc_${randomToken(24)}`;
   }
 
-  private toApiKeyResponse(apiKey: any) {
+  private toApiKeyResponse(apiKey: ApiKey) {
     return {
       id: apiKey.id,
       name: apiKey.name,
@@ -1575,7 +1595,7 @@ export class AuthService {
       if (historyEntries.length > 0) {
         await tx.passwordHistory.deleteMany({
           where: {
-            id: { in: historyEntries.map((entry: any) => entry.id) },
+            id: { in: historyEntries.map((entry: PasswordHistory) => entry.id) },
           },
         });
       }
@@ -1652,7 +1672,7 @@ export class AuthService {
         body: `secret=${secret}&response=${token}`,
       });
 
-      const data = (await response.json()) as any;
+      const data = (await response.json()) as RecaptchaVerifyResponse;
 
       // reCAPTCHA v3 returns a score between 0.0 and 1.0. Typically, 0.5 is a good threshold.
       if (data.success && data.score !== undefined && data.score >= 0.5) {

src/auth/auth.service.ts

@@ -10,6 +10,7 @@ import {
   Logger,
 } from '@nestjs/common';
 import { Reflector } from '@nestjs/core';
+import { Request } from 'express';
 import { RateLimitService } from '../rate-limit.service';
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 import { RATE_LIMIT_HEADERS } from '../rate-limit.config';
@@ -159,7 +160,7 @@ export class RateLimitGuard implements CanActivate {
   /**
    * Extract client IP from request
    */
-  private getClientIp(request: any): string {
+  private getClientIp(request: Request): string {
     return (
       request.headers['x-forwarded-for']?.split(',')[0].trim() ||
       request.connection?.remoteAddress ||

src/auth/guards/rate-limit.guard.ts

@@ -11,9 +11,7 @@ import { RATE_LIMIT_HEADERS } from '../rate-limit.config';
  */
 @Injectable()
 export class RateLimitHeadersInterceptor implements NestInterceptor {
-  intercept(context: ExecutionContext, next: CallHandler): Observable<any> {
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    const request = context.switchToHttp().getRequest();
+  intercept(context: ExecutionContext, next: CallHandler): Observable<unknown> {
     const response = context.switchToHttp().getResponse();
 
     return next.handle().pipe(

src/auth/interceptors/rate-limit-headers.interceptor.ts

@@ -1,8 +1,18 @@
 import { LoginRateLimitService } from './login-rate-limit.service';
+import { PrismaService } from '../database/prisma.service';
+
+interface MockPrisma {
+  loginAttempt: {
+    findFirst: jest.Mock;
+    count: jest.Mock;
+    create: jest.Mock;
+    updateMany: jest.Mock;
+  };
+}
 
 describe('LoginRateLimitService', () => {
   let service: LoginRateLimitService;
-  let mockPrisma: any;
+  let mockPrisma: MockPrisma;
 
   const email = 'test@example.com';
   const ip = '1.2.3.4';
@@ -16,7 +26,7 @@ describe('LoginRateLimitService', () => {
         updateMany: jest.fn().mockResolvedValue({ count: 1 }),
       },
     };
-    service = new LoginRateLimitService(mockPrisma);
+    service = new LoginRateLimitService(mockPrisma as unknown as PrismaService);
   });
 
   describe('isAccountLocked', () => {