Segmentation fault while background copying

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/1500
Reporter	IMDagger (imdagger@….ru)
Mentions	imdagger@….ru, mva@….name
Keywords	background, copy, ftp

Test case:

• create file with name "test" in "tmp" directory (for example)
• create directory with same name ("test") in other "tmp2" directory (for example)
• try to copy or move file "test" into "tmp2" in background mode
• wait for some time

Note

Original attachments:

• background.diff (raw) by IMDagger (imdagger@….ru) on Aug 8, 2009 at 16:56 UTC
• background_fix_assert.diff (raw) by IMDagger (imdagger@….ru) on Oct 22, 2009 at 16:16 UTC
• full_bg_patch.diff (raw) by IMDagger (imdagger@….ru) on Oct 24, 2009 at 12:05 UTC
• 0001-Fixed-problems.patch (raw) by IMDagger (imdagger@….ru) on Oct 24, 2009 at 12:57 UTC

[mc-butler]

Changed by IMDagger (imdagger@….ru) on Aug 8, 2009 at 16:56 UTC

• Attachment background.diff (raw) added

[mc-butler]

Changed by IMDagger (imdagger@….ru) on Aug 8, 2009 at 17:14 UTC (comment 1)

• Cc set to imdagger@….ru

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Sep 30, 2009 at 6:34 UTC (comment 2)

• Milestone changed from 4.7 to 4.7.0-pre4

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 19, 2009 at 21:15 UTC (comment 3)

• Status changed from new to accepted
• Owner set to slavazanko

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 19, 2009 at 21:26 UTC (comment 4)

Looks good, but if need replace existing file assertion raised:

** (mc:25716): CRITICAL **: file_progress_real_query_replace: assertion `ctx->ui != NULL' failed

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 19, 2009 at 22:01 UTC (comment 5)

• Severity changed from no branch to on rework

Created branch 1500_segfault_on_bg_copy ([c75ebb2ab9b9002bc26741968092d32dc048104d])

Status: on rework (need to fix assertion).

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 20, 2009 at 12:15 UTC (comment 6)

• Milestone changed from 4.7.0-pre4 to 4.7

[mc-butler]

Changed by IMDagger (imdagger@….ru) on Oct 22, 2009 at 16:16 UTC

• Attachment background_fix_assert.diff (raw) added

Fix for "assert trouble" when file is replaced

[mc-butler]

Changed by IMDagger (imdagger@….ru) on Oct 22, 2009 at 16:24 UTC (comment 7)

Last patch is for ([c75ebb2ab9b9002bc26741968092d32dc048104d]), but branch has trouble with background processes yet. Trouble:

• copy file in background
• look at background process list by C-x j

Process has been already done, but still draw in list.

[mc-butler]

Changed by IMDagger (imdagger@….ru) on Oct 24, 2009 at 12:05 UTC

• Attachment full_bg_patch.diff (raw) added

Last patch and fix for process list

[mc-butler]

Changed by IMDagger (imdagger@….ru) on Oct 24, 2009 at 12:57 UTC

• Attachment 0001-Fixed-problems.patch (raw) added

Same as last, but in patch-format and with description

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 27, 2009 at 20:23 UTC (comment 8)

• Keywords changed from rework, background, copy to background, copy
• Severity changed from on rework to on review
• Milestone changed from 4.7 to 4.7.0-pre4

Ok, all looks good.

remind: branch 1500_segfault_on_bg_copy

Changesets:

• [3fad2e6d265ebfe3f65eac80ce659e2063fdcf96]: Segmentation fault while background copying
• [9778d571ba00e4d043f4cb461224d8bc1ffab068]: Some fixies for background copy.

Review, please.

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 27, 2009 at 20:24 UTC (comment 9)

• Votes set to slavazanko

[mc-butler]

Changed by iNode (@iNode) on Oct 28, 2009 at 9:55 UTC (comment 10)

• Severity changed from on review to approved
• Votes changed from slavazanko to slavazanko iNode

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 28, 2009 at 10:01 UTC (comment 11)

• Status changed from accepted to testing
• Votes changed from slavazanko iNode to commited-master
• Severity changed from approved to merged
• Resolution set to fixed

merge [9c854e7]