force utf option

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2282
Reporter	zyxmon (zyxmon@….com)

I have arm based nas (synology ds110j), that does not support locales but stores files in uft-8.
The sample program

#include <langinfo.h>
#include <locale.h>
#include <stdio.h>

int
main (int argc, char *argv[])
{
    setlocale (LC_ALL, "");
    printf ("%s\n", nl_langinfo (CODESET));
    return 0;
}

always returns ANSI_X3.4-1968

To make mc correctly work with utf-8 on this system I've made changes in 2 files:
1) In lib/strutil/strutil.c
I've changed

return (nl_langinfo (CODESET));

to

return "UTF8";

2) In lib\tty\tty-slang.c
I've changed

SLutf8_enable (-1); 

to

SLutf8_enable (1); 

These changes force utf-8 support in mc on my system.
I think these changes can be made an option in future releases in mc for such systems.

PS Many thanks to il.smind, who helped my to find this solution.

Note

Original attachments:

• 100-strutil.patch (raw) by zyxmon (zyxmon@….com) on Mar 29, 2011 at 9:28 UTC
• 200-tty.patch (raw) by zyxmon (zyxmon@….com) on Mar 29, 2011 at 9:28 UTC

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 15, 2010 at 16:07 UTC (comment 1)

• Version 4.7.3 deleted
• Component changed from mc-core to mc-tty
• Resolution set to wontfix
• Status changed from new to closed
• Milestone 4.7 deleted

It's terrible. This durty hack cannot be applied in MC.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jul 15, 2010 at 16:59 UTC (comment 2)

• Status changed from closed to reopened
• Resolution wontfix deleted

need fix FAQ and maybe add patch into 'contrib'

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jul 15, 2010 at 17:00 UTC (comment 3)

• Milestone set to 4.7.4
• Priority changed from major to minor
• Version set to master

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Sep 9, 2010 at 12:31 UTC (comment 4)

• Milestone changed from 4.7.4 to 4.7.5

[mc-butler]

Changed by zyxmon (zyxmon@….com) on Mar 29, 2011 at 6:49 UTC (comment 5)

Just a small remark on my patches. The correct fix for lib/strutil/strutil.c is

return "UTF-8";

These patches also helped to show nonascii chars on mc compiled for mipsel based router.

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 29, 2011 at 7:03 UTC (comment 6)

Again, if your OS supports UTF-8, but nl_langinfo (CODESET) doesn't return an "UTF-8" string, then OS itself should be fixed not MC.

[mc-butler]

Changed by zyxmon (zyxmon@….com) on Mar 29, 2011 at 7:16 UTC (comment 7)

The nl_langinfo on the mipsel router retured "ascii", so this patch was needed.

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 29, 2011 at 7:47 UTC (comment 7.8)

Replying to zyxmon:

The nl_langinfo on the mipsel router retured "ascii"

Yes. I'm talking about that. In any case, this bug in not in MC but in target OS. Do you agree with me?

so this patch was needed.

If your OS has some package management system, you can build the MC package with this OS-specific patch, can't you?

[mc-butler]

Changed by zyxmon (zyxmon@….com) on Mar 29, 2011 at 7:58 UTC (comment 9)

I totally agree with you, this is not a bug in MC. My last remark was just a small correction for the first post. The correct encoding name is "UTF-8". "UTF8" may be just an alias to "UTF-8".
These are OS specific patches.

[mc-butler]

Changed by zyxmon (zyxmon@….com) on Mar 29, 2011 at 9:28 UTC

• Attachment 100-strutil.patch (raw) added

[mc-butler]

Changed by zyxmon (zyxmon@….com) on Mar 29, 2011 at 9:28 UTC

• Attachment 200-tty.patch (raw) added

[mc-butler]

Changed by zyxmon (zyxmon@….com) on Mar 29, 2011 at 9:30 UTC (comment 10)

I have added two patches for mc-4.7.5.1 just in case one has such an OS and needs them.
They will work for optware and openwrt package systems. Openwrt Makefile for mc needs a lot of changes for building mc-4.7.5.1 with slang2 for these patches to work.

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 6, 2011 at 7:32 UTC (comment 11)

• Branch state set to no branch
• Milestone changed from 4.7.5 to Future Releases
• Priority changed from minor to trivial