Merge branch 'PVW-2053-fix-e2e-tests-browserstack' into 'main'

PVW-2053: Fix & cleanup e2e test suite

See merge request wallet/nl-wallet!615

Author: daandebie

uiautomation/src/main/kotlin/helper/LocalizationHelper.kt

@@ -10,7 +10,7 @@ class LocalizationHelper {
 
     fun getString(key: String): String {
         val path = "../wallet_app/lib/l10n"
-        val jsonFile = File("$path/intl_`${if (language == "NL") "nl" else "en"}`.arb")
+        val jsonFile = File("$path/intl_${if (language == "NL") "nl" else "en"}.arb")
         val json = jsonFile.readText()
 
         val moshi = Moshi.Builder().add(KotlinJsonAdapterFactory()).build()

uiautomation/src/test/kotlin/feature/dashboard/DashboardTests.kt

@@ -43,7 +43,7 @@ class DashboardTests : TestBase() {
     }
 
     @RetryingTest(value = MAX_RETRY_COUNT, name = "{displayName} - {index}")
-    @DisplayName("4. Tapping the card opens the card's details [UC 7.2]")
+    @DisplayName("4. Tapping the card opens the card's details.")
     fun verifyCardDetailScreen() {
         dashboardScreen.clickPidCard()
 

uiautomation/src/test/kotlin/feature/security/SecurityConfirmPinTests.kt

@@ -22,7 +22,6 @@ class SecurityConfirmPinTests : TestBase() {
         OnboardingNavigator().toScreen(OnboardingScreen.SecurityConfirmPin)
 
         pinScreen = PinScreen()
-        pinScreen.enterPin(chosenPin)
     }
 
     @RetryingTest(value = MAX_RETRY_COUNT, name = "{displayName} - {index}")

uiautomation/src/test/kotlin/navigator/OnboardingNavigator.kt

@@ -1,5 +1,6 @@
 package navigator
 
+import navigator.screen.OnboardingScreen
 import screen.digid.DigidLoginMockWebPage
 import screen.digid.DigidLoginStartWebPage
 import screen.introduction.IntroductionConditionsScreen

uiautomation/src/test/kotlin/screen/dashboard/DashboardScreen.kt

@@ -1,11 +1,13 @@
 package screen.dashboard
 
-import screen.home.HomeScreen
+import util.MobileActions
 
-class DashboardScreen : HomeScreen() {
+class DashboardScreen : MobileActions() {
 
     private val screen = find.byValueKey("dashboardScreen")
 
+    private val menuButton = find.byToolTip(l10n.getString("dashboardScreenTitle"))
+
     private val pidIdCard = find.byValueKey("com.example.pid")
     private val pidAddressCard = find.byValueKey("com.example.address")
 
@@ -25,5 +27,7 @@ class DashboardScreen : HomeScreen() {
         return pidY < addressY
     }
 
+    fun clickMenuButton() = clickElement(menuButton, false)
+
     fun clickPidCard() = clickElement(pidIdCard, false)
 }