Fixed some linting and runtime issues

Author: Wunderwaffel

backend/app/main.py

@@ -1,12 +1,14 @@
 import logging
 from contextlib import asynccontextmanager
-from typing import Any, AsyncGenerator
+from typing import Any, AsyncGenerator, Callable, cast
 
 from fastapi import FastAPI
 from slowapi import _rate_limit_exceeded_handler
 from slowapi.errors import RateLimitExceeded
 from slowapi.middleware import SlowAPIMiddleware
 from starlette.middleware.cors import CORSMiddleware
+from starlette.requests import Request
+from starlette.responses import Response
 
 from app.core.config import settings
 from app.core.database import init_db
@@ -58,7 +60,10 @@ async def lifespan(_app: FastAPI) -> AsyncGenerator[None, Any]:
 )
 
 app.state.limiter = limiter
-app.add_exception_handler(RateLimitExceeded, _rate_limit_exceeded_handler)
+app.add_exception_handler(
+    RateLimitExceeded,
+    cast(Callable[[Request, Exception], Response], _rate_limit_exceeded_handler),
+)
 app.add_middleware(SlowAPIMiddleware)
 
 # ---------------------------------------------------------

backend/app/services/paper_service.py

@@ -36,7 +36,7 @@ async def summarise_paper(
         """
         if query and query.strip():
             if not await SafetyService.check_moderation(query):
-                logger.warning(f"Blocked toxic summary query: {query}")
+                logger.warning("Blocked toxic summary query: %s", query)
                 raise HTTPException(status_code=400, detail="Query violates content safety policy.")
 
         external_id = "unknown"
@@ -49,7 +49,7 @@ async def summarise_paper(
 
             raw_dump = json.dumps(summary_payload)
             if not SafetyService.validate_output(raw_dump):
-                logger.critical(f"Canary triggered in summary for {external_id}")
+                logger.critical("Canary triggered in summary for %s", external_id)
                 raise HTTPException(status_code=500, detail="Generation failed safety check.")
 
             return PaperSummaryResponse.model_validate(summary_payload)
@@ -80,7 +80,7 @@ async def get_chat_answer(
         Generates an AI response based on paper content and chat history.
         """
         if not await SafetyService.check_moderation(user_query):
-            logger.warning(f"Blocked toxic user query: {user_query}")
+            logger.warning("Blocked toxic user query: %s", user_query)
             return "I cannot answer this query as it violates our safety policies."
 
         external_id = "unknown"

backend/app/services/search_service.py

@@ -32,7 +32,7 @@ async def search_papers(query: str, db: AsyncSession) -> SearchResponse:
         openai_provider = get_openai_provider()
 
         if not await SafetyService.check_moderation(query):
-            logger.warning(f"Blocked toxic search query: {query}")
+            logger.warning("Blocked toxic search query: %s", query)
             raise HTTPException(status_code=400, detail="Search query violates safety policies.")
 
         # Extract + normalize keywords with retry
@@ -64,7 +64,7 @@ async def search_papers_from_pdf(
         """
         if query and query.strip():
             if not await SafetyService.check_moderation(query):
-                logger.warning(f"Blocked toxic PDF context query: {query}")
+                logger.warning("Blocked toxic PDF context query: %s", query)
                 raise HTTPException(
                     status_code=400, detail="Context query violates safety policies."
                 )