Normalize username identifier

Author: MoSchmidt

README.md

@@ -140,5 +140,5 @@ Bruno is a lightweight, file-based API client that stores requests in plain text
 
 Before authenticating, a user must be created:
 
-1. Run the **Users → Create User** request and provide only a `user_name` in the request body.
-2. Next, use the **Authentication → Login** request with the same `user_name` to obtain an access and refresh token.
+1. Run the **Users → Create User** request and provide only a `username` in the request body.
+2. Next, use the **Authentication → Login** request with the same `username` to obtain an access and refresh token.

backend/app/core/security.py

@@ -46,7 +46,7 @@ def verify_token(token: str) -> Optional[Dict[str, Any]]:
 
 
 def get_current_user(token: str = Depends(oauth2_scheme)) -> str:
-    """Return the user name encoded in the access token."""
+    """Return the username encoded in the access token."""
 
     payload = verify_token(token)
     if not payload:
@@ -56,11 +56,11 @@ def get_current_user(token: str = Depends(oauth2_scheme)) -> str:
             headers={"WWW-Authenticate": "Bearer"},
         )
 
-    user_name = payload.get("sub")
-    if not user_name:
+    username = payload.get("sub")
+    if not username:
         raise HTTPException(
             status_code=status.HTTP_401_UNAUTHORIZED,
             detail="Invalid token payload.",
         )
 
-    return user_name
+    return username

backend/app/models/user.py

@@ -17,7 +17,7 @@ class User(Base):
     __tablename__ = "user"
 
     user_id: Mapped[int] = mapped_column(BigInteger, primary_key=True, index=True)
-    user_name: Mapped[str] = mapped_column(String(50), unique=True, nullable=False, index=True)
+    username: Mapped[str] = mapped_column(String(50), unique=True, nullable=False, index=True)
     created_at: Mapped[datetime] = mapped_column(
         DateTime(timezone=True), nullable=False, server_default=func.now()
     )

backend/app/routes/auth_routes.py

@@ -26,15 +26,15 @@
 def login(request: LoginRequest, db: Session = Depends(get_db)) -> LoginResponse:
     """Authenticate a user and return access plus refresh tokens."""
 
-    user = db.query(User).filter(User.user_name == request.user_name).first()
+    user = db.query(User).filter(User.username == request.username).first()
     if not user:
         raise HTTPException(
             status_code=status.HTTP_401_UNAUTHORIZED,
-            detail="Invalid user name.",
+            detail="Invalid username.",
         )
 
-    access_token = create_access_token({"sub": user.user_name})
-    refresh_token = create_refresh_token({"sub": user.user_name})
+    access_token = create_access_token({"sub": user.username})
+    refresh_token = create_refresh_token({"sub": user.username})
 
     user_dto = UserResponse.model_validate(user)
 
@@ -62,7 +62,7 @@ def refresh_access_token(request: RefreshRequest) -> RefreshResponse:
             detail="Invalid or expired refresh token",
         )
 
-    user_name = payload.get("sub")
-    new_access_token = create_access_token({"sub": user_name})
+    username = payload.get("sub")
+    new_access_token = create_access_token({"sub": username})
 
     return RefreshResponse(access_token=new_access_token, token_type="bearer")

backend/app/routes/user_routes.py

@@ -16,19 +16,19 @@
 class UserCreate(BaseModel):
     """Payload used when creating a new user."""
 
-    user_name: str
+    username: str
 
 
 @router.post("/", response_model=UserResponse, status_code=status.HTTP_201_CREATED)
 def create_user(request: UserCreate, db: Session = Depends(get_db)) -> User:
-    """Create a new user record if the user name is available."""
+    """Create a new user record if the username is available."""
 
-    if db.query(User).filter(User.user_name == request.user_name).first():
+    if db.query(User).filter(User.username == request.username).first():
         raise HTTPException(
             status_code=status.HTTP_400_BAD_REQUEST,
-            detail="User name already exists",
+            detail="Username already exists",
         )
-    user = User(user_name=request.user_name)
+    user = User(username=request.username)
     db.add(user)
     db.commit()
     db.refresh(user)
@@ -37,12 +37,12 @@ def create_user(request: UserCreate, db: Session = Depends(get_db)) -> User:
 
 @router.get("/me", response_model=UserResponse, status_code=status.HTTP_200_OK)
 def get_current_user_profile(
-    current_user_name: str = Depends(get_current_user),
+    current_username: str = Depends(get_current_user),
     db: Session = Depends(get_db),
 ) -> User:
     """Return the user information for the authenticated principal."""
 
-    user = db.query(User).filter(User.user_name == current_user_name).first()
+    user = db.query(User).filter(User.username == current_username).first()
     if not user:
         raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="User not found.")
 

backend/app/schemas/auth_dto.py

@@ -8,7 +8,7 @@
 class LoginRequest(BaseModel):
     """Payload for authenticating a user."""
 
-    user_name: str
+    username: str
 
 
 class LoginResponse(BaseModel):

backend/app/schemas/user_dto.py

@@ -9,7 +9,7 @@ class UserResponse(BaseModel):
     """Representation of a user returned by the API."""
 
     user_id: int
-    user_name: str
+    username: str
     created_at: datetime
 
     class Config:  # pylint: disable=too-few-public-methods

bruno/Inquiro Bruno/Authentication/Login.bru

@@ -12,7 +12,7 @@ post {
 
 body:json {
   {
-    "user_name": "user"
+    "username": "user"
   }
 }
 

bruno/Inquiro Bruno/Users/Create User.bru

@@ -12,6 +12,6 @@ post {
 
 body:json {
   {
-    "user_name": "user"
+    "username": "user"
   }
 }

frontend/src/components/LoginView.vue

@@ -4,7 +4,7 @@ import axios from 'axios';
 import { useRouter } from 'vue-router';
 import { useAuthStore } from '@/stores/auth';
 
-const userName = ref('michael');
+const username = ref('michael');
 const errorMessage = ref(null);
 const isLoading = ref(false);
 
@@ -18,7 +18,7 @@ const handleLogin = async () => {
   try {
     console.log("Trying to login")
     const response = await axios.post('http://localhost:8000/auth/login', {
-      user_name: userName.value,
+      username: username.value,
     });
     console.log(response)