Skip to content

Commit fc02329

Browse files
committed
fix mypy
1 parent e9ef919 commit fc02329

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

backend/app/repositories/search_repository.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from datetime import date
22
from typing import List, Optional, Tuple, Union
33

4-
from sqlalchemy import and_, or_, select, ClauseElement
4+
from sqlalchemy import ColumnElement, and_, or_, select
55
from sqlalchemy.ext.asyncio import AsyncSession
66

77
from app.models.paper import Paper as PaperModel
@@ -72,7 +72,7 @@ def _build_filter_clauses(search_filter: AdvancedSearchFilter) -> list:
7272
return clauses
7373

7474
@staticmethod
75-
def _build_group_clause(group: ConditionGroup) -> Optional[ClauseElement]:
75+
def _build_group_clause(group: ConditionGroup) -> Optional[ColumnElement[bool]]:
7676
"""Recursively build an AND/OR clause from a ConditionGroup."""
7777
if not group.children:
7878
return None
@@ -91,7 +91,7 @@ def _build_group_clause(group: ConditionGroup) -> Optional[ClauseElement]:
9191
return or_(*child_clauses)
9292

9393
@staticmethod
94-
def _build_node_clause(node: Union[TextCondition, ConditionGroup]) -> Optional[ClauseElement]:
94+
def _build_node_clause(node: Union[TextCondition, ConditionGroup]) -> Optional[ColumnElement[bool]]:
9595
"""Build a clause for a single node (condition or nested group)."""
9696
if node.type == "group":
9797
return SearchRepository._build_group_clause(node)

backend/app/schemas/search_dto.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ class AdvancedSearchFilter(BaseModel):
3535

3636
@model_validator(mode="after")
3737
def check_year_range(self) -> AdvancedSearchFilter:
38+
"""Validate year_from is larger or equal to year_to."""
3839
if self.year_from is not None and self.year_to is not None:
3940
if self.year_from > self.year_to:
4041
raise ValueError("year_from must be <= year_to")

0 commit comments

Comments
 (0)