fix test messages,C++ comment style, and edited contributor list

Author: Mohit242-bit

doc/src/pgRouting-introduction.rst

@@ -66,11 +66,8 @@ This Release Contributors
 Individuals in this release v4.0.0 (in alphabetical order)
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-Bipasha Gayary,
-Fan Wu,
 Mohit Rawat,
 Regina Obe,
-Saloni kumari,
 Vicky Vergara
 
 

pgtap/withPoints/withPoints/edge_cases/issue_2966.pg

@@ -34,7 +34,7 @@ $BODY$
 BEGIN
 
   IF NOT min_version('4.1.0') THEN
-    RETURN QUERY SELECT skip(1, 'pgr_withPoints: Issue 2966 test requires 4.1.0+');
+    RETURN QUERY SELECT skip(1, 'pgr_withPoints: Fix implemented on 4.1.0');
     RETURN;
   END IF;
 
@@ -45,48 +45,44 @@ BEGIN
     (102::BIGINT, 1002::BIGINT, 1003::BIGINT, 100::FLOAT, 100::FLOAT)
   ) AS t(id, source, target, cost, reverse_cost);
 
-  -- Test 1: fraction = 0.99 should work correctly (baseline)
   RETURN QUERY SELECT set_eq(
     $$SELECT round(agg_cost::numeric, 2)::TEXT FROM pgr_withPoints(
       'SELECT * FROM test_edges',
       'SELECT * FROM (VALUES (1, 100, 0.5), (2, 101, 0.99)) AS t(pid, edge_id, fraction)',
       -1, -2
     ) WHERE edge < 0$$,
     ARRAY['16.88']::TEXT[],
-    'Issue 2966: fraction=0.99 should route correctly (baseline test)'
+    'pgr_withPoints: fraction=0.99 baseline test'
   );
 
-  -- Test 2: fraction = 1 should ALSO work correctly (regression for issue 2966, which previously returned 105 instead of 17)
   RETURN QUERY SELECT set_eq(
     $$SELECT agg_cost::TEXT FROM pgr_withPoints(
       'SELECT * FROM test_edges',
       'SELECT * FROM (VALUES (1, 100, 0.5), (2, 101, 1)) AS t(pid, edge_id, fraction)',
       -1, -2
     ) WHERE edge < 0$$,
     ARRAY['17']::TEXT[],
-    'Issue 2966: fraction=1 should route via cheaper edge 101 (cost 17, not 105)'
+    'pgr_withPoints: expected cost is 17'
   );
 
-  -- Test 3: Verify the path goes through edge 101, not edge 102
   RETURN QUERY SELECT set_eq(
     $$SELECT edge::TEXT FROM pgr_withPoints(
       'SELECT * FROM test_edges',
       'SELECT * FROM (VALUES (1, 100, 0.5), (2, 101, 1)) AS t(pid, edge_id, fraction)',
       -1, -2
     ) WHERE edge > 0$$,
     ARRAY['100', '101']::TEXT[],
-    'Issue 2966: Path should use edges 100 and 101 (not 102)'
+    'pgr_withPoints: Path should use edges 100 and 101'
   );
 
-  -- Test 4: fraction = 0 case (control test)
   RETURN QUERY SELECT set_eq(
     $$SELECT agg_cost::TEXT FROM pgr_withPoints(
       'SELECT * FROM test_edges',
       'SELECT * FROM (VALUES (1, 100, 0.5), (2, 101, 0)) AS t(pid, edge_id, fraction)',
       -1, -2
     ) WHERE edge < 0$$,
     ARRAY['5']::TEXT[],
-    'Control test: fraction=0 should work (cost = 5 to reach start of edge 101)'
+    'pgr_withPoints: fraction=0 control test'
   );
 
   DROP TABLE test_edges;

pgtap/withPoints/withPointsVia/edge_cases/issue_2966.pg

@@ -34,7 +34,7 @@ $BODY$
 BEGIN
 
   IF NOT min_version('4.1.0') THEN
-    RETURN QUERY SELECT skip(1, 'pgr_withPointsVia: Issue 2966 test requires 4.1.0+');
+    RETURN QUERY SELECT skip(1, 'pgr_withPointsVia: Fix implemented on 4.1.0');
     RETURN;
   END IF;
 
@@ -45,7 +45,6 @@ BEGIN
     (102::BIGINT, 1002::BIGINT, 1003::BIGINT, 100::FLOAT, 100::FLOAT)
   ) AS t(id, source, target, cost, reverse_cost);
 
-  -- Test 1: fraction = 1 should work correctly
   RETURN QUERY SELECT set_eq(
     $$SELECT agg_cost::TEXT FROM pgr_withPointsVia(
       'SELECT * FROM test_edges',
@@ -54,10 +53,9 @@ BEGIN
       'b'
     ) WHERE edge < 0$$,
     ARRAY['17']::TEXT[],
-    'Issue 2966 (Via): fraction=1 should route correctly (cost 17, not 105)'
+    'pgr_withPointsVia: expected cost is 17'
   );
 
-  -- Test 2: Verify the path uses the correct edges
   RETURN QUERY SELECT set_eq(
     $$SELECT edge::TEXT FROM pgr_withPointsVia(
       'SELECT * FROM test_edges',
@@ -66,7 +64,7 @@ BEGIN
       'b'
     ) WHERE edge > 0$$,
     ARRAY['100', '101']::TEXT[],
-    'Issue 2966 (Via): Path should use edges 100 and 101'
+    'pgr_withPointsVia: Path should use edges 100 and 101'
   );
 
   DROP TABLE test_edges;

src/withPoints/withPoints.cpp

@@ -397,12 +397,14 @@ Pg_points_graph::create_new_edges() {
             if (point.fraction == 1) {
                 log << "point's vertex_id = target" << edge.target << "\n";
                 point.vertex_id = -point.pid;
-                // Zero-cost edge connecting target node to point (they're at same location)
+                /* Zero-cost edge connecting target node to point (they're at same location) */
                 Edge_t zero_edge = {edge.id, edge.target, -point.pid, 0, 0};
                 m_new_edges.push_back(zero_edge);
 
-                // Also create edge from previous target to this point
-                // This allows Dijkstra to find the direct path through this edge
+                /*
+                 * Also create edge from previous target to this point
+                 * This allows Dijkstra to find the direct path through this edge
+                 */
                 double delta = point.fraction - prev_fraction;
                 double rdelta = point.fraction - prev_rfraction;
                 if (delta > 0) {
@@ -412,7 +414,7 @@ Pg_points_graph::create_new_edges() {
                         m_new_edges.push_back(cost_edge);
                         last_cost = cost_to_point;
                     }
-                    // Update forward tracking variables
+                    /* Update forward tracking variables */
                     prev_target = point.vertex_id;
                     prev_fraction = point.fraction;
                     agg_cost += last_cost;
@@ -424,7 +426,7 @@ Pg_points_graph::create_new_edges() {
                         m_new_edges.push_back(rcost_edge);
                         last_rcost = rcost_to_point;
                     }
-                    // Update reverse tracking variables
+                    /* Update reverse tracking variables */
                     prev_rtarget = point.vertex_id;
                     prev_rfraction = point.fraction;
                     agg_rcost += last_rcost;