Code Quality: Issues found with PVS-Studio Static Analyzer

[rip-mm]

Hello.

I am a developer at PVS-Studio and I have checked the project using the PVS-Studio analyzer. If you could take a look at suspicious fragment:

func (vec *Vector) Push(value core.Value) *Vector {
  slice := vec.getCurrentSlice()
  slice[len(slice)] = value

  return vec
}

PVS-Studio warning: V8031 Using the call of the 'len' function as index will cause off-by-one error. Consider using 'len(slice) - 1' instead. vector.go 28

If there is anything I can do to assist, please let me know.

[ziflex]

Thanks for taking the time to investigate this!

The code you found is actually a leftover from some early v1 experiments. Looking back, it was never wired into the runtime and, in fact, was never used by v1 at all. I simply forgot to remove it. 🤦‍♂️

The current v2 runtime has a completely different implementation, so this code path isn’t exercised anywhere.

I’ll remove the leftover to avoid confusion. Thanks for pointing it out!