Skip to content

Commit 21c3ff5

Browse files
manuelmauroRomarQ
andauthored
docs(moonbeam-engineering): add compile-with-tests step to cherry-pick verification (#52)
## What Adds a **"Verify the branch compiles"** step to the `qa-cherry-picks` skill's `verify-cherry-picks.md`, requiring `cargo check --workspace --tests` during fork-branch QA. ## Why The verification flow confirmed cherry-picks via git but never checked that the fork branch still built. Plain `cargo check --workspace` skips `#[cfg(test)]` modules and integration tests, so a cherry-pick — or an upstream refactor it lands on top of — can leave a test module that no longer compiles while the check still reports success. This was hit during the stable2603 cycle: evm's `evm-core` `delegation.rs` test module had been broken since an `Option`→`Result` API refactor, and a `--tests`-less check let it ride along undetected from one stable branch to the next. (Since fixed upstream: rust-ethereum/evm#405.) --------- Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
1 parent b58fc91 commit 21c3ff5

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

moonbeam-engineering/skills/qa-cherry-picks/verify-cherry-picks.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,15 @@ Upstream remotes by repo:
2020
| moonkit | moonbeam-foundation/moonkit (origin) | Moonsong-Labs/moonkit (branch: `main`) |
2121

2222
Then for each "Included" row, confirm the commit exists on the branch. For each "Dropped" row, confirm it does not.
23+
24+
## Verify the branch compiles
25+
26+
After confirming the cherry-picks are present, check that the fork branch still
27+
builds — **including test code**:
28+
29+
```bash
30+
cargo check --workspace --tests
31+
```
32+
33+
Always pass `--tests`. Plain `cargo check --workspace` skips `#[cfg(test)]`
34+
modules and integration tests.

0 commit comments

Comments
 (0)