Fix OverlayQuadFunction race condition

Author: soir20

common/src/main/java/io/github/moremcmeta/emissiveplugin/model/OverlayQuadFunction.java

@@ -19,6 +19,7 @@
 
 import io.github.moremcmeta.emissiveplugin.ModConstants;
 import io.github.moremcmeta.emissiveplugin.metadata.OverlayMetadata;
+import io.github.moremcmeta.moremcmeta.api.client.metadata.AnalyzedMetadata;
 import io.github.moremcmeta.moremcmeta.api.client.metadata.MetadataRegistry;
 import net.minecraft.client.Minecraft;
 import net.minecraft.client.renderer.block.model.BakedQuad;
@@ -28,8 +29,10 @@
 import net.minecraft.util.Mth;
 
 import java.util.List;
+import java.util.Optional;
 import java.util.function.Function;
 import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 /**
  * From a list of original {@link BakedQuad}s, produces a list of overlay quads that should be rendered
@@ -69,23 +72,22 @@ public OverlayQuadFunction() {
     @Override
     public List<BakedQuad> apply(List<BakedQuad> quads) {
         return quads.stream()
-                .filter(
-                        (quad) -> MetadataRegistry.INSTANCE
-                                .metadataFromSpriteName(ModConstants.MOD_ID, quad.sprite.getName())
-                                .isPresent()
-                ).map(
+                .flatMap(
                         (quad) -> {
-                            OverlayMetadata metadata = ((OverlayMetadata) MetadataRegistry.INSTANCE
-                                    .metadataFromSpriteName(ModConstants.MOD_ID, quad.sprite.getName())
-                                    .get());
+                            Optional<AnalyzedMetadata> metadataOptional = MetadataRegistry.INSTANCE
+                                    .metadataFromSpriteName(ModConstants.MOD_ID, quad.sprite.getName());
+                            if (!metadataOptional.isPresent()) {
+                                return Stream.of();
+                            }
 
+                            OverlayMetadata metadata = (OverlayMetadata) metadataOptional.get();
                             TextureAtlasSprite sprite = MODEL_MANAGER
                                     .getAtlas(TextureAtlas.LOCATION_BLOCKS)
                                     .getSprite(metadata.overlaySpriteName());
 
                             /* We have to cast because Minecraft's BakedModel interface expects a List<BakedQuad>,
                                not List<? extends BakedQuad>. */
-                            return (BakedQuad) new OverlayBakedQuad(
+                            return Stream.of((BakedQuad) new OverlayBakedQuad(
                                     makeOverlayVertexData(
                                             quad.getVertices(),
                                             sprite,
@@ -96,7 +98,7 @@ public List<BakedQuad> apply(List<BakedQuad> quads) {
                                     quad.getDirection(),
                                     sprite,
                                     metadata.isEmissive()
-                            );
+                            ));
 
                         }
                 )