[BatchOps] Enable "Uninstall" option for apps uninstalled without clearing data

MuntashirAkon · MuntashirAkon · commit 432ae7581fdf · 2025-08-19T01:48:04.000-07:00
Signed-off-by: Muntashir Al-Islam &lt;muntashirakon@riseup.net&gt;
diff --git a/app/src/main/java/io/github/muntashirakon/AppManager/compat/ApplicationInfoCompat.java b/app/src/main/java/io/github/muntashirakon/AppManager/compat/ApplicationInfoCompat.java
@@ -336,6 +336,12 @@ public static boolean isInstalled(@NonNull ApplicationInfo info) {
                 && Paths.exists(info.publicSourceDir);
     }
 
+    public static boolean isOnlyDataInstalled(@NonNull ApplicationInfo info) {
+        return (info.flags & ApplicationInfo.FLAG_INSTALLED) == 0
+                && !(info.processName != null
+                && Paths.exists(info.publicSourceDir));
+    }
+
     public static boolean isTestOnly(@NonNull ApplicationInfo info) {
         return (info.flags & ApplicationInfo.FLAG_TEST_ONLY) != 0;
     }
diff --git a/app/src/main/java/io/github/muntashirakon/AppManager/db/AppsDb.java b/app/src/main/java/io/github/muntashirakon/AppManager/db/AppsDb.java
@@ -23,9 +23,10 @@
 import io.github.muntashirakon.AppManager.db.entity.FreezeType;
 import io.github.muntashirakon.AppManager.db.entity.LogFilter;
 import io.github.muntashirakon.AppManager.db.entity.OpHistory;
+import io.github.muntashirakon.AppManager.logs.Log;
 import io.github.muntashirakon.AppManager.utils.ContextUtils;
 
-@Database(entities = {App.class, LogFilter.class, FileHash.class, Backup.class, OpHistory.class, FmFavorite.class, FreezeType.class}, version = 5)
+@Database(entities = {App.class, LogFilter.class, FileHash.class, Backup.class, OpHistory.class, FmFavorite.class, FreezeType.class}, version = 6)
 public abstract class AppsDb extends RoomDatabase {
     private static AppsDb sAppsDb;
 
@@ -47,13 +48,24 @@ public void migrate(@NonNull SupportSQLiteDatabase db) {
             db.execSQL("CREATE TABLE IF NOT EXISTS `freeze_type` (`package_name` TEXT NOT NULL, `type` INTEGER NOT NULL, PRIMARY KEY(`package_name`))");
         }
     };
+    public static final Migration M_5_6 = new Migration(5, 6) {
+        @Override
+        public void migrate(@NonNull SupportSQLiteDatabase db) {
+            db.execSQL("ALTER TABLE `app` ADD COLUMN `is_only_data_installed` INTEGER NOT NULL DEFAULT 0");
+        }
+    };
 
     public static AppsDb getInstance() {
         if (sAppsDb == null) {
             sAppsDb = Room.databaseBuilder(ContextUtils.getContext(), AppsDb.class, "apps.db")
-                    .addMigrations(M_2_3, M_3_4, M_4_5)
+                    .addMigrations(M_2_3, M_3_4, M_4_5, M_5_6)
                     .fallbackToDestructiveMigrationOnDowngrade()
                     .build();
+            try {
+                sAppsDb.appDao().getAll();
+            } catch (Throwable th) {
+                th.printStackTrace();
+            }
         }
         return sAppsDb;
     }
diff --git a/app/src/main/java/io/github/muntashirakon/AppManager/db/entity/App.java b/app/src/main/java/io/github/muntashirakon/AppManager/db/entity/App.java
@@ -69,6 +69,9 @@ public class App implements Serializable {
     @ColumnInfo(name = "is_installed", defaultValue = "true")
     public boolean isInstalled;
 
+    @ColumnInfo(name = "is_only_data_installed", defaultValue = "0")
+    public boolean isOnlyDataInstalled;
+
     @ColumnInfo(name = "is_enabled", defaultValue = "false")
     public boolean isEnabled;
 
@@ -133,6 +136,7 @@ public static App fromPackageInfo(@NonNull Context context, @NonNull PackageInfo
         app.uid = applicationInfo.uid;
         app.userId = UserHandleHidden.getUserId(app.uid);
         app.isInstalled = ApplicationInfoCompat.isInstalled(applicationInfo);
+        app.isOnlyDataInstalled = ApplicationInfoCompat.isOnlyDataInstalled(applicationInfo);
         app.flags = applicationInfo.flags;
         app.isEnabled = !FreezeUtils.isFrozen(applicationInfo);
         app.packageLabel = ApplicationInfoCompat.loadLabelSafe(applicationInfo, context.getPackageManager()).toString();
@@ -160,6 +164,7 @@ public static App fromBackup(@NonNull Backup backup) {
         app.uid = 0;
         app.userId = backup.userId;
         app.isInstalled = false;
+        app.isOnlyDataInstalled = false;
         if (backup.isSystem) {
             app.flags |= ApplicationInfo.FLAG_SYSTEM;
         }
diff --git a/app/src/main/java/io/github/muntashirakon/AppManager/main/ApplicationItem.java b/app/src/main/java/io/github/muntashirakon/AppManager/main/ApplicationItem.java
@@ -158,6 +158,7 @@ public class ApplicationItem extends PackageItemInfo implements IFilterableAppIn
      * Whether the app is installed
      */
     public boolean isInstalled = true;
+    public boolean isOnlyDataInstalled = true;
     /**
      * Whether the app has any activities
      */
diff --git a/app/src/main/java/io/github/muntashirakon/AppManager/main/MainBatchOpsHandler.java b/app/src/main/java/io/github/muntashirakon/AppManager/main/MainBatchOpsHandler.java
@@ -3,6 +3,7 @@
 package io.github.muntashirakon.AppManager.main;
 
 import android.Manifest;
+import android.content.pm.ApplicationInfo;
 import android.os.Build;
 import android.view.Menu;
 import android.view.MenuItem;
@@ -75,11 +76,15 @@ public boolean onSelectionChange(int selectionCount) {
         // Best case: O(1)
         // Worst case: O(n)
         boolean areAllInstalled = true;
+        boolean areAllUninstalledWithoutData = true;
         boolean areAllUninstalledSystem = true;
         boolean doAllUninstalledhaveBackup = true;
         for (ApplicationItem item : selectedItems) {
             if (item.isInstalled) continue;
             areAllInstalled = false;
+            if (areAllUninstalledWithoutData) {
+                areAllUninstalledWithoutData = item.isOnlyDataInstalled;
+            }
             if (!doAllUninstalledhaveBackup && !areAllUninstalledSystem) {
                 // No need to check further
                 break;
@@ -93,7 +98,7 @@ public boolean onSelectionChange(int selectionCount) {
         }
         /* === Enable/Disable === */
         // Enable “Uninstall” action iff all selections are installed
-        mUninstallMenu.setEnabled(nonZeroSelection && areAllInstalled);
+        mUninstallMenu.setEnabled(nonZeroSelection && (areAllInstalled || areAllUninstalledWithoutData));
         mFreezeUnfreezeMenu.setEnabled(nonZeroSelection && areAllInstalled);
         mForceStopMenu.setEnabled(nonZeroSelection && areAllInstalled);
         mClearDataCacheMenu.setEnabled(nonZeroSelection && areAllInstalled);
diff --git a/app/src/main/java/io/github/muntashirakon/AppManager/main/MainRecyclerAdapter.java b/app/src/main/java/io/github/muntashirakon/AppManager/main/MainRecyclerAdapter.java
@@ -391,6 +391,7 @@ private void handleClick(@NonNull ApplicationItem item) {
                 // The app is already installed, and we were wrong to assume that it was installed.
                 // Update data before opening it.
                 item.isInstalled = true;
+                item.isOnlyDataInstalled = false;
                 item.userIds = new int[]{UserHandleHidden.myUserId()};
                 Intent intent = AppDetailsActivity.getIntent(mActivity, item.packageName, UserHandleHidden.myUserId());
                 mActivity.startActivity(intent);
diff --git a/app/src/main/java/io/github/muntashirakon/AppManager/main/MainViewModel.java b/app/src/main/java/io/github/muntashirakon/AppManager/main/MainViewModel.java
@@ -718,6 +718,7 @@ private ApplicationItem getNewApplicationItem(@NonNull String packageName, @NonN
                 }
                 item.userIds = ArrayUtils.appendInt(item.userIds, app.userId);
                 item.isInstalled = true;
+                item.isOnlyDataInstalled = false;
                 item.openCount += app.openCount;
                 item.screenTime += app.screenTime;
                 if (item.lastUsageTime == 0L || item.lastUsageTime < app.lastUsageTime) {
@@ -742,6 +743,7 @@ private ApplicationItem getNewApplicationItem(@NonNull String packageName, @NonN
                 } else {
                     item.packageName = app.packageName;
                     item.isInstalled = false;
+                    item.isOnlyDataInstalled = app.isOnlyDataInstalled;
                     item.hasKeystore |= app.hasKeystore;
                 }
             }
diff --git a/app/src/main/java/io/github/muntashirakon/AppManager/oneclickops/OneClickOpsViewModel.java b/app/src/main/java/io/github/muntashirakon/AppManager/oneclickops/OneClickOpsViewModel.java
@@ -39,7 +39,6 @@
 import io.github.muntashirakon.AppManager.users.Users;
 import io.github.muntashirakon.AppManager.utils.PackageUtils;
 import io.github.muntashirakon.AppManager.utils.ThreadUtils;
-import io.github.muntashirakon.io.Paths;
 
 public class OneClickOpsViewModel extends AndroidViewModel {
     public static final String TAG = OneClickOpsViewModel.class.getSimpleName();
@@ -236,10 +235,12 @@ public void clearData() {
             HashSet<String> packageNames = new HashSet<>();
             for (ApplicationInfo applicationInfo : PackageUtils.getAllApplications(MATCH_UNINSTALLED_PACKAGES
                     | PackageManagerCompat.MATCH_STATIC_SHARED_AND_SDK_LIBRARIES)) {
-                if (packageNames.contains(applicationInfo.packageName) || isInstalled(applicationInfo)) {
+                if (packageNames.contains(applicationInfo.packageName)) {
                     continue;
                 }
-                packageNames.add(applicationInfo.packageName);
+                if (ApplicationInfoCompat.isOnlyDataInstalled(applicationInfo)) {
+                    packageNames.add(applicationInfo.packageName);
+                }
                 if (ThreadUtils.isInterrupted()) {
                     return;
                 }
@@ -287,8 +288,4 @@ private ItemCount getTrackerCountForApp(@NonNull PackageInfo packageInfo) {
         trackerCount.count = ComponentUtils.getTrackerComponentsForPackage(packageInfo).size();
         return trackerCount;
     }
-
-    private boolean isInstalled(@NonNull ApplicationInfo info) {
-        return info.processName != null && Paths.exists(info.publicSourceDir);
-    }
 }
diff --git a/app/src/main/java/io/github/muntashirakon/AppManager/utils/PackageUtils.java b/app/src/main/java/io/github/muntashirakon/AppManager/utils/PackageUtils.java
@@ -170,6 +170,7 @@ public static List<ApplicationItem> getInstalledOrBackedUpApplicationsFromDb(@No
                 }
                 item.userIds = ArrayUtils.appendInt(item.userIds, app.userId);
                 item.isInstalled = true;
+                item.isOnlyDataInstalled = false;
                 item.openCount += app.openCount;
                 item.screenTime += app.screenTime;
                 if (item.lastUsageTime == 0L || item.lastUsageTime < app.lastUsageTime) {
@@ -197,6 +198,7 @@ public static List<ApplicationItem> getInstalledOrBackedUpApplicationsFromDb(@No
                     item.packageName = app.packageName;
                     applicationItems.put(app.packageName, item);
                     item.isInstalled = false;
+                    item.isOnlyDataInstalled = app.isOnlyDataInstalled;
                     item.hasKeystore |= app.hasKeystore;
                 }
             }
@@ -237,6 +239,7 @@ public static List<ApplicationItem> getInstalledOrBackedUpApplicationsFromDb(@No
             item.isUser = !backup.isSystem;
             item.isDisabled = false;
             item.isInstalled = false;
+            item.isOnlyDataInstalled = false;
             item.hasSplits = backup.hasSplits;
             item.hasKeystore = backup.hasKeyStore;
             item.generateOtherInfo();

Original file line number	Diff line number	Diff line change
`@@ -336,6 +336,12 @@ public static boolean isInstalled(@NonNull ApplicationInfo info) {`
`336`	`336`	`&& Paths.exists(info.publicSourceDir);`
`337`	`337`	`}`
`338`	`338`
	`339`	`+ public static boolean isOnlyDataInstalled(@NonNull ApplicationInfo info) {`
	`340`	`+ return (info.flags & ApplicationInfo.FLAG_INSTALLED) == 0`
	`341`	`+ && !(info.processName != null`
	`342`	`+ && Paths.exists(info.publicSourceDir));`
	`343`	`+ }`
	`344`	`+`
`339`	`345`	`public static boolean isTestOnly(@NonNull ApplicationInfo info) {`
`340`	`346`	`return (info.flags & ApplicationInfo.FLAG_TEST_ONLY) != 0;`
`341`	`347`	`}`
Original file line number	Diff line number	Diff line change
`@@ -718,6 +718,7 @@ private ApplicationItem getNewApplicationItem(@NonNull String packageName, @NonN`
`718`	`718`	`}`
`719`	`719`	`item.userIds = ArrayUtils.appendInt(item.userIds, app.userId);`
`720`	`720`	`item.isInstalled = true;`
	`721`	`+ item.isOnlyDataInstalled = false;`
`721`	`722`	`item.openCount += app.openCount;`
`722`	`723`	`item.screenTime += app.screenTime;`
`723`	`724`	`if (item.lastUsageTime == 0L \|\| item.lastUsageTime < app.lastUsageTime) {`
`@@ -742,6 +743,7 @@ private ApplicationItem getNewApplicationItem(@NonNull String packageName, @NonN`
`742`	`743`	`} else {`
`743`	`744`	`item.packageName = app.packageName;`
`744`	`745`	`item.isInstalled = false;`
	`746`	`+ item.isOnlyDataInstalled = app.isOnlyDataInstalled;`
`745`	`747`	`item.hasKeystore \|= app.hasKeystore;`
`746`	`748`	`}`
`747`	`749`	`}`