Ensure consistency of the compiler and linker flags

Signed-off-by: Muntashir Al-Islam <muntashirakon@riseup.net>

Author: MuntashirAkon

app/src/main/cpp/CMakeLists.txt

@@ -1,27 +1,30 @@
 cmake_minimum_required(VERSION 3.4.1)
 
+project(AppManager LANGUAGES C CXX)
+
 set(CMAKE_CXX_STANDARD 17)
 
-set(C_FLAGS "-Werror=format -fdata-sections -ffunction-sections -fno-exceptions -fno-rtti -fno-threadsafe-statics")
-set(LINKER_FLAGS "-Wl,--hash-style=both -Wl,--build-id=none")
+# Global compiler flags
+set(COMMON_C_FLAGS "-Werror=format -fdata-sections -ffunction-sections -fno-exceptions -fno-rtti -fno-threadsafe-statics")
+if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
+    set(COMMON_C_FLAGS "${COMMON_C_FLAGS} -O2 -fvisibility=hidden -fvisibility-inlines-hidden")
+endif()
+
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${COMMON_C_FLAGS}")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${COMMON_C_FLAGS}")
 
+# Global linker flags
+set(BASE_LINK_FLAGS "-Wl,--hash-style=both -Wl,--build-id=none")
 if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
     message("Building Release...")
 
-    set(C_FLAGS "${C_FLAGS} -O2 -fvisibility=hidden -fvisibility-inlines-hidden")
-    set(LINKER_FLAGS "${LINKER_FLAGS} -Wl,-exclude-libs,ALL -Wl,--gc-sections")
+    set(BASE_LINK_FLAGS "${BASE_LINK_FLAGS} -Wl,-exclude-libs,ALL -Wl,--gc-sections")
 else()
     message("Building Debug...")
 
     add_definitions(-DDEBUG)
 endif ()
 
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${C_FLAGS}")
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${C_FLAGS}")
-
-set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ${LINKER_FLAGS}")
-set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} ${LINKER_FLAGS}")
-
 find_library(log-lib log)
 
 # BEGIN libam.so
@@ -33,9 +36,11 @@ add_library(am SHARED
 
 target_link_libraries(am ${log-lib})
 
+set_target_properties(am PROPERTIES LINK_FLAGS "${BASE_LINK_FLAGS}")
+
 if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
     add_custom_command(TARGET am POST_BUILD
-            COMMAND ${CMAKE_STRIP} --remove-section=.comment "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/libam.so")
+            COMMAND ${CMAKE_STRIP} --remove-section=.comment "$<TARGET_FILE:am>")
 endif ()
 
 # END libam.so
@@ -49,7 +54,7 @@ set_target_properties(run_server PROPERTIES
         PREFIX "lib"
         SUFFIX ".so"
         COMPILE_FLAGS "-fPIE -fPIC"
-        LINK_FLAGS "-pie"
+        LINK_FLAGS "-pie ${BASE_LINK_FLAGS}"
 )
 
 if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")