Merge pull request #1336 from marvs8/feat/social-links-controller-unit-tests

Feat/social links controller unit tests

Author: aji70

backend/src/social-link/social-links.controller.spec.ts

@@ -1,3 +1,4 @@
+import { BadRequestException, NotFoundException } from '@nestjs/common';
 import { ThrottlerGuard } from '@nestjs/throttler';
 import {
   THROTTLER_LIMIT,
@@ -6,6 +7,34 @@ import {
 import { SocialLinksDto } from './social-links.dto';
 import { SocialLinkController } from './social-links.controller';
 import { SocialLinksService } from './social-links.service';
+import { PaginatedResponseDto } from '../common/dto';
+import { SocialLinksListItem } from './social-links.service';
+
+// ─── shared mock ────────────────────────────────────────────────────────────
+
+const mockPaginatedResult: PaginatedResponseDto<SocialLinksListItem> = {
+  data: [],
+  cursor: null,
+  limit: 20,
+  nextCursor: null,
+  hasMore: false,
+  total: 0,
+  page: 1,
+  totalPages: 0,
+};
+
+const mockSocialLinksService = {
+  extractUpdatePayload: jest
+    .fn()
+    .mockImplementation((dto: SocialLinksDto) => dto),
+  createSocialLinks: jest
+    .fn()
+    .mockImplementation((dto: SocialLinksDto) => dto),
+  updateSocialLinks: jest
+    .fn()
+    .mockImplementation((_id: string, dto: SocialLinksDto) => dto),
+  listSocialLinks: jest.fn().mockReturnValue(mockPaginatedResult),
+};
 
 describe('SocialLinkController', () => {
   let controller: SocialLinkController;
@@ -30,12 +59,38 @@ describe('SocialLinkController', () => {
     expect(controller).toBeDefined();
   });
 
-  it('applies the throttler guard at the controller level', () => {
-    const guards = Reflect.getMetadata(
-      '__guards__',
-      SocialLinkController,
-    ) as unknown as Array<new () => unknown>;
-    expect(guards).toContain(ThrottlerGuard);
+  // ─── guard & throttle metadata ────────────────────────────────────────────
+
+  describe('guard and throttle metadata', () => {
+    it('applies the throttler guard at the controller level', () => {
+      const guards = Reflect.getMetadata(
+        '__guards__',
+        SocialLinkController,
+      ) as unknown as Array<new () => unknown>;
+      expect(guards).toContain(ThrottlerGuard);
+    });
+
+    it('configures create with the expected throttling policy', () => {
+      const createHandler = SocialLinkController.prototype.create;
+      const limit = Reflect.getMetadata(THROTTLER_LIMIT + 'default', createHandler);
+      const ttl = Reflect.getMetadata(THROTTLER_TTL + 'default', createHandler);
+      expect(limit).toBe(5);
+      expect(ttl).toBe(60000);
+    });
+
+    it('configures update with the expected throttling policy', () => {
+      const updateHandler = SocialLinkController.prototype.update;
+      const limit = Reflect.getMetadata(THROTTLER_LIMIT + 'default', updateHandler);
+      const ttl = Reflect.getMetadata(THROTTLER_TTL + 'default', updateHandler);
+      expect(limit).toBe(5);
+      expect(ttl).toBe(60000);
+    });
+
+    it('list (read endpoint) has no @Throttle metadata', () => {
+      const listHandler = SocialLinkController.prototype.list;
+      const limit = Reflect.getMetadata(THROTTLER_LIMIT + 'default', listHandler);
+      expect(limit).toBeUndefined();
+    });
   });
 
   it('configures create with the expected throttling policy', () => {
@@ -44,8 +99,13 @@ describe('SocialLinkController', () => {
     const limit: unknown = Reflect.getMetadata(THROTTLER_LIMIT + 'default', createHandler);
     const ttl: unknown = Reflect.getMetadata(THROTTLER_TTL + 'default', createHandler);
 
-    expect(limit).toBe(5);
-    expect(ttl).toBe(60000);
+    it('update has @ApiResponse for 404', () => {
+      const meta = Reflect.getMetadata(
+        'swagger/apiResponse',
+        SocialLinkController.prototype.update,
+      );
+      expect(meta?.['404']).toBeDefined();
+    });
   });
 
   it('configures update with the expected throttling policy', () => {
@@ -54,8 +114,18 @@ describe('SocialLinkController', () => {
     const limit: unknown = Reflect.getMetadata(THROTTLER_LIMIT + 'default', updateHandler);
     const ttl: unknown = Reflect.getMetadata(THROTTLER_TTL + 'default', updateHandler);
 
-    expect(limit).toBe(5);
-    expect(ttl).toBe(60000);
+      controller.list(pagination);
+
+      expect(mockSocialLinksService.listSocialLinks).toHaveBeenCalledWith(pagination);
+    });
+
+    it('propagates errors thrown by the service', () => {
+      mockSocialLinksService.listSocialLinks.mockImplementationOnce(() => {
+        throw new BadRequestException('Invalid pagination');
+      });
+
+      expect(() => controller.list({ page: -1, limit: 0 })).toThrow(BadRequestException);
+    });
   });
 
   describe('create', () => {