Merge branch 'main' into 980-add-initialize-admin-tests

Author: aji70

CHANGELOG.md

@@ -1,4 +1,4 @@
-# 0.1.0 (2026-06-26)
+# 0.1.0 (2026-06-27)
 
 
 ### Bug Fixes
@@ -356,6 +356,7 @@
 * **subscriptions:** GET fan–creator subscription state with auth ([2fec38f](https://github.com/MyFanss/MyFans/commit/2fec38f7d73e046ce497399ec412220b12fd8044))
 * **subscriptions:** map query status string to SubscriptionStatus enum ([0661159](https://github.com/MyFanss/MyFans/commit/0661159312d2cc5051c8c91e5b9a8b398c24b314))
 * **subscriptions:** track worst-case simulation resource fees ([bc60859](https://github.com/MyFanss/MyFans/commit/bc60859f713b928c27bae13c1ca43ab3b3319f63))
+* **test-consumer:** add admin authorization with unauthorized caller tests ([b939826](https://github.com/MyFanss/MyFans/commit/b93982696ed600f3e7c1d759d61a73a50158ef0d)), closes [#981](https://github.com/MyFanss/MyFans/issues/981)
 * treasury deposit event ([d474a33](https://github.com/MyFanss/MyFans/commit/d474a3395761d872b51735bf3d783ac9246d3c35))
 * Treasury-min-balance guard ([5e0bcf1](https://github.com/MyFanss/MyFans/commit/5e0bcf1a114cf65c4f232375fbdb43e40089f427))
 * **treasury:** add minimum balance or emergency pause protection ([#851](https://github.com/MyFanss/MyFans/issues/851)) ([81cfbfc](https://github.com/MyFanss/MyFans/commit/81cfbfc570c50ca3a047c726cc41cb87ea839de5))

contract/contracts/myfans-lib/README.md

@@ -1,10 +1,12 @@
 # MyFans Shared Library
 
-Shared types and enums for MyFans Soroban contracts.
+Shared types, enums, and error codes for MyFans Soroban contracts. This library provides common definitions used across all MyFans smart contracts, ensuring type safety and consistency.
 
-## Types
+## Public API
 
-### SubscriptionStatus
+### Enums
+
+#### SubscriptionStatus
 
 Represents the lifecycle status of a subscription.
 
@@ -17,9 +19,15 @@ pub enum SubscriptionStatus {
 }
 ```
 
-### ContentType
+**Properties:**
+- Soroban-compatible (decorated with `#[contracttype]`)
+- Copy, Clone, Debug, Eq, PartialEq
+- Serializable/deserializable
+- Represented as `u32` for efficient storage
 
-Represents content access type.
+#### ContentType
+
+Represents content access type classification.
 
 ```rust
 pub enum ContentType {
@@ -28,7 +36,89 @@ pub enum ContentType {
 }
 ```
 
-## Usage
+**Properties:**
+- Soroban-compatible (decorated with `#[contracttype]`)
+- Copy, Clone, Debug, Eq, PartialEq
+- Serializable/deserializable
+- Represented as `u32` for efficient storage
+
+#### MyfansError
+
+Shared error enum across all MyFans contracts. Error codes are preserved exactly for test snapshot compatibility.
+
+```rust
+pub enum MyfansError {
+    // Common init/admin errors
+    AlreadyInitialized = 1,
+    NotInitialized = 2,
+    NotAuthorized = 3,
+    // Balance/transfer errors
+    InsufficientBalance = 4,
+    // Fee/config errors
+    InvalidFeeBps = 5,
+    // Spam/security
+    RateLimited = 6,
+    AlreadyRegistered = 7,
+    NotLiked = 8,
+    // State control
+    Paused = 9,
+    // content-access specific
+    ContentPriceNotSet = 101,
+    // subscription specific
+    SubscriptionNotFound = 102,
+    SubscriptionExpired = 103,
+    AdminNotInitialized = 104,
+    // treasury specific
+    NegativeMinBalance = 105,
+    MinBalanceViolation = 106,
+}
+```
+
+**Properties:**
+- Decorated with `#[contracterror]` for Soroban error handling
+- Copy, Clone, Debug, Eq, PartialEq
+- Numeric discriminants are stable and fixed for compatibility
+
+### Modules
+
+#### error_codes
+
+Provides stable numeric error code constants for each contract, enabling clients (TypeScript SDK, backend, frontend) to inspect Soroban error results without hard-coding magic numbers.
+
+**Usage:**
+```rust
+use myfans_lib::error_codes::subscription as sub_err;
+
+// Check whether a Soroban invocation failed with SubscriptionNotFound:
+// if result.err() == Some(sub_err::SUBSCRIPTION_NOT_FOUND) { ... }
+```
+
+**Available sub-modules:**
+- `subscription` - Error codes for the subscription contract
+- `content_access` - Error codes for the content-access contract
+- `content_likes` - Error codes for the content-likes contract
+- `creator_registry` - Error codes for the creator-registry contract
+- `treasury` - Error codes for the treasury contract
+- `earnings` - Error codes for the earnings contract
+- `creator_earnings` - Error codes for the creator-earnings contract
+- `creator_deposits` - Error codes for the creator-deposits contract
+- `myfans_contract` - Error codes for the main myfans-contract
+
+**Note:** Error codes in each sub-module **must** match the `#[contracterror]` discriminants in the corresponding contract's `Error` enum. The `test-consumer` contract enforces this invariant through tests.
+
+#### test_fixtures
+
+Provides shared test fixtures for cross-contract integration tests. Only available when the `testutils` feature is enabled.
+
+**Usage:**
+```rust
+[dev-dependencies]
+myfans-lib = { path = "../myfans-lib", features = ["testutils"] }
+```
+
+## Getting Started
+
+### Installation
 
 Add to your contract's `Cargo.toml`:
 
@@ -37,22 +127,45 @@ Add to your contract's `Cargo.toml`:
 myfans-lib = { path = "../myfans-lib" }
 ```
 
-Import in your contract:
+### Basic Example
 
 ```rust
-use myfans_lib::{SubscriptionStatus, ContentType};
+use myfans_lib::{SubscriptionStatus, ContentType, MyfansError};
+use soroban_sdk::{contract, contractimpl, Env};
 
 #[contract]
 pub struct SubscriptionContract;
 
 #[contractimpl]
 impl SubscriptionContract {
-    pub fn create_subscription(env: Env) -> SubscriptionStatus {
-        SubscriptionStatus::Pending
+    /// Check if a subscription is active
+    pub fn is_active(_env: Env, status: SubscriptionStatus) -> bool {
+        status == SubscriptionStatus::Active
     }
 
-    pub fn get_content_type(env: Env) -> ContentType {
-        ContentType::Paid
+    /// Get the numeric discriminant of a content type
+    pub fn content_code(_env: Env, ct: ContentType) -> u32 {
+        ct as u32
+    }
+    
+    /// Handle errors by their numeric codes
+    pub fn error_code(_env: Env, err: MyfansError) -> u32 {
+        err as u32
+    }
+}
+```
+
+### Error Handling Example
+
+```rust
+use myfans_lib::error_codes::subscription as sub_err;
+
+fn handle_error(code: u32) {
+    match code {
+        sub_err::SUBSCRIPTION_NOT_FOUND => println!("Subscription not found"),
+        sub_err::SUBSCRIPTION_EXPIRED => println!("Subscription expired"),
+        sub_err::ALREADY_INITIALIZED => println!("Already initialized"),
+        _ => println!("Unknown error"),
     }
 }
 ```
@@ -65,16 +178,19 @@ Run tests:
 cargo test
 ```
 
-All enums are:
-- Soroban-compatible (using `#[contracttype]`)
-- Serializable/deserializable
-- Copy, Clone, Debug, Eq, PartialEq
-- Represented as u32 for efficient storage
+All types are thoroughly tested for:
+- Soroban SDK compatibility
+- Serialization/deserialization
+- Cross-contract type safety
+- Error code stability
 
 ## Features
 
+- ✅ Shared type definitions across all MyFans contracts
+- ✅ Stable error codes for client integration
 - ✅ Soroban SDK integration
-- ✅ Serialization/deserialization support
+- ✅ Full serialization/deserialization support
 - ✅ Type-safe enum values
-- ✅ Comprehensive tests
-- ✅ Ready for cross-contract usage
+- ✅ Comprehensive test coverage
+- ✅ Cross-contract compatibility
+- ✅ Zero-runtime overhead (compile-time only)