Merge pull request #1501 from priscaenoch/feature/1377-subscription-validate-create-plan

fix(subscription): validate create_plan amount and interval_days

Author: aji70

contract/contracts/subscription/README.md

@@ -45,6 +45,7 @@ pub struct Subscription {
 | 7 | `InvalidFeeBps` | Fee basis points exceed 10 000 (100%) |
 | 8 | `InvalidTokenAddress` | Token address is the Stellar null/burn address |
 | 9 | `InvalidPrice` | Subscription price must be strictly positive |
+| 11 | `InvalidPlanParams` | Plan `amount` must be strictly positive and `interval_days` non-zero |
 
 ---
 
@@ -85,7 +86,8 @@ pub fn create_plan(
 ```
 
 Registers a new billing plan for `creator`. Returns the assigned `plan_id` (auto-incremented from 1).
-Requires `creator` authorization. Panics with `Paused` if the contract is paused.
+Requires `creator` authorization. Panics with `Paused` if the contract is paused, or
+`InvalidPlanParams` if `amount <= 0` or `interval_days == 0`.
 
 **Event** `plan_created` — topics: `(name, creator)`, data: `plan_id`
 

contract/contracts/subscription/src/lib.rs

@@ -69,6 +69,7 @@ impl DataKey {
 /// | 8 | `InvalidTokenAddress` |
 /// | 9 | `InvalidPrice` |
 /// | 10 | `PlanNotFound` |
+/// | 11 | `InvalidPlanParams` |
 #[contracterror]
 #[derive(Clone, Copy, Debug, Eq, PartialEq)]
 pub enum Error {
@@ -92,6 +93,8 @@ pub enum Error {
     InvalidPrice = 9,
     /// Code 10 – plan ID does not exist; never created or out of range.
     PlanNotFound = 10,
+    /// Code 11 – plan `amount` must be strictly positive and `interval_days` non-zero.
+    InvalidPlanParams = 11,
 }
 
 /// Stellar "null" account (GAAA...WHF) — not a valid fee recipient.
@@ -184,6 +187,9 @@ impl MyfansContract {
         if paused {
             panic_with_error!(&env, Error::Paused);
         }
+        if amount <= 0 || interval_days == 0 {
+            panic_with_error!(&env, Error::InvalidPlanParams);
+        }
 
         let count: u32 = env
             .storage()

contract/contracts/subscription/src/test.rs

@@ -1818,3 +1818,68 @@ fn test_cancel_paused_returns_typed_error() {
         Err(Ok(SorobanError::from_contract_error(Error::Paused as u32)))
     );
 }
+
+// ── create_plan parameter validation ─────────────────────────────────────────
+
+/// create_plan rejects a zero amount with a typed InvalidPlanParams error.
+#[test]
+fn test_create_plan_rejects_zero_amount() {
+    let (env, client, admin, token, _token_admin) = setup_test();
+    let fee_recipient = Address::generate(&env);
+    client.init(&admin, &500, &fee_recipient, &token.address, &1000);
+    let creator = Address::generate(&env);
+
+    let result = client.try_create_plan(&creator, &token.address, &0, &30);
+    assert_eq!(
+        result,
+        Err(Ok(SorobanError::from_contract_error(
+            Error::InvalidPlanParams as u32,
+        )))
+    );
+}
+
+/// create_plan rejects a negative amount with a typed InvalidPlanParams error.
+#[test]
+fn test_create_plan_rejects_negative_amount() {
+    let (env, client, admin, token, _token_admin) = setup_test();
+    let fee_recipient = Address::generate(&env);
+    client.init(&admin, &500, &fee_recipient, &token.address, &1000);
+    let creator = Address::generate(&env);
+
+    let result = client.try_create_plan(&creator, &token.address, &-1, &30);
+    assert_eq!(
+        result,
+        Err(Ok(SorobanError::from_contract_error(
+            Error::InvalidPlanParams as u32,
+        )))
+    );
+}
+
+/// create_plan rejects a zero interval_days with a typed InvalidPlanParams error.
+#[test]
+fn test_create_plan_rejects_zero_interval_days() {
+    let (env, client, admin, token, _token_admin) = setup_test();
+    let fee_recipient = Address::generate(&env);
+    client.init(&admin, &500, &fee_recipient, &token.address, &1000);
+    let creator = Address::generate(&env);
+
+    let result = client.try_create_plan(&creator, &token.address, &1000, &0);
+    assert_eq!(
+        result,
+        Err(Ok(SorobanError::from_contract_error(
+            Error::InvalidPlanParams as u32,
+        )))
+    );
+}
+
+/// A valid plan (positive amount, non-zero interval_days) still succeeds.
+#[test]
+fn test_create_plan_accepts_valid_params() {
+    let (env, client, admin, token, _token_admin) = setup_test();
+    let fee_recipient = Address::generate(&env);
+    client.init(&admin, &500, &fee_recipient, &token.address, &1000);
+    let creator = Address::generate(&env);
+
+    let plan_id = client.create_plan(&creator, &token.address, &1000, &30);
+    assert_eq!(plan_id, 1);
+}