Commit 836b50a
committed
clients/go-ethereum, clients/nethermind: pin gas-limit target via HIVE_TARGET_GAS_LIMIT
Without an explicit target, geth and Nethermind use different default
gas-limit policies under the engine API: geth's CalcGasLimit moves the
parent gas limit toward miner.gaslimit (default 60M) by 1/1024 per
block, while Nethermind keeps the parent gas limit unchanged unless
Blocks.TargetBlockGasLimit is set. With the rpc-compat chain head sitting
at ~75M, the two clients diverge from block 1 onward, so blocks produced
by testing_buildBlockV1 / testing_commitBlockV1 in rpc-compat replay get
different hashes between clients and the strict-match tests fail on
Nethermind.
Wiring a new HIVE_TARGET_GAS_LIMIT env var through geth.sh
(--miner.gaslimit) and Nethermind's mkconfig.jq (Blocks.TargetBlockGasLimit)
makes both clients target the same ceiling. With the value set to
60000000 in execution-apis/tools/chain/forkenv.json, CalcGasLimit
produces the same gas limit at every step on both clients, so the
recorded rpc-compat fixtures replay byte-exact on both.
Spec and cross-client fixtures: ethereum/execution-apis#8011 parent 31cb70b commit 836b50a
2 files changed
Lines changed: 18 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
139 | 142 | | |
140 | 143 | | |
141 | 144 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
82 | 94 | | |
83 | 95 | | |
84 | 96 | | |
| |||
116 | 128 | | |
117 | 129 | | |
118 | 130 | | |
119 | | - | |
| 131 | + | |
0 commit comments