Fix two Copilot code quality findings from PR #356

- resolve_ingress_paths(): replace falsy-check `or list()` with explicit
  `is None` guard so a caller-supplied empty list is never silently discarded
- get_path_progress_bar(): track parameters used to build the cached PATH_BAR
  and recompute when called with different includes/excludes/follow_symlinks,
  preventing incorrect totals and test bleed
- Add unit tests for both fixes (issue #361)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: jordanpadams

src/pds/ingress/util/path_util.py

@@ -76,8 +76,8 @@ def resolve_ingress_paths(user_paths, includes, excludes, pbar, resolved_paths=N
         # Use a logger with no console output to avoid interfering with tqdm output
         logger = get_logger("resove_ingress_paths", console=False)
 
-        # Initialize the list of resolved paths if necessary
-        resolved_paths = resolved_paths or list()
+        if resolved_paths is None:
+            resolved_paths = list()
 
         for ingress_path in PathUtil._iter_resolvable_ingress_paths(
             user_paths, includes, excludes, follow_symlinks, logger

src/pds/ingress/util/progress_util.py

@@ -14,6 +14,7 @@
 from tqdm.asyncio import tqdm_asyncio
 
 PATH_BAR = None
+_PATH_BAR_PARAMS = None  # (user_paths_tuple, includes_tuple, excludes_tuple, follow_symlinks) used to build PATH_BAR
 MANIFEST_BAR = None
 TOTAL_INGRESS_BAR = None
 BATCH_BARS = []
@@ -47,11 +48,15 @@ def get_path_progress_bar(user_paths, includes=None, excludes=None, follow_symli
         The initialized global instance of the Path Resolution progress bar.
 
     """
-    global PATH_BAR
+    global PATH_BAR, _PATH_BAR_PARAMS
 
-    if PATH_BAR is None:
-        includes = includes or []
-        excludes = excludes or []
+    includes = includes or []
+    excludes = excludes or []
+    call_params = (tuple(user_paths), tuple(includes), tuple(excludes), follow_symlinks)
+
+    if PATH_BAR is None or _PATH_BAR_PARAMS != call_params:
+        if PATH_BAR is not None:
+            PATH_BAR.close()
         total_files = PathUtil.count_resolvable_ingress_paths(user_paths, includes, excludes, follow_symlinks)
 
         PATH_BAR = tqdm(
@@ -62,6 +67,7 @@ def get_path_progress_bar(user_paths, includes=None, excludes=None, follow_symli
             colour=LIGHT_GREEN,
             bar_format="{l_bar}{bar:60}| {n_fmt}/{total_fmt} Files",
         )
+        _PATH_BAR_PARAMS = call_params
 
     return PATH_BAR
 

tests/pds/ingress/util/test_path_util.py

@@ -230,6 +230,35 @@ def test_nested_include_and_exclude_filters_share_count_and_resolution_semantics
         self.assertNotIn(abspath(join(included_dir, "skip.dat")), resolved_ingress_paths)
         self.assertNotIn(abspath(join(excluded_dir, "drop.xml")), resolved_ingress_paths)
 
+    def test_resolve_ingress_paths_preserves_explicitly_passed_empty_list(self):
+        """Test that resolve_ingress_paths() does not replace an explicitly passed [] with a new list"""
+        Path(self.working_dir.name, "file.txt").touch()
+
+        caller_list = []
+        with get_path_progress_bar([self.working_dir.name]) as pbar:
+            result = PathUtil.resolve_ingress_paths([self.working_dir.name], [], [], pbar, resolved_paths=caller_list)
+
+        self.assertIs(result, caller_list)
+        self.assertEqual(len(result), 1)
+
+    def test_get_path_progress_bar_recomputes_total_for_different_params(self):
+        """Test that get_path_progress_bar() recomputes total when called with different filter parameters"""
+        Path(self.working_dir.name, "keep.txt").touch()
+        Path(self.working_dir.name, "drop.xml").touch()
+
+        with get_path_progress_bar([self.working_dir.name], [], []) as first_bar:
+            first_total = first_bar.total
+
+        progress_util.PATH_BAR = None
+        progress_util._PATH_BAR_PARAMS = None
+
+        excludes = [join(abspath(self.working_dir.name), "*.xml")]
+        with get_path_progress_bar([self.working_dir.name], [], excludes) as second_bar:
+            second_total = second_bar.total
+
+        self.assertEqual(first_total, 2)
+        self.assertEqual(second_total, 1)
+
     def test_trim_ingress_path(self):
         """Test the trim_ingress_path() function"""
         ingress_paths = [