(dev/gfs.v17) Remove duplicate WDQMS ecf script

[CatherineThomas-NOAA]

What is wrong?

The dev/gfs.v17 branch has two copies of the WDQMS job:

• $gw_clone/ecf/scripts/gdas/analysis/atmos/jgdas_atmos_anal_wdqms.ecf
• $gw_clone/ecf/scripts/gdas/atmos/analysis/jgdas_atmos_analysis_wdqms.ecf

The first script is what is exercised in the dev/gfs.v17 ecflow parallel and matches the directory format of the other jobs. The second one seems to be erroneous.

What should have happened?

There should only be one WDQMS script in the repository.

What machines are impacted?

WCOSS2

What global-workflow hash are you using?

dev/gfs.v17

Steps to reproduce

Clone the repository and examine the ecf/scripts directories.

Additional information

Here are the diffs between the files:

diff jgdas_atmos_anal_wdqms.ecf ../../atmos/analysis/jgdas_atmos_analysis_wdqms.ecf 
2c2
< #PBS -N gdas_atmos_anal_wdqms_%CYC%
---
> #PBS -N %RUN%_atmos_analysis_wdqms_%CYC%
11,12c11
< model=gfs
< export cyc="%CYC%"
---
> export model=gfs
15a15,20
> set -x
> 
> export NET=%NET:gfs%
> export RUN=%RUN%
> export CDUMP=%RUN%
> 
26c31
< module load ve/gw/${gw_ve_ver}
---
> module load ve/gw/1.0
27a33,39
> 
> #############################################################
> # WCOSS environment settings
> #############################################################
> export cyc=%CYC%
> export cycle=t%CYC%z
> 
32,33d43
< export CDATE=${PDY}${cyc}
< 
42a53,61
> ######################################################################
> # Purpose: To execute the job that creates the WDQMS products
> ######################################################################
> 
> ######################################################################
> # Job specific troubleshooting instructions:
> #  see generic troubleshoot manual page
> #
> ######################################################################
43a63
> # include manual page below

The first script (<) matches the other v17 scripts more closely.

cc @ADCollard

Do you have a proposed solution?

Remove the second script from the repo.