Skip to content

Commit 4420763

Browse files
committed
Autoconf: Minor fixes
* The siglongjmp() function name was incorrectly assigned to SETJMP when missing. This patch corrects sets it to SIGLONGJMP. * Restore MAKEDEP_DIRS (formerly SRC_DIRS) so that it can be used to detect file changes, as detected by rwildcard. * Fix path of ac-clean targets * Remove legacy bin/ and mkmf/ dirs from ac/deps/ * Remove top-level .gitignore (`build/` is not a defined output)
1 parent 14b4d29 commit 4420763

5 files changed

Lines changed: 21 additions & 19 deletions

File tree

.gitignore

Lines changed: 0 additions & 2 deletions
This file was deleted.

ac/Makefile.in

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ FCFLAGS = @FCFLAGS@
1919
LDFLAGS = @LDFLAGS@
2020
LIBS = @LIBS@
2121
MAKEDEP_FLAGS = @MAKEDEP_FLAGS@
22+
MAKEDEP_DIRS = @MAKEDEP_DIRS@
2223

2324
-include Makefile.dep
2425

@@ -34,8 +35,8 @@ rwildcard=$(foreach d,$(wildcard $(1:=/*)),$(call rwildcard,$d,$2) $(filter $(su
3435
# Generate dependencies
3536
.PHONY: depend
3637
depend: Makefile.dep
37-
Makefile.dep: $(call rwildcard,$(SRC_DIRS),*.h *.c *.inc *.F90)
38-
$(PYTHON) $(MAKEDEP) $(DEFS) -o Makefile.dep $(MAKEDEP_FLAGS)
38+
Makefile.dep: $(call rwildcard,$(MAKEDEP_DIRS),*.h *.c *.inc *.F90)
39+
$(PYTHON) $(MAKEDEP) $(DEFS) -o Makefile.dep $(MAKEDEP_FLAGS) $(MAKEDEP_DIRS)
3940

4041

4142
# Delete any files associated with configuration (including the Makefile).
@@ -57,5 +58,5 @@ distclean: clean
5758
ac-clean: distclean
5859
rm -f @srcdir@/ac/aclocal.m4
5960
rm -rf @srcdir@/ac/autom4te.cache
60-
rm -f @srcdir@/ac/configure
61-
rm -f @srcdir@/ac/configure~
61+
rm -f @srcdir@/configure
62+
rm -f @srcdir@/configure~

ac/configure.ac

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -315,16 +315,18 @@ AS_IF([test "$with_cvmix" = yes], [
315315
-s ${srcdir}/src/parameterizations/CVmix"
316316
])
317317

318-
SRC_DIRS="\\
318+
MAKEDEP_FLAGS="${MAKEDEP_FLAGS}"
319+
320+
MAKEDEP_FLAGS="${MAKEDEP_FLAGS# }"
321+
AC_SUBST([MAKEDEP_FLAGS])
322+
323+
MAKEDEP_DIRS="\\
319324
${srcdir}/src \\
320325
${MODEL_FRAMEWORK} \\
321326
${srcdir}/config_src/external \\
322327
${DRIVER_DIR} \\
323328
${MOM_MEMORY_DIR}"
324-
MAKEDEP_FLAGS="${MAKEDEP_FLAGS} ${SRC_DIRS}"
325-
326-
MAKEDEP_FLAGS="${MAKEDEP_FLAGS# }"
327-
AC_SUBST([MAKEDEP_FLAGS])
329+
AC_SUBST([MAKEDEP_DIRS])
328330

329331
# Add makedep to config.status
330332
AC_CONFIG_COMMANDS(Makefile.dep, [make depend])
@@ -367,7 +369,7 @@ AC_DEFINE_UNQUOTED([SIGSETJMP_NAME], ["${SIGSETJMP}"])
367369

368370
# Validate the siglongjmp symbol
369371
AX_FC_CHECK_BIND_C([siglongjmp],
370-
[SIGLONGJMP="siglongjmp"], [SETJMP="siglongjmp_missing"]
372+
[SIGLONGJMP="siglongjmp"], [SIGLONGJMP="siglongjmp_missing"]
371373
)
372374
AC_DEFINE_UNQUOTED([SIGLONGJMP_NAME], ["${SIGLONGJMP}"])
373375

ac/deps/.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
/bin/
21
/fms/
32
/gsw/
43
/cvmix/
54
/include/
65
/lib/
7-
/mkmf/

configure

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -599,6 +599,7 @@ ac_ct_CC
599599
CPPFLAGS
600600
CFLAGS
601601
CC
602+
MAKEDEP_DIRS
602603
MAKEDEP_FLAGS
603604
MAKEDEP
604605
PYTHON
@@ -5297,15 +5298,17 @@ then :
52975298

52985299
fi
52995300

5300-
SRC_DIRS="\\
5301+
MAKEDEP_FLAGS="${MAKEDEP_FLAGS}"
5302+
5303+
MAKEDEP_FLAGS="${MAKEDEP_FLAGS# }"
5304+
5305+
5306+
MAKEDEP_DIRS="\\
53015307
${srcdir}/src \\
53025308
${MODEL_FRAMEWORK} \\
53035309
${srcdir}/config_src/external \\
53045310
${DRIVER_DIR} \\
53055311
${MOM_MEMORY_DIR}"
5306-
MAKEDEP_FLAGS="${MAKEDEP_FLAGS} ${SRC_DIRS}"
5307-
5308-
MAKEDEP_FLAGS="${MAKEDEP_FLAGS# }"
53095312

53105313

53115314
# Add makedep to config.status
@@ -5555,7 +5558,7 @@ printf '%s\n' "$ax_fc_cv_bind_c_siglongjmp" >&6; }
55555558
then :
55565559
SIGLONGJMP="siglongjmp"
55575560
else case e in #(
5558-
e) SETJMP="siglongjmp_missing"
5561+
e) SIGLONGJMP="siglongjmp_missing"
55595562
;;
55605563
esac
55615564
fi

0 commit comments

Comments
 (0)