Skip to content

Commit 168f1d0

Browse files
fix: missing papermill and nbconvert install breaks notebook steps
Signed-off-by: Andrew White <andrewwhitecdw@users.noreply.github.com> Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
1 parent 5563e05 commit 168f1d0

2 files changed

Lines changed: 23 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
run: |
3939
echo "Installing ipykernel ..."
4040
python -m pip install --upgrade pip
41-
pip install ipykernel
41+
pip install ipykernel papermill nbconvert
4242
echo "Installing Python kernel..."
4343
python -m ipykernel install --user --name python3 --display-name "Python 3"
4444

tests/test_ci_workflow.py

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
import pathlib
2+
import unittest
3+
4+
WORKFLOW = (
5+
pathlib.Path(__file__).resolve().parent.parent
6+
/ ".github"
7+
/ "workflows"
8+
/ "ci.yml"
9+
)
10+
11+
12+
class TestCIWorkflow(unittest.TestCase):
13+
def test_notebook_dependencies_installed(self):
14+
text = WORKFLOW.read_text()
15+
pip_lines = [
16+
line.strip() for line in text.splitlines()
17+
if line.strip().startswith("pip install ipykernel")
18+
]
19+
self.assertTrue(pip_lines, "No notebook dependency install command found in workflow")
20+
installs = " ".join(pip_lines)
21+
self.assertIn("papermill", installs)
22+
self.assertIn("nbconvert", installs)

0 commit comments

Comments
 (0)