Skip to content

Commit c32e672

Browse files
committed
build: remove deprecated Make aliases
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
1 parent ecdbda6 commit c32e672

4 files changed

Lines changed: 13 additions & 44 deletions

File tree

DEVELOPMENT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ mise run convert-notebooks # regenerate tutorial notebooks
7070
Dependency-install tasks use `uv sync --locked` and fail when `uv.lock` does not match the project metadata. After
7171
changing dependencies in `pyproject.toml`, run `uv lock` before running the install tasks.
7272

73-
The Makefile retains compatibility targets for existing scripts. New development commands belong in `.mise/tasks/`.
73+
The Makefile only exposes `help`, `install-mise`, and `setup`. Developer commands belong in `.mise/tasks/`.
7474

7575
## Validation Before Opening a PR
7676

Makefile

Lines changed: 2 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
22
# SPDX-License-Identifier: Apache-2.0
33

4-
# Compatibility entry points for contributors and scripts that still invoke
5-
# make. New commands belong in .mise/tasks/ and should run via `mise run`.
4+
# Mise discovery and bootstrap entry points.
5+
# Developer commands live in .mise/tasks/ and run via `mise run`.
66

77
SHELL := /bin/bash
88
export PATH := $(HOME)/.local/share/mise/shims:$(HOME)/.local/bin:$(PATH)
@@ -21,43 +21,3 @@ install-mise:
2121
setup: install-mise
2222
@MISE_YES=1 mise trust
2323
@MISE_YES=1 mise run setup
24-
25-
.PHONY: run
26-
run:
27-
@if [ -z "$(TASK)" ]; then \
28-
echo "Error: missing TASK. Usage: make run TASK=test [ARGS='...']" >&2; \
29-
exit 1; \
30-
fi
31-
@mise run "$(TASK)" $(ARGS)
32-
33-
define deprecated_target
34-
.PHONY: $(1)
35-
$(1):
36-
@printf '%s\n' 'deprecated; forwarding to `mise run $(2)`' >&2
37-
@mise run $(2)
38-
endef
39-
40-
$(eval $(call deprecated_target,bootstrap,bootstrap))
41-
$(eval $(call deprecated_target,install,install))
42-
$(eval $(call deprecated_target,install-dev,install-dev))
43-
$(eval $(call deprecated_target,install-dev-notebooks,install-dev-notebooks))
44-
$(eval $(call deprecated_target,install-pre-commit,install-pre-commit))
45-
$(eval $(call deprecated_target,format,format))
46-
$(eval $(call deprecated_target,format-check,format-check))
47-
$(eval $(call deprecated_target,typecheck,typecheck))
48-
$(eval $(call deprecated_target,copyright,copyright))
49-
$(eval $(call deprecated_target,copyright-check,copyright-check))
50-
$(eval $(call deprecated_target,check,check))
51-
$(eval $(call deprecated_target,lock-check,lock-check))
52-
$(eval $(call deprecated_target,test,test))
53-
$(eval $(call deprecated_target,test-e2e,test:e2e))
54-
$(eval $(call deprecated_target,coverage,coverage))
55-
$(eval $(call deprecated_target,build-wheel,build-wheel))
56-
$(eval $(call deprecated_target,publish-pypi,publish:pypi))
57-
$(eval $(call deprecated_target,install-dev-docs,install-dev-docs))
58-
$(eval $(call deprecated_target,docs-serve,docs:serve))
59-
$(eval $(call deprecated_target,docs-build,docs:build))
60-
$(eval $(call deprecated_target,convert-notebooks,convert-notebooks))
61-
$(eval $(call deprecated_target,clean-pycache,clean-pycache))
62-
$(eval $(call deprecated_target,clean,clean))
63-
$(eval $(call deprecated_target,clean-merged-branches,clean-merged-branches))

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,8 @@ anonymizer --help # CLI usage
156156
mise run install-pre-commit # Install pre-commit hooks
157157
```
158158

159-
Run `mise tasks` to list the available developer commands. Tasks live in `.mise/tasks/` and are used by CI. The Makefile retains deprecated compatibility aliases for existing scripts.
159+
Run `mise tasks` to list the available developer commands. Tasks live in `.mise/tasks/` and are used by CI. The
160+
Makefile only exposes `help`, `install-mise`, and `setup`; run developer commands with Mise.
160161

161162
### Local endpoint credentials
162163

tests/tools/test_mise_configuration.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,14 @@ def test_local_mise_installer_keeps_unsigned_fallback_opt_in() -> None:
3030
assert 'REQUIRE_SIGNED_INSTALL="${MISE_REQUIRE_SIGNED_INSTALL:-0}"' in installer
3131

3232

33+
def test_makefile_exposes_bootstrap_without_deprecated_task_aliases() -> None:
34+
makefile = (REPO_ROOT / "Makefile").read_text(encoding="utf-8")
35+
phony_targets = [line.removeprefix(".PHONY: ") for line in makefile.splitlines() if line.startswith(".PHONY: ")]
36+
37+
assert phony_targets == ["help", "install-mise", "setup"]
38+
assert "deprecated_target" not in makefile
39+
40+
3341
def test_mise_typecheck_preserves_blocking_repository_contract() -> None:
3442
quality_tasks = _read_toml(REPO_ROOT / ".mise/tasks/quality.toml")
3543
typecheck = quality_tasks["typecheck"]

0 commit comments

Comments
 (0)