Skip to content

Commit 9859c48

Browse files
committed
replace inplace with torch.add
Signed-off-by: mikail <mkhona@nvidia.com>
1 parent 172c725 commit 9859c48

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

emerging_optimizers/psgd/procrustes_step.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,5 +73,6 @@ def procrustes_step(
7373
_step_size = (-tr_RRQ - torch.sqrt(tr_RRQ * tr_RRQ - 1.5 * tr_RQ * tr_RRRQ)) / (0.75 * tr_RRRQ)
7474
step_size = torch.clamp(_step_size, max=max_step_size)
7575
# Q += step_size * (RQ + 0.5 * step_size * (RRQ + 0.25 * step_size * RRRQ))
76-
Q.add_(step_size * (RQ + 0.5 * step_size * (RRQ + 0.25 * step_size * RRRQ)))
76+
Q = torch.add(Q, torch.add(RQ, RRQ, alpha=0.5 * step_size), alpha=step_size)
77+
Q = torch.add(Q, torch.add(RRQ, RRRQ, alpha=0.25 * step_size), alpha=step_size)
7778
return Q

0 commit comments

Comments
 (0)