Skip to content

Commit ba78af5

Browse files
committed
Fix build on push
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
1 parent fe9db87 commit ba78af5

1 file changed

Lines changed: 24 additions & 14 deletions

File tree

.github/workflows/build-trtllm-vllm-image.yml

Lines changed: 24 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ on:
3434
trt_version:
3535
description: Version of TensorRT to use for the build
3636
required: true
37-
type: 10.14.1.48
37+
type: string
38+
default: 10.14.1.48
3839
cuda_version:
3940
description: Version of CUDA to use for the build
4041
required: true
@@ -63,6 +64,15 @@ on:
6364

6465
env:
6566
container-registry: ${{ vars.container-registry || 'nemoci.azurecr.io' }}
67+
base-image-tag: ${{ inputs.base_image_tag || '25.11-py3' }}
68+
trtllm-commit: ${{ inputs.trtllm_commit || '48b7b5d8b7ed1e6bff57aecc6ff7d1533288bed8' }}
69+
vllm-version: ${{ inputs.vllm_version || '0.11.2' }}
70+
trt-version: ${{ inputs.trt_version || '10.14.1.48' }}
71+
cuda-version: ${{ inputs.cuda_version || '13.0' }}
72+
cudnn-version: ${{ inputs.cudnn_version || '9.17.0.29-1' }}
73+
nccl-version: ${{ inputs.nccl_version || '2.28.9-1+cuda13.0' }}
74+
cublas-version: ${{ inputs.cublas_version || '13.1.0.3-1' }}
75+
nvrtc-version: ${{ inputs.nvrtc_version || '13.0.88-1' }}
6676

6777
permissions:
6878
id-token: write
@@ -117,7 +127,7 @@ jobs:
117127

118128
- name: Set truncated commit hash
119129
env:
120-
TRTLLM_COMMIT: ${{ inputs.trtllm_commit }}
130+
TRTLLM_COMMIT: ${{ env.trtllm-commit }}
121131
run: echo "TRTLLM_COMMIT_SHORT=${TRTLLM_COMMIT:0:7}" >> $GITHUB_ENV
122132

123133
- name: Build and push
@@ -127,19 +137,19 @@ jobs:
127137
push: true
128138
context: .
129139
build-args: |
130-
BASE_IMAGE=nvcr.io/nvidia/pytorch:${{ inputs.base_image_tag }}
131-
VLLM_VERSION=${{ inputs.vllm_version }}
132-
TRT_LLM_COMMIT=${{ inputs.trtllm_commit }}
133-
TRT_VER=${{ inputs.trt_version }}
134-
CUDA_VER=${{ inputs.cuda_version }}
135-
CUDNN_VER=${{ inputs.cudnn_version }}
136-
NCCL_VER=${{ inputs.nccl_version }}
137-
CUBLAS_VER=${{ inputs.cublas_version }}
138-
NVRTC_VER=${{ inputs.nvrtc_version }}
140+
BASE_IMAGE=nvcr.io/nvidia/pytorch:${{ env.base-image-tag }}
141+
VLLM_VERSION=${{ env.vllm-version }}
142+
TRT_LLM_COMMIT=${{ env.trtllm-commit }}
143+
TRT_VER=${{ env.trt-version }}
144+
CUDA_VER=${{ env.cuda-version }}
145+
CUDNN_VER=${{ env.cudnn-version }}
146+
NCCL_VER=${{ env.nccl-version }}
147+
CUBLAS_VER=${{ env.cublas-version }}
148+
NVRTC_VER=${{ env.nvrtc-version }}
139149
cache-from: |
140-
type=registry,ref=${{ env.container-registry }}/export-deploy-trtllm-vllm:${{ inputs.base_image_tag }}-${{ env.TRTLLM_COMMIT_SHORT }}-${{ inputs.vllm_version }}-buildcache,mode=max
150+
type=registry,ref=${{ env.container-registry }}/export-deploy-trtllm-vllm:${{ env.base-image-tag }}-${{ env.TRTLLM_COMMIT_SHORT }}-${{ env.vllm-version }}-buildcache,mode=max
141151
cache-to: |
142-
type=registry,ref=${{ env.container-registry }}/export-deploy-trtllm-vllm:${{ inputs.base_image_tag }}-${{ env.TRTLLM_COMMIT_SHORT }}-${{ inputs.vllm_version }}-buildcache,mode=max
152+
type=registry,ref=${{ env.container-registry }}/export-deploy-trtllm-vllm:${{ env.base-image-tag }}-${{ env.TRTLLM_COMMIT_SHORT }}-${{ env.vllm-version }}-buildcache,mode=max
143153
no-cache: false
144154
tags: |
145-
${{ env.container-registry }}/export-deploy-trtllm-vllm:${{ inputs.base_image_tag }}-${{ env.TRTLLM_COMMIT_SHORT }}-${{ inputs.vllm_version }}
155+
${{ env.container-registry }}/export-deploy-trtllm-vllm:${{ env.base-image-tag }}-${{ env.TRTLLM_COMMIT_SHORT }}-${{ env.vllm-version }}

0 commit comments

Comments
 (0)