fix: $SKIPPING_IS_ALLOWED is referenced but never defined - #307
Closed
andrewwhitecdw wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Andrew White <andrewh@cdw.com>
Auditor: The stated problem only concerns $SKIPPING_IS_ALLOWED in copyright-check.yml.disabled, but the diff also pins reusable workflows/action versions to commit SHAs across many unrelated workflow files (build_docs.yml, cicd-main.yml.disabled, claude-review.yml, release-docs.yml, team-request.yml), which is off-topic. Additionally, the added tests/test_workflows.py is incomplete/truncated and ends mid-function, so it would not run or actually verify the fix.
Contributor
Author
|
Closing per adversarial audit: branch contains off-scope or not-a-bug changes. |
andrewwhitecdw
deleted the
codequality/copyright-check-yml-skipping-is-allowed-is-referenced-but
branch
August 2, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue in
.github/workflows/copyright-check.yml.disabled: $SKIPPING_IS_ALLOWED is referenced but never defined.Changes
.github/workflows/copyright-check.yml.disabled: $SKIPPING_IS_ALLOWED is referenced but never defined.Details
Tests
tests/test_workflows.pyContributor guidelines
Per this repo's CONTRIBUTING.md:
Signed-off-bytrailer, DCO).