Skip to content

Commit 64c918e

Browse files
committed
Remove all references to jira
Signed-off-by: Ryan <rlangman@nvidia.com>
1 parent d24281c commit 64c918e

8 files changed

Lines changed: 26 additions & 29 deletions

File tree

scripts/tts_comparison_report/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ python scripts/tts_comparison_report/generate_report.py \
127127
--s3_region us-west-2 \
128128
--task_id NEMOTTS-2007 \
129129
--audio_report \
130-
--audio_report_benchmarks libritts_test_clean,riva_hard_digits \
130+
--audio_report_benchmarks libritts,riva_en \
131131
--samples_per_benchmark 20
132132
```
133133

@@ -145,7 +145,7 @@ python scripts/tts_comparison_report/generate_report.py \
145145
--s3_region us-west-2 \
146146
--task_id NEMOTTS-2007 \
147147
--audio_report \
148-
--audio_report_benchmarks libritts_test_clean,riva_hard_digits \
148+
--audio_report_benchmarks libritts,riva_en \
149149
--samples_per_benchmark 20 \
150150
--remote_hostname your_remote_host \
151151
--remote_username your_user
@@ -160,13 +160,13 @@ python scripts/tts_comparison_report/generate_report.py \
160160
--baseline_path /workspace/NeMo/exp/buckets/baseline \
161161
--candidate_name "Model B" \
162162
--candidate_path /workspace/NeMo/exp/buckets/candidate \
163-
--benchmarks libritts_test_clean,riva_hard_digits,riva_hard_letters \
163+
--benchmarks libritts,riva_en,riva_en_hard_sentences \
164164
--s3_endpoint https://your-s3-endpoint \
165165
--s3_bucket your_bucket_name \
166166
--s3_region us-west-2 \
167167
--task_id NEMOTTS-2007 \
168168
--audio_report \
169-
--audio_report_benchmarks libritts_test_clean,riva_hard_digits \
169+
--audio_report_benchmarks libritts,riva_en \
170170
--samples_per_benchmark 20
171171
```
172172

scripts/tts_comparison_report/generate_report.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
_S3_ACCESS_KEY_ID: str = "S3_ACCESS_KEY_ID"
4242
_S3_SECRET_ACCESS_KEY: str = "S3_SECRET_ACCESS_KEY"
4343

44-
_DEFAULT_BENCHMARK_NAMES: str = ",".join(SUPPORTED_BENCHMARK_NAMES)
44+
_DEFAULT_BENCHMARK_NAMES: str = "libritts,riva_en"
4545

4646

4747
def _create_argparser() -> ArgumentParser:
@@ -113,7 +113,7 @@ def _create_argparser() -> ArgumentParser:
113113
"--task_id",
114114
type=str,
115115
default=DUMMY_TASK_ID,
116-
help="Jira task number associated with this report.",
116+
help="Task ID associated with this report.",
117117
)
118118
parser.add_argument(
119119
"--results_subdir",
@@ -129,7 +129,7 @@ def _create_argparser() -> ArgumentParser:
129129
parser.add_argument(
130130
"--audio_report_benchmarks",
131131
type=str,
132-
default="libritts_test_clean,riva_hard_digits,riva_hard_letters",
132+
default=_DEFAULT_BENCHMARK_NAMES,
133133
help="Comma-separated list of benchmarks to include in the audio report.",
134134
)
135135
parser.add_argument(

scripts/tts_comparison_report/reporting/constants.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
_ROOT: Path = Path(__file__).parent.parent
1818

1919
# Benchmark names supported by the comparison report pipeline.
20-
BENCHMARK_META = {
20+
BENCHMARK_META: dict[str, str] = {
2121
'libritts': 'en',
2222
'riva_en': 'en',
2323
'riva_en_hard_sentences': 'en',
@@ -40,7 +40,7 @@
4040
'mscenespeech': 'zh',
4141
}
4242

43-
SUPPORTED_BENCHMARK_NAMES = BENCHMARK_META.keys()
43+
SUPPORTED_BENCHMARK_NAMES: list[str] = list(BENCHMARK_META.keys())
4444

4545
# Default width of tqdm progress bars in terminal columns.
4646
TQDM_NCOLS: int = 80
@@ -63,8 +63,8 @@
6363
# Directory containing Jinja templates used for report rendering.
6464
TEMPLATES_DIR: Path = _ROOT / "templates"
6565

66-
# Fallback task id used when no real Jira ticket is provided.
67-
DUMMY_TASK_ID: str = "NEMOTTS-0000"
66+
# Fallback task id used when no real ticket is provided.
67+
DUMMY_TASK_ID: str = "NMP-I-000"
6868

69-
# URL prefix used to construct clickable Jira ticket links in reports.
69+
# URL prefix used to construct clickable ticket links in reports.
7070
TICKET_URL_PREFIX: str = "https://modelpor.ideas.aha.io/ideas"

scripts/tts_comparison_report/reporting/helpers.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,21 +37,19 @@ def make_expiration_info(expires_in: int) -> ExpirationInfo:
3737

3838

3939
def make_task_info(task_id: str) -> TaskInfo:
40-
"""Create task metadata and the corresponding Jira link information.
40+
"""Create task metadata and the corresponding link information.
4141
4242
Args:
43-
task_id: Jira task identifier used for the report.
43+
task_id: Task identifier used for the report.
4444
4545
Returns:
46-
Task information with the original task ID, derived Jira ID, and Jira URL.
46+
Task information with the original task ID and task URL.
4747
"""
48-
jira_id = task_id if task_id != DUMMY_TASK_ID else task_id.split("-")[0]
49-
jira_url = f"{TICKET_URL_PREFIX}/{jira_id}"
48+
task_url = f"{TICKET_URL_PREFIX}/{task_id}"
5049

5150
return TaskInfo(
5251
task_id=task_id,
53-
jira_id=jira_id,
54-
jira_url=jira_url,
52+
task_url=task_url,
5553
)
5654

5755

scripts/tts_comparison_report/reporting/models.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -535,11 +535,10 @@ def get_benchmark_sample_meta(
535535

536536
@dataclass(frozen=True)
537537
class TaskInfo:
538-
"""Task identifiers and derived Jira link information used in reports."""
538+
"""Task identifiers and derived link information used in reports."""
539539

540540
task_id: str
541-
jira_id: str
542-
jira_url: str
541+
task_url: str
543542

544543

545544
@dataclass(frozen=True)

scripts/tts_comparison_report/reporting/orchestrator.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,8 @@ def _render_audio_report(
275275

276276
report = self.renderer.render(
277277
name=TemplateName.audio_report,
278-
jira_id=task_info.jira_id,
279-
jira_url=task_info.jira_url,
278+
task_id=task_info.task_id,
279+
task_url=task_info.task_url,
280280
header_block=header_block,
281281
benchmark_blocks=benchmark_blocks,
282282
benchmark_section_info=benchmark_section_info,
@@ -380,8 +380,8 @@ def _render_eval_report(
380380
report = self.renderer.render(
381381
name=TemplateName.eval_report,
382382
is_self_comparison=eval_artifacts.is_self_comparison,
383-
jira_id=task_info.jira_id,
384-
jira_url=task_info.jira_url,
383+
task_id=task_info.task_id,
384+
task_url=task_info.task_url,
385385
audio_report_url=audio_report_url,
386386
configuration_block=configuration_block,
387387
header_block=header_block,
@@ -419,7 +419,7 @@ def run(
419419
generate_audio_report: Whether to generate the audio comparison report.
420420
audio_report_benchmarks: Benchmark names to include in the audio report.
421421
samples_per_benchmark: Number of audio pairs to sample per benchmark.
422-
task_id: Task identifier used for report metadata and Jira linking.
422+
task_id: Task identifier used for report metadata and link.
423423
424424
Returns:
425425
Tuple containing the evaluation report URL and the optional audio report URL.

scripts/tts_comparison_report/templates/audio_report.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@
281281
<h2>Links ↗</h2>
282282
<ul>
283283
<li class="link-comment">
284-
<a href="{{ jira_url }}" target="_blank" rel="noopener noreferrer">POR {{ jira_id }}</a>
284+
<a href="{{ task_url }}" target="_blank" rel="noopener noreferrer">POR {{ task_id }}</a>
285285
</li>
286286
</ul>
287287
</aside>

scripts/tts_comparison_report/templates/eval_report.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@
384384
<h2>Links ↗</h2>
385385
<ul>
386386
<li class="link-comment">
387-
<a href="{{ jira_url }}" target="_blank" rel="noopener noreferrer">POR {{ jira_id }}</a>
387+
<a href="{{ task_url }}" target="_blank" rel="noopener noreferrer">POR {{ task_id }}</a>
388388
</li>
389389
{% if audio_report_url %}
390390
<li class="link-comment">

0 commit comments

Comments
 (0)