Temporarily pin SALM Automodel dispatcher to torch#15963
Merged
Conversation
DongjiGao
requested review from
KunalDhawan,
karpnv,
pzelasko and
tango4j
and removed request for
karpnv
July 24, 2026 20:23
Collaborator
|
/ok to test fe8310c |
Signed-off-by: Dongji Gao <dongjig@nvidia.com>
DongjiGao
force-pushed
the
agent/pin-salm-torch-dispatcher
branch
from
July 24, 2026 21:47
fe8310c to
9ac7aa6
Compare
DongjiGao
marked this pull request as ready for review
July 24, 2026 22:12
KunalDhawan
approved these changes
Jul 24, 2026
Contributor
Author
|
/ok to test 9ac7aa6 |
DongjiGao
enabled auto-merge (squash)
July 24, 2026 22:58
DongjiGao
disabled auto-merge
July 24, 2026 23:01
Contributor
|
[🤖]: Hi @DongjiGao 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
examples/speechlm2/conf/salm_automodel.yamltoautomodel_backend.dispatcher: torch.TODO (Dongji)to remove the override once Automodel performs topology-aware dispatcher selection.Why
This is a temporary fix to unblock the release.
Automodel's
BackendConfigcurrently selects DeepEP when the package is installed and CUDA is available. It does not validate whether the GPU topology supports DeepEP. On PCIe-only systems, SALM MoE expert-parallel training can therefore enter DeepEP kernels and fail with an unexplained CUDAunspecified launch failure/EPException.The long-term fix belongs in Automodel: select DeepEP only when the required NVLINK/NVSHMEM topology is available, otherwise fall back to Torch with a warning.
Impact
The example now uses the portable Torch dispatcher by default. Systems with compatible NVLINK/NVSHMEM topology can opt into DeepEP with:
Validation
Using
nvcr.io/nvidian/nemo-speech:26.06.rc4on a two-GPU PCIe-only host:BackendConfigresolved todispatcher=deepep.intranode.cu:126 'unspecified launch failure'anddeep_ep.cpp:147 'unspecified launch failure', followed byEPException/SIGABRT.GroupedExpertsforward/backward path passed on both ranks.dispatcher=torch.pytest -q --confcutdir=tests/collections/speechlm2 tests/collections/speechlm2/test_example_configs.py.git diff --check, Black, isort, and Python compilation passed.The original 8x H200 QA case should still be rerun in the release environment.