Skip to content

Update TTS pronunciation dictionaries#15857

Merged
blisc merged 4 commits into
NVIDIA-NeMo:mainfrom
quapham:tts/update-hi-ipa-pron-dicts
Jul 21, 2026
Merged

Update TTS pronunciation dictionaries#15857
blisc merged 4 commits into
NVIDIA-NeMo:mainfrom
quapham:tts/update-hi-ipa-pron-dicts

Conversation

@quapham

@quapham quapham commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Add scripts/tts_dataset_files/hi_IN/hi_prondict-v0.3_nostress_fixed.dict.
  • Update scripts/tts_dataset_files/ipa_cmudict-0.7b_nv26.07.txt A/A(1) pronunciation ordering.

Scope

Dictionary-only change. No code changes.

Validation

  • Verified copied dictionary file hashes match the source files.
  • Verified git diff contains only the two dictionary files.

@copy-pr-bot

copy-pr-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the TTS label Jun 30, 2026
@quapham
quapham force-pushed the tts/update-hi-ipa-pron-dicts branch 2 times, most recently from 8f37766 to 5e117a7 Compare June 30, 2026 07:08
@blisc

blisc commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Can you bump the version of scripts/tts_dataset_files/ipa_cmudict-0.7b_nv23.01.txt to nv26.07? Can update references from 23.01 to 26.07?

@quapham

quapham commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Updated the IPA CMU dictionary filename/references from nv23.01 to nv26.07 and pushed commit ca999d9

@quapham

quapham commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test ca999d9

@quapham

quapham commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test ca999d9

blisc
blisc previously approved these changes Jul 10, 2026
@blisc
blisc enabled auto-merge (squash) July 10, 2026 15:19
@NVIDIA-NeMo NVIDIA-NeMo deleted a comment from copy-pr-bot Bot Jul 14, 2026
@NVIDIA-NeMo NVIDIA-NeMo deleted a comment from copy-pr-bot Bot Jul 14, 2026
@quapham

quapham commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 4dfe3a5

Comment on lines +134772 to +134773
A ˈʌ
A(1) ˈeɪ

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to this dictionary?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We trained the model with the updated dictionary, where the pronunciation was changed from /'eɪ/ to /'ʌ/.

@XuesongYang

Copy link
Copy Markdown
Collaborator

/ok to test 4dfe3a5

quapham added 2 commits July 16, 2026 10:54
Add the fixed Hindi pronunciation dictionary, remove the old Hindi dictionary, and update the IPA CMU dictionary entry ordering for A/A(1).

Signed-off-by: quanpham <youngkwan199@gmail.com>
Signed-off-by: quanpham <youngkwan199@gmail.com>
@XuesongYang
XuesongYang force-pushed the tts/update-hi-ipa-pron-dicts branch from 4dfe3a5 to 8ebea33 Compare July 16, 2026 17:54
@XuesongYang

Copy link
Copy Markdown
Collaborator

@quapham pls make bugfix for the failed unit test, where

E           FileNotFoundError: [Errno 2] No such file or directory: 'scripts/tts_dataset_files/ipa_cmudict-0.7b_nv23.01.txt'

@XuesongYang

Copy link
Copy Markdown
Collaborator

@blisc nit, our doc has two broken links to be fixed. Do you have any thoughts?

The failure is from Sphinx linkcheck (docs build with --fail-on-warning) and is caused by 2 broken URLs not in exclusions:

asr/speech_classification/datasets.rst:126
Broken: https://cs.taltech.ee/staff/tanel.alumae/data/voxlingua107/ (404)

tts/checkpoints.rst:1
Broken: https://ngc.nvidia.com/catalog/models/nvidia:nemo:tts_en_mixertts (404)

Signed-off-by: quanpham <youngkwan199@gmail.com>
@quapham

quapham commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

/ok test 5a31913

@quapham

quapham commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

I already updated the external TestData YAML through the Internal-Developer S3 copy config. However, this unit test can still load the old nv23.01 hparams

I added a compatibility migration for text_tokenizers..g2p.phoneme_dict to rewrite ipa_cmudict-0.7b_nv23.01.txt to ipa_cmudict-0.7b_nv26.07.txt.

@blisc

blisc commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 5a31913

@XuesongYang

Copy link
Copy Markdown
Collaborator

I already updated the external TestData YAML through the Internal-Developer S3 copy config. However, this unit test can still load the old nv23.01 hparams

@chtruong814 do you have suggestions on this?

@blisc

blisc commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

I'm guessing these tests aren't using the newest phone dict. But let's just update the target. I think it's fine that these numbers change.

@blisc

blisc commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

/ok to test a97b186

@blisc

blisc commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

nvidia:nemo:tts_en_mixertts

Oh, that's what that was. Can you review #15926?

@github-actions

Copy link
Copy Markdown
Contributor

[🤖]: Hi @quapham 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

@blisc
blisc merged commit 50e153f into NVIDIA-NeMo:main Jul 21, 2026
155 of 157 checks passed
@XuesongYang

Copy link
Copy Markdown
Collaborator

nvidia:nemo:tts_en_mixertts

Oh, that's what that was. Can you review #15926?

approved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants