Commit 05683a8
committed
feat(cli): let external packages add nooa subcommands via entry points
`nooa_cli.commands` discovered commands by scanning only its own directory,
so nothing outside this repo could add a `nooa` subcommand. Packages that
wanted to extend the CLI had to ship standalone console scripts instead,
changing the command name for every user.
Split `discover_commands()` into the existing built-in scan plus a new pass
over the `nooa_cli.commands` entry-point group, mirroring the existing
`nooa.skills` and `nooa.bundled_configs` groups:
[project.entry-points."nooa_cli.commands"]
tui = "my_package.cli.tui:command"
Built-ins are yielded first and win name collisions, so a third party cannot
shadow `eval` or `config`; each name is yielded exactly once. Every plugin
failure — broken distribution metadata, an entry point that fails to import,
or one resolving to a non-`click.Command` — is logged at WARNING and skipped,
since these are arbitrary third-party imports and must never make `nooa`
unusable. The built-in scan deliberately keeps raising `TypeError`: that is a
bug in this repo and should be loud. Plugins are sorted by entry-point name so
`nooa --help` does not depend on install order.
Two test-collection fixes were needed to make the new tests actually run:
`testpaths` pointed at `packages/nooa-cli/tests/{cli,integration}`, neither of
which exists, so nothing under `packages/nooa-cli/tests` was ever collected in
CI. Replacing both with the parent directory exposed a latent collision — the
empty `packages/nooa-cli/tests/__init__.py` made it a package named `tests`,
shadowing the root `tests` package that other modules import from. It is
unnecessary under the repo's `--import-mode=importlib`, and
`packages/nooa-bench/tests` already ships without one.
Signed-off-by: Severin Klingler <sklingler@nvidia.com>1 parent 51fb19f commit 05683a8
6 files changed
Lines changed: 382 additions & 7 deletions
File tree
- packages/nooa-cli
- src/nooa_cli
- commands
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
104 | 133 | | |
105 | 134 | | |
106 | 135 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
| |||
36 | 39 | | |
37 | 40 | | |
38 | 41 | | |
39 | | - | |
| 42 | + | |
| 43 | + | |
40 | 44 | | |
41 | 45 | | |
42 | 46 | | |
| |||
57 | 61 | | |
58 | 62 | | |
59 | 63 | | |
60 | | - | |
| 64 | + | |
61 | 65 | | |
62 | 66 | | |
63 | 67 | | |
64 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
65 | 72 | | |
66 | 73 | | |
67 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
| |||
62 | 65 | | |
63 | 66 | | |
64 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
65 | 94 | | |
66 | 95 | | |
67 | 96 | | |
| 97 | + | |
68 | 98 | | |
69 | 99 | | |
| 100 | + | |
70 | 101 | | |
71 | 102 | | |
72 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
73 | 108 | | |
74 | | - | |
75 | | - | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
76 | 112 | | |
77 | 113 | | |
78 | 114 | | |
79 | 115 | | |
80 | 116 | | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
81 | 120 | | |
82 | 121 | | |
83 | 122 | | |
| |||
104 | 143 | | |
105 | 144 | | |
106 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
Whitespace-only changes.
0 commit comments