Skip to content

Commit 8aeae50

Browse files
Merge pull request #8 from NVIDIA-NeMo/fix/release-verification
fix: README snippet + platform-specific test skips
2 parents 112de8d + 9d985a7 commit 8aeae50

3 files changed

Lines changed: 15 additions & 1 deletion

File tree

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ llm = get_llm_client("hosted_vllm/Qwen/Qwen3-1.7B", api_base="http://localhost:8
100100
***Agents are Python objects***. Methods with `...` bodies are **generation methods** — implemented at runtime by an LLM-driven strategy. The signature defines the contract; the docstring is the prompt.
101101

102102
```python
103+
import asyncio
104+
103105
from nooa import Agent
104106

105107

@@ -111,11 +113,13 @@ class FeedbackAgent(Agent, llm=llm):
111113
...
112114

113115

114-
@autorun
115116
async def main():
116117
agent = FeedbackAgent()
117118
result = await agent.analyze_feedback("Great product, but shipping was slow")
118119
print(result)
120+
121+
122+
asyncio.run(main())
119123
```
120124

121125
Run the same code from your own project with `python`. You can run the checked-in example:

tests/runtime/test_producers.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import asyncio
66
import os
7+
import platform
78

89
import pytest
910

@@ -73,6 +74,10 @@ async def collect(gen, dest):
7374
assert lines_a == ["A1", "A2"]
7475
assert lines_b == ["B1", "B2"]
7576

77+
@pytest.mark.skipif(
78+
platform.system() != "Linux",
79+
reason="process-group kill semantics differ on non-Linux; verified in Linux CI",
80+
)
7681
async def test_monitor_cancel_kills_process_group(self):
7782
"""Cancelling monitor must kill the entire process group, not just the shell."""
7883
gen = monitor("bash -c 'echo $BASHPID; sleep 999 & echo ready; wait'")

tests/test_sqlite_corruption_resilience.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
# SPDX-License-Identifier: Apache-2.0
33
"""Tests for SQLite corruption resilience (P0) and virtiofs detection (P1)."""
44

5+
import platform
56
import sqlite3
67
import subprocess
78
from unittest.mock import patch
@@ -201,6 +202,10 @@ def setup_method(self):
201202
def test_memory_db_is_not_virtiofs(self):
202203
assert _is_virtiofs(":memory:") is False
203204

205+
@pytest.mark.skipif(
206+
platform.system() != "Linux",
207+
reason="virtiofs detection is a Linux-only code path",
208+
)
204209
@patch("subprocess.run")
205210
def test_detects_virtiofs_in_df_output(self, mock_run):
206211
mock_run.return_value = type(

0 commit comments

Comments
 (0)