Commit 12bfaff
feat(lint): Upgrade ty (#543)
* squash
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
* fix(lint): suppress new ty 0.0.56 error categories in CI
The ty upgrade from 0.0.17 to 0.0.56 catches additional pre-existing
type violations. Add these new error categories to the CI ignore list
with counts, matching the existing pattern for incremental cleanup.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
* fix(lint): add --exit-zero-on-warning for ty 0.0.56
ty 0.0.56 exits non-zero on warnings (unsupported-base,
unused-type-ignore-comment, redundant-cast). Add
--exit-zero-on-warning so only errors fail CI.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
* fix(lint): resolve all new ty 0.0.56 errors at source
Instead of adding blanket suppressions for new error categories,
fix each violation individually:
- Fix with_logging decorator in anonymizer/data-designer to preserve
class types through TypeVar (invalid-type-form)
- Fix StudioService.dependencies to use ClassVar (invalid-attribute-override)
- Add inline ty: ignore comments for false positives and intentional
test misuse (invalid-paramspec, call-non-callable, unknown-argument,
missing-argument, empty-body, too-many-positional-arguments,
invalid-yield, unresolved-import, invalid-type-form)
No new blanket suppressions added to lint-python-types.sh.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
* fix(lint): consolidate duplicate type ignore comments
Replace `# type: ignore[rule] # ty: ignore[rule]` with blanket
`# type: ignore` on lines that need both mypy and ty suppression.
Blanket `# type: ignore` is respected by both checkers, eliminating
the need for separate directives.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
* Revert "fix(lint): consolidate duplicate type ignore comments"
This reverts commit cd7b6f6.
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
* fix(lint): use ty: ignore instead of type: ignore
This repo uses ty, not mypy. Replace redundant dual comments
(# type: ignore[rule] # ty: ignore[rule]) with just # ty: ignore[rule]
on the 14 lines we touched for the ty upgrade.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
* chore: sync vendored SDK and CLI after ty ignore cleanup
Run make vendor and make update-cli to sync the evaluator SDK
vendored files with the ty: ignore comment changes.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
---------
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 9aa4f5c commit 12bfaff
28 files changed
Lines changed: 532 additions & 57 deletions
File tree
- packages
- nemo_evaluator_sdk
- src/nemo_evaluator_sdk/resilience
- tests
- metrics
- nemo_platform_plugin
- src/nemo_platform_plugin
- tests
- nmp_testing/src/nmp/testing
- plugins
- nemo-agents/src/nemo_agents_plugin/container
- nemo-anonymizer/src/nemo_anonymizer_plugin/sdk
- nemo-data-designer/src/nemo_data_designer_plugin
- cli
- sdk
- nemo-deployments/tests
- integration
- backends/docker
- unit/backends/docker
- sdk/python/nemo-platform/src/nemo_platform/beta/evaluator/resilience
- services/studio/src/nmp/studio
- tools
- lint
- mcp-dev-tools
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
| |||
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
205 | | - | |
| 205 | + | |
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
522 | 522 | | |
523 | 523 | | |
524 | 524 | | |
525 | | - | |
| 525 | + | |
526 | 526 | | |
527 | 527 | | |
528 | 528 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
326 | 326 | | |
327 | 327 | | |
328 | 328 | | |
329 | | - | |
| 329 | + | |
330 | 330 | | |
331 | 331 | | |
332 | 332 | | |
| |||
451 | 451 | | |
452 | 452 | | |
453 | 453 | | |
454 | | - | |
| 454 | + | |
455 | 455 | | |
456 | 456 | | |
457 | 457 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
173 | | - | |
| 173 | + | |
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
394 | 394 | | |
395 | 395 | | |
396 | 396 | | |
397 | | - | |
| 397 | + | |
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
0 commit comments