fix(studio): address assistant PR checks

Signed-off-by: Danielle Ali <44468613+dmariali@users.noreply.github.com>

Author: dmariali

agents/nemo-studio-assistant/wheelhouse/nemo_platform-0.3.0.post217.dev0+b6f22880a-py3-none-any.whl

@@ -401,7 +401,7 @@ and
 | openshiftRoute.service | string | `"{{ include \"nemo-platform.ingressBackendService\" . }}"` | Service name to route to. Defaults to Envoy when auth+envoy enabled, otherwise API (tpl-evaluated). |
 | openshiftRoute.targetPort | string | `"{{ include \"nemo-platform.ingressBackendPort\" . }}"` | Target port on the service. Defaults to Envoy or API port depending on auth (tpl-evaluated). |
 | openshiftRoute.tls | object | `{}` | Optional TLS configuration (termination, certificate, key, etc.). See OpenShift Route spec. |
-| platformConfig | object | `{}` | Platform-wide configuration settings Set configuration here to apply custom, structured configuration across all services. Applied after the base platform config is evaluated for templates. Enables adding / overriding YAML-based elements in the evaluated platform config. It is usually recommended to use this config section instead of `basePlatformConfig` unless you need to use templating features. For example, you can set the NIM default StorageClass via models.controller.backends.deployments_plugin.default_storage_class. For full configuration reference, see https://docs.nvidia.com/nemo-platform |
+| platformConfig | object | `{"studio":{"feature_flags":{"assistant_studio_enabled":true}}}` | Platform-wide configuration settings Set configuration here to apply custom, structured configuration across all services. Applied after the base platform config is evaluated for templates. Enables adding / overriding YAML-based elements in the evaluated platform config. It is usually recommended to use this config section instead of `basePlatformConfig` unless you need to use templating features. For example, you can set the NIM default StorageClass via models.controller.backends.deployments_plugin.default_storage_class. For full configuration reference, see https://docs.nvidia.com/nemo-platform |
 | platformSeedJob | object | This object has the following default values for the platform seed Job configuration. | Platform seed Job (Helm hook: runs after install/upgrade) Runs the platform-seed task (guardrails configs, evaluator system entities, data designer filesets). Uses post-install,post-upgrade hooks so it runs on fresh installs and can be re-triggered on no-op upgrade. |
 | platformSeedJob.activeDeadlineSeconds | int | `600` | Maximum time in seconds the Job can run. |
 | platformSeedJob.affinity | object | `{}` | Affinity for the platform seeding Job pod. |

k8s/helm/README.md

@@ -366,7 +366,10 @@ externalClickhouse:
 # It is usually recommended to use this config section instead of `basePlatformConfig` unless you need to use templating features.
 # For example, you can set the NIM default StorageClass via models.controller.backends.deployments_plugin.default_storage_class.
 # For full configuration reference, see https://docs.nvidia.com/nemo-platform
-platformConfig: {}
+platformConfig:
+  studio:
+    feature_flags:
+      assistant_studio_enabled: true
 
 # -- Base platform configuration settings
 # @default -- This object has the following default values for the base platform configuration.

k8s/helm/values.yaml

@@ -54,7 +54,7 @@
     permission_prompt_tool,
 )
 from nmp.studio.assistant_skills import ClaudeSkillResponse, DuplicateSkillError, list_claude_skill_responses
-from nmp.studio.entities import AssistantConversation, AssistantMessage
+from nmp.studio.entities import AssistantConversation, AssistantMessage, LegacyAssistantConversation
 from pydantic import BaseModel, ConfigDict, Field
 from starlette.routing import NoMatchFound
 
@@ -229,6 +229,32 @@ def _conversation_name(session_id: str) -> str:
     return f"assistant-{session_id}"
 
 
+def _legacy_conversation_name(session_id: str) -> str:
+    """Return the Entity Store name used before the Assistant rename."""
+    return f"copilot-{session_id}"
+
+
+async def _get_conversation(
+    entity_store: EntityClient,
+    *,
+    session_id: str,
+    workspace: str,
+) -> AssistantConversation:
+    """Load a current conversation, falling back to its pre-rename identity."""
+    try:
+        return await entity_store.get(
+            AssistantConversation,
+            _conversation_name(session_id),
+            workspace=workspace,
+        )
+    except EntityNotFoundError:
+        return await entity_store.get(
+            LegacyAssistantConversation,
+            _legacy_conversation_name(session_id),
+            workspace=workspace,
+        )
+
+
 def _request_principal_id(request: Request) -> str:
     """Return the end-user principal, including service-on-behalf-of requests."""
     return (
@@ -245,9 +271,9 @@ async def _get_owned_conversation(
 ) -> AssistantConversation:
     """Load a conversation and enforce per-user ownership within a workspace."""
     try:
-        conversation = await entity_store.get(
-            AssistantConversation,
-            _conversation_name(session_id),
+        conversation = await _get_conversation(
+            entity_store,
+            session_id=session_id,
             workspace=workspace,
         )
     except EntityNotFoundError as exc:
@@ -749,15 +775,22 @@ async def list_history_sessions(
     """List the current user's durable NeMo Assistant sessions."""
     workspace = _validated_workspace_or_default(workspace)
     owner_id = _request_principal_id(request)
-    result = await entity_store.list(
-        AssistantConversation,
-        workspace=workspace,
-        filter_obj={"owner_id": owner_id},
-        sort="-updated_at",
-        page_size=MAX_RETAINED_SESSIONS,
-    )
+    results = [
+        await entity_store.list(
+            entity_type,
+            workspace=workspace,
+            filter_obj={"owner_id": owner_id},
+            sort="-updated_at",
+            page_size=MAX_RETAINED_SESSIONS,
+        )
+        for entity_type in (AssistantConversation, LegacyAssistantConversation)
+    ]
     sessions: list[HistorySessionResponse] = []
-    for conversation in result.data:
+    seen_session_ids: set[str] = set()
+    for conversation in (conversation for result in results for conversation in result.data):
+        if conversation.session_id in seen_session_ids:
+            continue
+        seen_session_ids.add(conversation.session_id)
         user_messages = [message.content for message in conversation.messages if message.role == "user"]
         if not user_messages:
             continue
@@ -865,11 +898,7 @@ async def get_session_history(
     sid = _validate_session_id(session_id)
     workspace = _validated_workspace_or_default(workspace)
     try:
-        conversation = await entity_store.get(
-            AssistantConversation,
-            _conversation_name(sid),
-            workspace=workspace,
-        )
+        conversation = await _get_conversation(entity_store, session_id=sid, workspace=workspace)
     except EntityNotFoundError:
         conversation = None
     if conversation is not None:
@@ -964,7 +993,7 @@ async def delete_session_history(
     )
     try:
         await entity_store.delete(
-            AssistantConversation,
+            type(conversation),
             conversation.name,
             workspace=workspace,
             expected_db_version=conversation.db_version,

services/studio/src/nmp/studio/assistant.py

@@ -9,7 +9,7 @@
 from typing import Any
 
 from nmp.studio import studio_links
-from pydantic import BaseModel, Field
+from pydantic import AliasChoices, BaseModel, Field
 
 
 class ChatSelectionArtifactResponse(BaseModel):
@@ -49,7 +49,10 @@ class ChatArtifactsResponse(BaseModel):
     agent: str | None = None
     model: str | None = None
     model_source: str | None = None
-    assistant_model: str | None = None
+    assistant_model: str | None = Field(
+        default=None,
+        validation_alias=AliasChoices("assistant_model", "copilot_model"),
+    )
     workspace: str | None = None
     selections: list[ChatSelectionArtifactResponse] = Field(default_factory=list)
     files: list[ChatFileArtifactResponse] = Field(default_factory=list)

services/studio/src/nmp/studio/assistant_artifacts.py

@@ -26,3 +26,9 @@ class AssistantConversation(EntityBase):
     owner_id: str = Field(description="Principal that owns and may read this conversation.")
     messages: list[AssistantMessage] = Field(default_factory=list)
     chat_artifacts: ChatArtifactsResponse = Field(default_factory=ChatArtifactsResponse)
+
+
+class LegacyAssistantConversation(AssistantConversation):
+    """Read-compatible model for conversations persisted before the rename."""
+
+    __entity_type__: ClassVar[str] = "copilot_conversation"

services/studio/src/nmp/studio/entities.py

@@ -23,7 +23,7 @@
 from nmp.common.service.dependencies import get_entity_client
 from nmp.studio import assistant, assistant_artifacts, assistant_skills, studio_links
 from nmp.studio.config import StudioConfig
-from nmp.studio.entities import AssistantConversation, AssistantMessage
+from nmp.studio.entities import AssistantConversation, AssistantMessage, LegacyAssistantConversation
 from nmp.studio.service import StudioService
 
 
@@ -389,6 +389,46 @@ def test_list_history_sessions_includes_persisted_conversation(
     ]
 
 
+def test_legacy_conversation_remains_listable_readable_and_deletable(
+    service_client: TestClient,
+    entity_store: FakeEntityStore,
+):
+    session_id = str(uuid.uuid4())
+    conversation = LegacyAssistantConversation.model_validate(
+        {
+            "name": f"copilot-{session_id}",
+            "workspace": "default",
+            "session_id": session_id,
+            "owner_id": "local-user",
+            "messages": [
+                {"role": "user", "content": "Legacy prompt"},
+                {"role": "assistant", "content": "Legacy answer"},
+            ],
+            "chat_artifacts": {
+                "model_source": "copilot",
+                "copilot_model": "nvidia/legacy-model",
+            },
+        }
+    )
+    conversation._created_at = datetime.fromtimestamp(40, UTC)
+    conversation._updated_at = datetime.fromtimestamp(42, UTC)
+    entity_store.entities[("default", conversation.name)] = conversation
+
+    list_response = service_client.get("/v2/assistant/history/sessions")
+    history_response = service_client.get(f"/v2/assistant/history/sessions/{session_id}")
+    delete_response = service_client.delete(f"/v2/assistant/history/sessions/{session_id}")
+
+    assert list_response.status_code == 200
+    assert list_response.json()[0]["chat_artifacts"]["assistant_model"] == "nvidia/legacy-model"
+    assert history_response.status_code == 200
+    assert history_response.json()["items"] == [
+        {"kind": "user", "text": "Legacy prompt"},
+        {"kind": "assistant", "parts": [{"type": "text", "text": "Legacy answer"}]},
+    ]
+    assert delete_response.status_code == 204
+    assert ("default", conversation.name) not in entity_store.entities
+
+
 def test_history_is_scoped_to_workspace_and_owner(
     service_client: TestClient,
     entity_store: FakeEntityStore,

services/studio/tests/unit/test_assistant.py

@@ -7,9 +7,10 @@ pnpm-lock.yaml
 # Build output
 dist/
 packages/*/dist/
+packages/studio/public/vendor/
 packages/**/.test-reports/
 packages/**/test-results/
 packages/**/playwright-report/
 
 # Ignore generated style
-packages/studio/src/generated/*
+packages/studio/src/generated/*

web/.prettierignore

@@ -17,7 +17,10 @@ import { type FC } from 'react';
 
 type OpenFloatingPanel = 'history' | 'skills';
 
-export const AssistantHistoryPanel: FC<AssistantHistoryPanelProps> = ({ hideArtifacts, ...props }) => {
+export const AssistantHistoryPanel: FC<AssistantHistoryPanelProps> = ({
+  hideArtifacts,
+  ...props
+}) => {
   const [historyOpen, setHistoryOpen] = useLocalStorage(ASSISTANT_HISTORY_OPEN_KEY, 'true');
   const [openFloatingPanel, setOpenFloatingPanel, clearOpenFloatingPanel] =
     useLocalStorage<OpenFloatingPanel>(ASSISTANT_OPEN_FLOATING_PANEL_KEY);

web/packages/studio/src/routes/agents/AssistantChatRoute/AssistantHistoryPanel.tsx

@@ -24,7 +24,8 @@ import { useNavigate } from 'react-router';
 
 // Static import would pull the whole chat surface into the entry chunk, since
 // the trigger renders in the global nav on every route.
-const importChatThread = () => import('@studio/routes/agents/AssistantChatRoute/AssistantChatThread');
+const importChatThread = () =>
+  import('@studio/routes/agents/AssistantChatRoute/AssistantChatThread');
 
 // lazy() caches a rejected import forever, so a retry needs a fresh component.
 const createChatThread = () =>