fix(cli): don't print unqualified Setup complete when no default model was set (#1354)

_run_auto_mode already detects when model discovery finds nothing and
prints a warning (No default model set), but the function still fell
through to an unconditional green "Setup complete!" a few lines later
if the platform health check passed. A user running `nemo setup --auto`
against a working key but the wrong inference endpoint (or any other
path that leaves the model registry empty) saw a clean success message
despite the platform being non-functional for inference.

Gate the final banner on whether a default model was actually set:
show the existing green message only when one was, otherwise show
"Setup complete with warnings" and point back at the warnings already
printed above.

The API key validation itself is intentionally fail-open on anything
short of a definitive 401/403 rejection (see _validate_api_key's
docstring); that's a deliberate design choice for tolerating ambiguous
or unreachable providers, and this change doesn't touch it. It only
fixes the final message not reflecting a degraded state the function
already knew about.

Applied identically to both copies of this function: the SDK's
nemo_platform.cli.commands.setup and the separately-maintained
nemo_platform_ext.cli.commands.setup (see packages/nemo_platform_ext/README.md).

Fixes NMP-14.

Signed-off-by: Yamini <ykagal@gmail.com>

Author: yamini

packages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/setup.py

@@ -2356,10 +2356,14 @@ def _run_auto_mode(
         headers=_platform_request_headers(cli_context),
     )
 
-    if _verify_platform_health(base_url):
+    if not _verify_platform_health(base_url):
+        raise typer.Exit(1)
+
+    if default_model:
         console.print(f"\n{CHECK} [green]Setup complete![/green]")
     else:
-        raise typer.Exit(1)
+        console.print(f"\n{WARN} [yellow]Setup complete with warnings.[/yellow]")
+        console.print("  No default model was set; review the warnings above before using the platform.")
 
 
 def _run_interactive_mode(

packages/nemo_platform_ext/tests/cli/commands/test_setup.py

@@ -2279,6 +2279,34 @@ def test_fast_override_without_default_warns_and_is_not_saved(self):
 
         save_pair.assert_not_called()
         assert any("NEMO_FAST_MODEL is ignored" in call.args[0] for call in print_message.call_args_list)
+        printed = " ".join(str(c) for c in print_message.call_args_list)
+        assert "Setup complete with warnings" in printed
+        assert "[green]Setup complete![/green]" not in printed
+
+    def test_setup_complete_is_unqualified_when_default_model_is_set(self):
+        cli_context = MagicMock()
+        with (
+            patch.dict("os.environ", {}, clear=True),
+            patch(f"{SETUP_MOD}._auto_setup", return_value="openai"),
+            patch(f"{SETUP_MOD}._get_all_model_entity_ids", return_value=["default/a-model"]),
+            patch(f"{SETUP_MOD}._save_model_pair"),
+            patch(f"{SETUP_MOD}._maybe_install_skills"),
+            patch(f"{SETUP_MOD}._maybe_deploy_agent"),
+            patch(f"{SETUP_MOD}._verify_platform_health", return_value=True),
+            patch(f"{SETUP_MOD}.console.print") as print_message,
+        ):
+            _run_auto_mode(
+                cli_context,
+                MagicMock(),
+                "default",
+                "http://localhost:8080",
+                install_skills=False,
+                deploy_agent=False,
+            )
+
+        printed = " ".join(str(c) for c in print_message.call_args_list)
+        assert "[green]Setup complete![/green]" in printed
+        assert "Setup complete with warnings" not in printed
 
 
 # ---------------------------------------------------------------------------