Skip to content

Commit eaae615

Browse files
authored
chore: squash ngoncharenko/disable-nvskills-pipeline onto main (#1302)
Signed-off-by: Nick Goncharenko <ngoncharenko@nvidia.com>
1 parent 7c96920 commit eaae615

3 files changed

Lines changed: 0 additions & 97 deletions

File tree

.github/CI_README.md

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -50,26 +50,6 @@ reusable actions, and supporting docs.
5050

5151
- `semantic-pull-requests.yaml`
5252
Pull request title validation.
53-
54-
- `request-nvskills-ci.yml`
55-
Dispatches the internal NVSkills validation workflow when a maintainer or
56-
admin comments `/nvskills-ci` on a pull request with changes under `skills/`.
57-
It also handles the trusted signature push from the NVSkills signing bot.
58-
59-
- `require-nvskills-ci.yml`
60-
Merge-blocking PR check for `skills/` changes. It passes immediately when a
61-
PR does not touch `skills/`. When `skills/` files changed, it requires the PR
62-
head commit to be the trusted NVSkills signature commit from
63-
`NVSKILLS_SIGNATURE_PUSH_ACTOR` (default `svc-nvskills-signing`) with commit
64-
title prefix `NVSKILLS_SIGNATURE_COMMIT_TITLE` (default
65-
`Attach NVSkills validation signatures`). If new `skills/` content is pushed
66-
after signing, a maintainer or admin must rerun `/nvskills-ci`. Repository
67-
admins must make `Require NVSkills CI for skill changes / require-nvskills-ci`
68-
a required check in branch protection or rulesets for this workflow to block
69-
merges. Internal pipeline/log lookup is documented in the NVIDIA onboarding
70-
doc section:
71-
<https://nvidia.atlassian.net/wiki/spaces/GAIT/pages/3483240468/Github+First+-+Outbound+Repos+Onboarding+doc+-+NVCARPS#Review-Internal-Pipeline-Logs>.
72-
7353
- `dco-war.yaml`
7454
Merge queue compatibility shim for the DCO check. Normal DCO validation comes
7555
from the installed DCO app.

.github/workflows/ci.yaml

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -2028,56 +2028,6 @@ jobs:
20282028
command: |
20292029
opa test services/core/auth/src/nmp/core/auth/app/policies services/core/auth/src/nmp/core/auth/app/policy_tests services/core/auth/src/nmp/core/auth/assets/static-authz.yaml -v
20302030
2031-
require-nvskills:
2032-
runs-on: ubuntu-latest
2033-
if: github.event_name == 'pull_request'
2034-
steps:
2035-
- name: Require trusted NVSkills signature for skills changes
2036-
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
2037-
env:
2038-
SIGNATURE_ACTOR: ${{ vars.NVSKILLS_SIGNATURE_PUSH_ACTOR || 'svc-nvskills-signing' }}
2039-
SIGNATURE_TITLE: ${{ vars.NVSKILLS_SIGNATURE_COMMIT_TITLE || 'Attach NVSkills validation signatures' }}
2040-
ONBOARDING_DOC: https://nvidia.atlassian.net/wiki/spaces/GAIT/pages/3483240468/Github+First+-+Outbound+Repos+Onboarding+doc+-+NVCARPS#Review-Internal-Pipeline-Logs
2041-
with:
2042-
script: |
2043-
const pr = context.payload.pull_request;
2044-
const owner = context.repo.owner;
2045-
const repo = context.repo.repo;
2046-
2047-
const files = await github.paginate(github.rest.pulls.listFiles, {
2048-
owner,
2049-
repo,
2050-
pull_number: pr.number,
2051-
per_page: 100,
2052-
});
2053-
2054-
const touchedSkills = files.some((file) => file.filename.startsWith('skills/'));
2055-
if (!touchedSkills) {
2056-
core.info('No files under skills/ changed.');
2057-
return;
2058-
}
2059-
2060-
const commit = await github.rest.repos.getCommit({
2061-
owner,
2062-
repo,
2063-
ref: pr.head.sha,
2064-
});
2065-
2066-
const actor = commit.data.author?.login || '';
2067-
const title = commit.data.commit.message.split('\n')[0];
2068-
2069-
const okActor = actor === process.env.SIGNATURE_ACTOR;
2070-
const okTitle = title.startsWith(process.env.SIGNATURE_TITLE);
2071-
2072-
if (!okActor || !okTitle) {
2073-
core.setFailed(
2074-
'Files under skills/ changed in this PR, but HEAD is not the trusted NVSkills signature commit. ' +
2075-
'Ask a maintainer/admin to comment /nvskills-ci. If new skills/ content was pushed after signing, rerun /nvskills-ci. ' +
2076-
`Expected HEAD GitHub author "${process.env.SIGNATURE_ACTOR}" and commit title prefix "${process.env.SIGNATURE_TITLE}". ` +
2077-
`See ${process.env.ONBOARDING_DOC}.`
2078-
);
2079-
}
2080-
20812031
# Required-check pin: branch protection should require this final aggregate.
20822032
# Skipped jobs count as pass so conditional jobs can remain optional.
20832033
ci-status:
@@ -2101,7 +2051,6 @@ jobs:
21012051
- evaluator-sdk-closure-smoke
21022052
# Enable if you want this required
21032053
# - python-integration-test
2104-
- require-nvskills
21052054
- wheel-build
21062055
- wheel-test
21072056
- python-e2e-test

.github/workflows/request-nvskills-ci.yml

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)