test(e2e): assert the run-plan cloud check wiring in the support lane (#9493)

## Summary

The live registry-targets test asserted that a run plan's
`e2eCloudExperimentalChecks` equals
`cloudExperimentalChecksForOnboarding(onboarding)` — the same function
on the same input that `buildLiveTargetRunPlan` used to produce the
field. The comparison could not fail, and the wiring in
`test/e2e/live/run-plan.ts` was covered nowhere.

This removes the tautology from the live lane and asserts the real
wiring in `e2e-support`.

## Related Issue

Fixes #9492

## Changes

- `test/e2e/live/registry-targets.test.ts` — drop the self-comparing
assertion and the vacuous existence check that followed it (25 of 26
targets carry an empty list, so it proved nothing).
- `test/e2e/support/e2e-live-registry-discovery.test.ts` — assert that a
target whose onboarding declares cloud experimental checks produces a
run plan carrying them, and that one without them does not.

Net −3 lines.

## Why the support lane

`AGENTS.md` (E2E Selection and Authoring) says deterministic planner,
registry and fixture logic belongs in unit, integration,
package-contract or `e2e-support` tests rather than a live cloud run.
This is deterministic planner logic, so the live lane was paying cloud
runtime for an assertion that proved nothing.

## Testing

`npx vitest run --project e2e-support
test/e2e/support/e2e-live-registry-discovery.test.ts` → 10 passed.

Negative control, to show the new assertion is not itself vacuous:
replacing the wiring in `run-plan.ts` with
`plan.e2eCloudExperimentalChecks = []` makes it fail (`1 failed | 9
passed`). Restored afterwards. The assertion it replaces passes
unchanged under that same break.

## Type of change

- [x] Test change

Signed-off-by: Udaya Tejas <udayatejas2004@gmail.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Tests**
* Updated cloud check validation to use the shared checks directory
before running plan scripts.
  * Removed the onboarding-specific experimental cloud check validation.
* Added end-to-end coverage confirming that deep-agent cloud onboarding
checks are included in generated live target run plans.
* Improved validation of cloud onboarding and registry discovery
behavior across supported scenarios.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

## Documentation Writer Review

- [x] Documentation writer subagent reviewed the completed changes
- Result: `no-docs-needed`
- Evidence: This test-only change replaces a tautological assertion and
changes no user-visible behavior.
- Agent: Pi CLI
<!-- docs-review-head-sha: 5b3cc33 -->
<!-- docs-review-agents-blob-sha:
993bdd8 -->

---------

Signed-off-by: Udaya Tejas <udayatejas2004@gmail.com>
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
Co-authored-by: Carlos Villela <cvillela@nvidia.com>
Co-authored-by: Prekshi Vyas <34834085+prekshivyas@users.noreply.github.com>
Co-authored-by: Apurv Kumaria <akumaria@nvidia.com>

Author: 4 people

test/e2e/live/registry-targets.test.ts

@@ -14,7 +14,6 @@ import {
 } from "../fixtures/phases/index.ts";
 import { listTargets, requireTargets } from "../registry/registry.ts";
 import { liveTargetSupport, liveTargetTestTitle } from "../registry/runtime-support.ts";
-import { cloudExperimentalChecksForOnboarding } from "./cloud-experimental-check-list.ts";
 import { runE2eCloudExperimentalChecks } from "./cloud-experimental-checks.ts";
 import {
   captureDcodeBaseImageRuntimeEvidence,
@@ -186,14 +185,6 @@ for (const [targetIndex, target] of listTargets().entries()) {
 
       progress.phase("run target-specific cloud checks");
       const checkScripts = runPlan.e2eCloudExperimentalChecks ?? [];
-      expect(checkScripts).toEqual(
-        cloudExperimentalChecksForOnboarding(target.environment.onboarding),
-      );
-      expect(
-        checkScripts.every((scriptPath) =>
-          Object.is(fs.existsSync(path.join(REPO_ROOT, scriptPath)), true),
-        ),
-      ).toBe(true);
       expect(fs.existsSync(E2E_CLOUD_EXPERIMENTAL_CHECKS_DIR)).toBe(true);
       await runE2eCloudExperimentalChecks(target.id, instance.sandboxName, checkScripts, {
         artifacts,

test/e2e/support/e2e-live-registry-discovery.test.ts

@@ -3,6 +3,7 @@
 
 import { describe, expect, it } from "vitest";
 
+import { DEEPAGENTS_CLOUD_EXPERIMENTAL_CHECKS } from "../live/cloud-experimental-check-list.ts";
 import { buildLiveTargetRunPlan } from "../live/run-plan.ts";
 import { target } from "../registry/builder.ts";
 import { liveTargetInventoryEntry } from "../registry/run.ts";
@@ -104,6 +105,11 @@ describe("live target registry discovery support", () => {
       suiteIds: registered.suiteIds,
       phases: ["environment", "onboarding", "state-validation"],
     });
+    const deepAgents = { ...SUPPORTED_ENVIRONMENT, onboarding: "cloud-langchain-deepagents-code" };
+
+    expect(buildLiveTargetRunPlan(syntheticTarget(deepAgents)).e2eCloudExperimentalChecks).toEqual(
+      DEEPAGENTS_CLOUD_EXPERIMENTAL_CHECKS,
+    );
   });
 
   it("inserts lifecycle execution only when the synthetic target requests it", () => {