fix(onboard): accept managed runtime aliases

Signed-off-by: Deepak Jain <deepujain@gmail.com>

Author: deepujain

src/lib/onboard/managed-startup-runtime-alias.test.ts

@@ -0,0 +1,92 @@
+// SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+import { describe, expect, it } from "vitest";
+import { managedStartupE2eProfile } from "../../../scripts/checks/generate-managed-startup-profile-fixture.mts";
+import {
+  type ManagedStartupJsonObject,
+  type ManagedStartupProfile,
+  validateManagedStartupProfile,
+} from "./managed-startup/profile.ts";
+
+const SLACK_BOT_ALIAS = {
+  envKey: "SLACK_BOT_TOKEN",
+  match: "^openshell:resolve:env:(v[0-9]+_)?SLACK_BOT_TOKEN$",
+  value: "xoxb-OPENSHELL-RESOLVE-ENV-SLACK_BOT_TOKEN",
+} as const;
+
+const SLACK_APP_ALIAS = {
+  envKey: "SLACK_APP_TOKEN",
+  match: "^openshell:resolve:env:(v[0-9]+_)?SLACK_APP_TOKEN$",
+  value: "xapp-OPENSHELL-RESOLVE-ENV-SLACK_APP_TOKEN",
+} as const;
+
+function profileWithAliases(
+  aliases: readonly ManagedStartupJsonObject[],
+): ManagedStartupProfile {
+  const profile = managedStartupE2eProfile("hermes");
+  return {
+    ...profile,
+    messaging: {
+      plan: {
+        schemaVersion: 1,
+        agent: "hermes",
+        runtimeSetup: {
+          nodePreloads: [],
+          envAliases: aliases.map((alias) => ({ channelId: "slack", ...alias })),
+          secretScans: [],
+        },
+      },
+    },
+  };
+}
+
+describe("managed startup runtime aliases", () => {
+  it("accepts the stock Slack runtime aliases (#9397)", () => {
+    expect(() =>
+      validateManagedStartupProfile(profileWithAliases([SLACK_BOT_ALIAS, SLACK_APP_ALIAS])),
+    ).not.toThrow();
+  });
+
+  it.each([
+    ["an invalid environment key", { ...SLACK_BOT_ALIAS, envKey: "BAD KEY" }],
+    [
+      "an unanchored resolver expression",
+      { ...SLACK_BOT_ALIAS, match: "openshell:resolve:env:SLACK_BOT_TOKEN" },
+    ],
+    [
+      "a resolver expression for another key",
+      {
+        ...SLACK_BOT_ALIAS,
+        match: "^openshell:resolve:env:(v[0-9]+_)?SLACK_APP_TOKEN$",
+      },
+    ],
+    [
+      "a placeholder for another key",
+      { ...SLACK_BOT_ALIAS, value: "xoxb-OPENSHELL-RESOLVE-ENV-SLACK_APP_TOKEN" },
+    ],
+    ["a raw credential", { ...SLACK_BOT_ALIAS, value: `xoxb-${"a".repeat(32)}` }],
+  ])("rejects %s (#9397)", (_label, alias) => {
+    expect(() => validateManagedStartupProfile(profileWithAliases([alias]))).toThrow(
+      /credential-shaped string data/,
+    );
+  });
+
+  it.each([SLACK_BOT_ALIAS.match, SLACK_BOT_ALIAS.value])(
+    "rejects runtime alias data outside the schema-owned path (#9397)",
+    (runtimeAliasData) => {
+      const profile = profileWithAliases([]);
+      expect(() =>
+        validateManagedStartupProfile({
+          ...profile,
+          messaging: {
+            plan: {
+              ...profile.messaging.plan,
+              note: runtimeAliasData,
+            },
+          },
+        }),
+      ).toThrow(/credential-shaped string data/);
+    },
+  );
+});

src/lib/onboard/managed-startup/profile.ts

@@ -1049,6 +1049,54 @@ function isMessagingCredentialPlaceholderAssignment(
   return CREDENTIAL_ENV_NAME_PATTERN.test(envKey) && envKey === placeholderEnvKey;
 }
 
+function isMessagingRuntimeEnvAliasPath(path: readonly string[]): boolean {
+  return (
+    path.length === 5 &&
+    path[0] === "messaging" &&
+    path[1] === "plan" &&
+    path[2] === "runtimeSetup" &&
+    path[3] === "envAliases" &&
+    JSON_ARRAY_INDEX_SEGMENT_RE.test(path[4] ?? "")
+  );
+}
+
+function ownDataPropertyValue(value: Record<string, unknown>, key: string): unknown {
+  const descriptor = Object.getOwnPropertyDescriptor(value, key);
+  return descriptor && "value" in descriptor ? descriptor.value : undefined;
+}
+
+function isCanonicalMessagingRuntimeEnvAlias(
+  path: readonly string[],
+  value: Record<string, unknown>,
+): boolean {
+  if (!isMessagingRuntimeEnvAliasPath(path)) return false;
+  const envKey = ownDataPropertyValue(value, "envKey");
+  const match = ownDataPropertyValue(value, "match");
+  const placeholder = ownDataPropertyValue(value, "value");
+  return (
+    typeof envKey === "string" &&
+    CREDENTIAL_ENV_NAME_PATTERN.test(envKey) &&
+    match === `^openshell:resolve:env:(v[0-9]+_)?${envKey}$` &&
+    typeof placeholder === "string" &&
+    messagingCredentialPlaceholderEnvKey(placeholder) === envKey
+  );
+}
+
+function isAllowedMessagingRuntimeAliasStringPath(
+  path: readonly string[],
+  allowedAliasIndexes: ReadonlySet<string>,
+): boolean {
+  return (
+    path.length === 6 &&
+    path[0] === "messaging" &&
+    path[1] === "plan" &&
+    path[2] === "runtimeSetup" &&
+    path[3] === "envAliases" &&
+    allowedAliasIndexes.has(path[4] ?? "") &&
+    (path[5] === "match" || path[5] === "value")
+  );
+}
+
 function isMessagingPackagePin(path: readonly string[], value: unknown): boolean {
   return (
     path.length === 6 &&
@@ -1399,6 +1447,7 @@ function assertPayloadStructureAndCredentialShapes(root: unknown): void {
     depth: number;
     path: readonly string[];
   }> = [{ value: root, depth: 0, path: [] }];
+  const allowedRuntimeAliasIndexes = new Set<string>();
   let discoveredNodes = 1;
   let observedBytes = 0;
 
@@ -1426,6 +1475,7 @@ function assertPayloadStructureAndCredentialShapes(root: unknown): void {
     if (typeof current.value === "string") {
       observeText(current.value);
       if (
+        !isAllowedMessagingRuntimeAliasStringPath(current.path, allowedRuntimeAliasIndexes) &&
         !isMessagingCredentialPlaceholder(current.path, current.value) &&
         !isMessagingCredentialPlaceholderAssignment(current.path, current.value) &&
         (valueLooksLikeSecret(current.value) ||
@@ -1485,6 +1535,9 @@ function assertPayloadStructureAndCredentialShapes(root: unknown): void {
       if ("toJSON" in current.value) {
         invalid("payload must not define a custom JSON serializer");
       }
+      if (isCanonicalMessagingRuntimeEnvAlias(current.path, current.value)) {
+        allowedRuntimeAliasIndexes.add(current.path[4] as string);
+      }
       const keys = Object.getOwnPropertyNames(current.value);
       if (
         Object.getOwnPropertySymbols(current.value).length > 0 ||