Commit 3668e10
committed
fix(hermes): admit the Google Chat asset into the portable context
The Hermes portable build context walks every directory the Dockerfile
copies and rejects a file that its reviewed manifest does not name, so
the five files this branch adds under the Google Chat channel failed
installer-integration on the first one it reached.
Its Dockerfile parser also rejects a COPY that continues onto a second
line, which the new plugin-asset COPY did. Join that instruction, name
its source in the local COPY allowlist, and add the five files to the
reviewed manifest.
The parser and the reviewed manifest are the same two lists the gate
compares, so both had to move together. installer-integration clones
the pushed revision rather than the working tree, so this was verified
by running the parser against the working tree and by the unit suite
under src/lib/onboard/experimental, which builds its fixture from the
manifest.1 parent f0495c4 commit 3668e10
3 files changed
Lines changed: 7 additions & 2 deletions
File tree
- agents/hermes
- src/lib/onboard/experimental
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
84 | | - | |
| 83 | + | |
85 | 84 | | |
86 | 85 | | |
87 | 86 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
| 207 | + | |
| 208 | + | |
207 | 209 | | |
| 210 | + | |
208 | 211 | | |
209 | 212 | | |
210 | 213 | | |
| |||
224 | 227 | | |
225 | 228 | | |
226 | 229 | | |
| 230 | + | |
| 231 | + | |
227 | 232 | | |
228 | 233 | | |
229 | 234 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| 86 | + | |
86 | 87 | | |
87 | 88 | | |
88 | 89 | | |
| |||
0 commit comments