test: convert next 300 test loops to tables

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

Author: cv

nemoclaw/src/blueprint/runner.test.ts

@@ -409,58 +409,65 @@ describe("runner", () => {
       expect(plan.dry_run).toBe(false);
     });
 
-    it("does not expose credential field names or secret values in public plan output", async () => {
-      captureStdout();
-      mockExeca.mockResolvedValue({ exitCode: 0 });
-      const bp = {
-        components: {
-          inference: {
-            profiles: {
-              secrets: {
-                provider_type: "openai",
-                provider_name: "secret-provider",
-                endpoint: "https://api.example.com/v1",
-                model: "gpt-4",
-                credential_env: "SECRET_KEY",
-                credential_default: "default-secret-value",
-                token: "future-token-value",
-                authorization: "Bearer future-authorization",
-              },
-            },
-          },
-          sandbox: { image: "openclaw", name: "sb", forward_ports: [18789] },
-        },
-      };
-      process.env.SECRET_KEY = "real-secret-value";
-      try {
-        const plan = await actionPlan("secrets", bp);
-        const rendered = capturedJsonOutput<{
-          inference: Record<string, unknown>;
-        }>();
-        const out = stdoutText();
-
-        expect(plan.inference).not.toHaveProperty("credential_env");
-        expect(rendered.inference).toEqual({
-          provider_type: "openai",
-          provider_name: "secret-provider",
-          endpoint: "https://api.example.com/v1",
-          model: "gpt-4",
-        });
-        for (const leaked of [
+    it.each(
+      Array.from(
+        [
           "credential_env",
           "credential_default",
           "SECRET_KEY",
           "default-secret-value",
           "real-secret-value",
           "future-token-value",
           "future-authorization",
-        ]) {
+        ],
+        (tableRow) => [tableRow] as const,
+      ),
+    )(
+      "does not expose credential field names or secret values in public plan output [%s]",
+      async (leaked) => {
+        captureStdout();
+        mockExeca.mockResolvedValue({ exitCode: 0 });
+        const bp = {
+          components: {
+            inference: {
+              profiles: {
+                secrets: {
+                  provider_type: "openai",
+                  provider_name: "secret-provider",
+                  endpoint: "https://api.example.com/v1",
+                  model: "gpt-4",
+                  credential_env: "SECRET_KEY",
+                  credential_default: "default-secret-value",
+                  token: "future-token-value",
+                  authorization: "Bearer future-authorization",
+                },
+              },
+            },
+            sandbox: { image: "openclaw", name: "sb", forward_ports: [18789] },
+          },
+        };
+        process.env.SECRET_KEY = "real-secret-value";
+        try {
+          const plan = await actionPlan("secrets", bp);
+          const rendered = capturedJsonOutput<{
+            inference: Record<string, unknown>;
+          }>();
+          const out = stdoutText();
+
+          expect(plan.inference).not.toHaveProperty("credential_env");
+          expect(rendered.inference).toEqual({
+            provider_type: "openai",
+            provider_name: "secret-provider",
+            endpoint: "https://api.example.com/v1",
+            model: "gpt-4",
+          });
+
           expect(out).not.toContain(leaked);
+        } finally {
+          delete process.env.SECRET_KEY;
         }
-      } finally {
-        delete process.env.SECRET_KEY;
-      }
-    });
+      },
+    );
 
     it("passes dryRun through to the plan", async () => {
       captureStdout();

nemoclaw/src/register.test.ts

@@ -177,9 +177,9 @@ describe("plugin registration", () => {
 
     const bannerLines = output.split("\n").filter((line) => line.length > 0);
     expect(bannerLines.length).toBeGreaterThan(0);
-    for (const line of bannerLines) {
-      expect(line.startsWith("[gateway] ")).toBe(true);
-    }
+    expect(
+      Array.from(bannerLines, (line) => Object.is(line.startsWith("[gateway] "), true)),
+    ).not.toContain(false);
   });
 
   it("falls back to onboard config when openclaw.json has no primary model", () => {

src/lib/actions/sandbox/auto-pair-approval-receipt.test.ts

@@ -19,34 +19,9 @@ describe("auto-pair approval receipts (#4616)", () => {
   const pythonUnavailable =
     spawnSync("sh", ["-c", "command -v python3"], { stdio: "ignore" }).status !== 0;
 
-  it.skipIf(pythonUnavailable)("omits raw output from devices-list failure classifications", () => {
-    const policy = readAutoPairApprovalPolicyModule();
-    expect(policy).toBeTruthy();
-    const script = buildAutoPairApprovalScript(
-      Buffer.from(policy as string, "utf-8").toString("base64"),
-      {
-        emitReceipt: true,
-        budget: { listTimeoutS: 0.5 },
-      },
-    );
-    const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-auto-pair-list-receipt-"));
-    try {
-      fs.writeFileSync(
-        path.join(tmpDir, "openclaw"),
-        `#!${process.execPath}
-const args = process.argv.slice(2);
-if (args[0] !== "devices" || args[1] !== "list") process.exit(2);
-const sleepMs = Number(process.env.NEMOCLAW_LIST_SLEEP_MS || "0");
-if (sleepMs > 0) {
-  Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, sleepMs);
-}
-process.stdout.write(process.env.NEMOCLAW_LIST_STDOUT || "");
-process.stderr.write(process.env.NEMOCLAW_LIST_STDERR || "");
-process.exit(Number(process.env.NEMOCLAW_LIST_EXIT_CODE || "0"));
-`,
-        { mode: 0o755 },
-      );
-      for (const [environment, receipt] of [
+  it.skipIf(pythonUnavailable).each(
+    Array.from(
+      [
         [{ NEMOCLAW_LIST_SLEEP_MS: "800" }, "list-timeout"],
         [
           { NEMOCLAW_LIST_EXIT_CODE: "1", NEMOCLAW_LIST_STDERR: "raw failure" },
@@ -77,7 +52,39 @@ process.exit(Number(process.env.NEMOCLAW_LIST_EXIT_CODE || "0"));
         [{ NEMOCLAW_LIST_STDOUT: "raw invalid json" }, "list-invalid-json"],
         [{ NEMOCLAW_LIST_STDOUT: "[]\n" }, "list-invalid-output"],
         [{ NEMOCLAW_LIST_STDOUT: "{}\n" }, "list-missing-pending"],
-      ] as const) {
+      ] as const,
+      (tableRow) => [tableRow] as const,
+    ),
+  )(
+    "omits raw output from devices-list failure classifications [case %#]",
+    ([environment, receipt]) => {
+      const policy = readAutoPairApprovalPolicyModule();
+      expect(policy).toBeTruthy();
+      const script = buildAutoPairApprovalScript(
+        Buffer.from(policy as string, "utf-8").toString("base64"),
+        {
+          emitReceipt: true,
+          budget: { listTimeoutS: 0.5 },
+        },
+      );
+      const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-auto-pair-list-receipt-"));
+      try {
+        fs.writeFileSync(
+          path.join(tmpDir, "openclaw"),
+          `#!${process.execPath}
+const args = process.argv.slice(2);
+if (args[0] !== "devices" || args[1] !== "list") process.exit(2);
+const sleepMs = Number(process.env.NEMOCLAW_LIST_SLEEP_MS || "0");
+if (sleepMs > 0) {
+  Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, sleepMs);
+}
+process.stdout.write(process.env.NEMOCLAW_LIST_STDOUT || "");
+process.stderr.write(process.env.NEMOCLAW_LIST_STDERR || "");
+process.exit(Number(process.env.NEMOCLAW_LIST_EXIT_CODE || "0"));
+`,
+          { mode: 0o755 },
+        );
+
         const result = spawnSync("sh", ["-c", script], {
           encoding: "utf-8",
           env: {
@@ -89,11 +96,11 @@ process.exit(Number(process.env.NEMOCLAW_LIST_EXIT_CODE || "0"));
         });
         expect(parseAutoPairApprovalReceipt(result.stdout)).toBe(receipt);
         expect(`${result.stdout}${result.stderr}`).not.toContain("raw ");
+      } finally {
+        fs.rmSync(tmpDir, { recursive: true, force: true });
       }
-    } finally {
-      fs.rmSync(tmpDir, { recursive: true, force: true });
-    }
-  });
+    },
+  );
 
   it("distinguishes host execution failures without returning their details", () => {
     const timeoutError = Object.assign(new Error("private timeout detail"), {

src/lib/actions/sandbox/auto-pair-approval-script.test.ts

@@ -119,32 +119,37 @@ describe("buildAutoPairApprovalScript (#4263/#4616)", () => {
       (value) => [value],
     ),
   )("accepts exactly one terminal fixed receipt [case %#]", (output) => {
-    for (const receipt of [
-      "approved-one",
-      "list-failed",
-      "list-state-path-invalid",
-      "list-platform-unsupported",
-      "list-state-root-failed",
-      "list-devices-directory-failed",
-      "list-pending-unsafe",
-      "list-pending-unstable",
-      "list-pending-invalid-shape",
-      "list-pending-unavailable",
-      "list-timeout",
-      "list-exec-failed",
-      "list-scope-upgrade-pending",
-      "list-device-pairing-required",
-      "list-gateway-connect-failed",
-      "list-command-failed",
-      "list-empty-output",
-      "list-invalid-json",
-      "list-invalid-output",
-      "list-missing-pending",
-    ] as const) {
-      expect(
-        parseAutoPairApprovalReceipt(`ignored setup output\n${RECEIPT_MARKER}=${receipt}\n`),
-      ).toBe(receipt);
-    }
+    expect(
+      Array.from(
+        [
+          "approved-one",
+          "list-failed",
+          "list-state-path-invalid",
+          "list-platform-unsupported",
+          "list-state-root-failed",
+          "list-devices-directory-failed",
+          "list-pending-unsafe",
+          "list-pending-unstable",
+          "list-pending-invalid-shape",
+          "list-pending-unavailable",
+          "list-timeout",
+          "list-exec-failed",
+          "list-scope-upgrade-pending",
+          "list-device-pairing-required",
+          "list-gateway-connect-failed",
+          "list-command-failed",
+          "list-empty-output",
+          "list-invalid-json",
+          "list-invalid-output",
+          "list-missing-pending",
+        ] as const,
+        (receipt) =>
+          Object.is(
+            parseAutoPairApprovalReceipt(`ignored setup output\n${RECEIPT_MARKER}=${receipt}\n`),
+            receipt,
+          ),
+      ),
+    ).not.toContain(false);
 
     expect(parseAutoPairApprovalReceipt(output)).toBeNull();
   });

src/lib/actions/sandbox/connect-hermes-light-theme.test.ts

@@ -378,9 +378,9 @@ describe("Hermes sandbox connect light terminal skin", () => {
 
     const skinWriteCall = skinWriteCalls(harness)[0];
     expect(skinWriteCall?.[0]).toEqual(["sandbox", "exec", "--name", "alpha", "--", "sh", "-s"]);
-    for (const part of (skinWriteCall?.[0] ?? []) as string[]) {
-      expect(part).not.toMatch(/[\n\r]/);
-    }
+    expect(
+      Array.from((skinWriteCall?.[0] ?? []) as string[], (part) => !/[\n\r]/.test(part)),
+    ).not.toContain(false);
     const opts = skinWriteCall?.[1] as { input?: string; stdio?: unknown } | undefined;
     expect(opts?.input ?? "").toContain('mv -f "$tmp" "$skin_dir/nemoclaw-light.yaml"');
     expect(opts?.input ?? "").toContain("\n");