Skip to content

Commit 9dea3ee

Browse files
committed
fix(onboard): classify signaled readiness probes
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
1 parent 2826da3 commit 9dea3ee

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

src/lib/onboard/sandbox-gpu-create-run-attempt.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,9 @@ function probeExactOpenShellSandboxId(
133133
const sandboxId = parseOpenShellSandboxId(String(result.stdout ?? ""));
134134
return sandboxId ? { state: "identified", sandboxId } : { state: "failed" };
135135
}
136-
if (result.error || result.signal || result.status === null) return { state: "failed" };
136+
if (result.error || result.status === null || ("signal" in result && result.signal)) {
137+
return { state: "failed" };
138+
}
137139
return OPENSHELL_SANDBOX_NOT_READY.test(normalizedOpenShellCommandOutput(result))
138140
? { state: "not_ready" }
139141
: { state: "failed" };
@@ -177,7 +179,9 @@ function checkSandboxExecutableReadiness(
177179
killSignal: "SIGKILL",
178180
});
179181
if (result.status === 0 && !result.error) return "ready";
180-
if (result.error || result.signal || result.status === null) return "probe_failed";
182+
if (result.error || result.status === null || ("signal" in result && result.signal)) {
183+
return "probe_failed";
184+
}
181185
return OPENSHELL_SANDBOX_NOT_READY.test(normalizedOpenShellCommandOutput(result))
182186
? "not_ready"
183187
: "probe_failed";

0 commit comments

Comments
 (0)