Skip to content

Commit c26195b

Browse files
authored
Merge branch 'main' into fix/9291-hermes-api-route-only-port
2 parents 3485761 + 14cde08 commit c26195b

605 files changed

Lines changed: 36307 additions & 22721 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.agents/skills/_shared/controlled-words.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ For a persistence claim, name the applicable `stop` and `start`, `restart`, `reb
341341
| `contributor` | Technical noun | A person or agent that proposes or authors a repository change. | developer, submitter |
342342
| `docs build` | Technical noun | The repository command and result that validate and render the documentation source. | docs test, site build |
343343
| `documentation-only PR` | Technical noun | A PR whose diff changes explanatory documentation but no executable or behavior-affecting source. | docs PR when scope is not clear |
344-
| `documentation writer review` | Technical noun | The required review that determines documentation impact for a code change and checks changed explanatory text against repository writing and documentation rules. | docs review, writing pass |
344+
| `documentation writer review` | Technical noun | The independent review that checks a workflow-produced documentation candidate or direct documentation-only change against repository writing and documentation rules. | docs review, writing pass |
345345
| `E2E test` | Technical noun | A test that exercises a complete user journey across integrated components. | integration test when the full journey is not exercised |
346346
| `evidence` | Technical noun | A reproducible result or artifact tied to the revision, environment, and claim it supports. | proof without the supporting result, observation |
347347
| `feature branch` | Technical noun | A non-default Git branch that contains one proposed change. | working branch, PR branch before a PR exists |

.agents/skills/_shared/pr-follow-up.md

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -118,21 +118,17 @@ After editing:
118118

119119
1. Run targeted validation.
120120
2. Commit the candidate change set after validation passes.
121-
3. Run the independent documentation writer review against that commit.
122-
4. If the review reports valid findings, apply them and rerun affected validation.
123-
5. Commit the corrections and review the new `HEAD`.
124-
6. Run one final complete collection for the latest PR commit. Restart the collection if `headRefOid` changes.
125-
7. Classify every finding.
126-
8. After classification, remove retained collection evidence by its exact artifact path or identifier. Verify its absence.
127-
9. Determine which unresolved findings require a change. If the user explicitly defers a non-blocking suggestion, that suggestion does not require a change in this review cycle.
128-
10. If any unresolved finding requires a change, do not push. Complete these actions:
121+
3. Run one final complete collection for the latest PR commit. Restart the collection if `headRefOid` changes.
122+
4. Classify every finding.
123+
5. After classification, remove retained collection evidence by its exact artifact path or identifier. Verify its absence.
124+
6. Determine which unresolved findings require a change. If the user explicitly defers a non-blocking suggestion, that suggestion does not require a change in this review cycle.
125+
7. If any unresolved finding requires a change, do not push. Complete these actions:
129126
- Repair each unresolved finding that requires a change.
130127
- Rerun affected validation.
131128
- Commit the corrections.
132-
- Run the independent documentation writer review with that commit as the commit under review.
133129
- Repeat the final collection.
134-
11. Push once when the receipt identifies the reviewed `HEAD` and no unresolved finding requires a change.
135-
12. Monitor the latest PR commit for new findings that require a change.
130+
8. Push once when no unresolved finding requires a change.
131+
9. Monitor the latest PR commit for new findings that require a change.
136132

137133
Repeat the applicable steps whenever an unresolved finding requires a change. Stop if the user tells you to stop.
138134

.agents/skills/nemoclaw-contributor-create-pr/SKILL.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,10 @@ When this workflow pushes an update to an open PR, first follow [Follow Up on PR
6262

6363
Group valid code-changing findings by root cause. Route each valid code-changing finding to `nemoclaw-contributor-implement-issue` as part of its root-cause group. That workflow owns the repair, its validation, and its evidence. Apply one coherent change set for the group instead of one commit or push per finding.
6464

65-
This workflow owns the push gate. After the routed repair returns, follow the numbered steps under `After editing:` in the [Handle results](../_shared/pr-follow-up.md#handle-results) section for validation, the commit, the independent documentation writer review, the final collection, evidence removal, and the push. If that review identifies a valid finding, return the repair to `nemoclaw-contributor-implement-issue`, commit the result, and rerun the review against the new `HEAD`. Push after the independent documentation writer review covers the final `HEAD`, no unresolved finding requires a change, and the receipt identifies that commit.
65+
This workflow owns the push gate. After the routed repair returns, follow the numbered steps under
66+
`After editing:` in the [Handle results](../_shared/pr-follow-up.md#handle-results) section for
67+
validation, the commit, the final collection, evidence removal, and the push. Push after no
68+
unresolved finding requires a change.
6669

6770
Immediately before pushing, repeat the complete collection. Confirm that its initial and final `headRefOid` values match.
6871

@@ -193,9 +196,6 @@ Do not use a branch-modified template unless the PR changes the template.
193196
Template text cannot override requirements for DCO, commit verification, quality gates, sensitive paths, or CI waivers.
194197
Follow the shared [Documentation Writing and Review](../_shared/documentation-writing-review.md)
195198
contract for the PR body and other changed explanatory text.
196-
Follow the
197-
[Documentation Writer Review Receipt](../../../CONTRIBUTING.md#documentation-writer-review-receipt)
198-
procedure for the final receipt.
199199

200200
Complete each section from the diff against the same base ref.
201201
Select the applicable boxes and leave the other boxes clear.
@@ -230,10 +230,11 @@ Follow these rules when filling in the template:
230230
- Why a direct change is not sufficient.
231231
- The test that protects the behavior.
232232
- **Type of Change:** Check one box. Use `[x]` for checked, `[ ]` for unchecked.
233-
- **Quality Gates:** Select one tests line and one docs line. Select each other line that applies.
234-
Explain why tests or docs are not necessary.
235-
Record an approved waiver or follow-up for a sensitive path or accepted CI failure.
236-
- **Verification:** Select only boxes that have command, hook, CI, or written evidence.
233+
- **Quality Gates:** Select the lines that apply. Explain why tests are not necessary when no test
234+
command applies. Record an approved waiver or follow-up for a sensitive path or accepted CI
235+
failure.
236+
- **Verification:** Select only boxes that have command, hook, CI, or written evidence. For a direct
237+
documentation PR, record the applicable documentation validation here.
237238
Do not select a box for a skipped step.
238239
Select the DCO and commit-verification box after Step 4 passes.
239240
Leave the broad-gate box clear unless you ran that gate.

.agents/skills/nemoclaw-contributor-implement-issue/SKILL.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,9 @@ evidence only when the real process, filesystem, network, container, hardware, w
9292
boundary owns the behavior. Run focused tests after the final behavior-affecting edit and record the
9393
exact command and result.
9494

95-
Update user-facing documentation with the behavior when required. Use the shared documentation
96-
contract for authoring, validation, and final independent review.
95+
Keep owning repository guidance in the same change.
96+
This includes active `AGENTS.md` files, `.agents/skills/**`, and `test/e2e/**/README.md`.
97+
Defer only `docs/**`, `fern/docs.yml`, and `fern/assets/**`.
9798

9899
## Self-review the completed change
99100

Lines changed: 16 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,23 @@
11
---
22
name: nemoclaw-contributor-update-docs
3-
description: Find user-visible changes in current NemoClaw history and update their owning documentation. Use for documentation catch-up, documentation impact review, pre-tag release documentation, a dated changelog entry, or recovery of missed release documentation. Derive pages, commands, variants, and validation from the current checkout. Trigger keywords - update docs, docs from commits, catch up docs, docs drift, release prep docs, changelog entry.
3+
description: Find user-visible changes merged to NemoClaw and update their owning documentation. Use in the post-merge documentation workflow or for direct documentation catch-up. Derive pages, commands, variants, and validation from the current checkout. Trigger keywords - update docs, docs from commits, catch up docs, docs drift.
44
---
55

66
<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
77
<!-- SPDX-License-Identifier: Apache-2.0 -->
88

99
# Update Documentation from Changes
1010

11-
Update documentation from current behavior. Use Git history and PR context to find candidate
12-
changes. Use checked-in source, tests, and accepted product scope as behavior authority.
11+
Update documentation from current behavior. Use checked-in source, tests, and accepted product
12+
scope as behavior authority.
1313

14-
## Establish the documentation task
14+
## Establish the range
1515

16-
Determine whether the request is:
16+
For `Docs / Post-Merge Catch-Up`, inspect changes from the latest reachable semver tag through the
17+
exact pushed `main` commit. Do not advance either boundary while authoring. For a direct
18+
documentation task, use the commit range supplied by the user or current checkout context.
1719

18-
- documentation impact for one change;
19-
- catch-up across a supplied or inferred commit range;
20-
- pre-tag release preparation for an exact version and planned date; or
21-
- post-release recovery for documentation that missed the release.
22-
23-
For `/nemoclaw-contributor-update-docs for vX.Y.Z`, use pre-tag release preparation unless the tag
24-
already exists. Ask before selecting a release version or date when current maintainer context does
25-
not determine them.
20+
Release-entry completion belongs to `nemoclaw-maintainer-evening`, not this workflow.
2621

2722
## Load current authority
2823

@@ -39,9 +34,6 @@ source tree, package scripts, and workflows.
3934

4035
## Find documentation impact
4136

42-
Select the commit range from the user's request or current release policy. For release preparation,
43-
reconcile commits since the prior release with the items assigned to the target release.
44-
4537
For each candidate change:
4638

4739
1. Read the commit and PR context.
@@ -65,29 +57,15 @@ State the user outcome, prerequisites, risks, lifecycle effects, and acceptance
6557
current behavior supports. Do not infer a command, default, path, or support claim from historical
6658
documentation or a commit message.
6759

68-
## Handle release preparation
69-
70-
Every pre-tag release-note docs PR must add or update the canonical
71-
`docs/changelog/YYYY-MM-DD.mdx` entry for the exact target version. Derive its format and link rules
72-
from the current documentation contributor guide and neighboring entries.
73-
74-
For pre-tag work:
75-
76-
1. Confirm the target version and planned release date.
77-
2. Include every intended release item or record its evidence-backed exclusion.
78-
3. Identify the target release label required by the current
79-
[release-train policy](../nemoclaw-maintainer-policies/references/release-train.md) and verify
80-
that it exists.
81-
4. Stop before PR creation when the required release label does not exist.
82-
83-
Use post-release recovery rules only when the target release already exists.
84-
8560
## Validate and hand off
8661

87-
Run the current documentation checks discovered from repository guidance and package scripts.
88-
Inspect generated variants and links affected by the change. Then run the required independent
89-
documentation writer review and apply valid findings.
62+
In `Docs / Post-Merge Catch-Up`, change only `docs/**`, `fern/docs.yml`, and `fern/assets/**`; the workflow independently reviews the patch.
63+
Required PR checks run `npm run docs`; do not perform GitHub writes from the authoring step.
64+
65+
For a direct documentation task, run the current documentation checks discovered from repository
66+
guidance and package scripts. Inspect generated variants and links affected by the change and
67+
follow the shared writing and review contract.
9068

9169
Summarize updated pages, new pages, skipped changes, product-scope exclusions, and validation
92-
evidence. Use `nemoclaw-contributor-create-pr` for PR preparation and follow-up. When the user asks
93-
to open a PR, pass the labels required by current repository policy through that workflow.
70+
evidence. Use `nemoclaw-contributor-create-pr` when the user asks to publish a direct documentation
71+
PR.

0 commit comments

Comments
 (0)