Skip to content

Commit d217363

Browse files
Dongni-Yangclaude
andcommitted
docs(inference): state why image absence proves the probe pull failed
The PR review advisor warned that the classifier could blame a pull for a run failure it never observed. It cannot: `docker run` pulls an absent image before it creates the container, and --add-host, policy, and seccomp failures all happen after that pull. Five runs precede the inspect check, so a pullable image would already be in the cache, and a post-pull failure keeps the generic runtime diagnostic. Record that invariant at the classifier so the next reader does not re-derive it. Refs #9308 Signed-off-by: Dongni Yang <dongniy@nvidia.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 7d4f96a commit d217363

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

src/lib/inference/local.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1239,6 +1239,13 @@ function containerRuntimeFailureDiagnostic(text: string): ContainerDiagnostic {
12391239
* probe image. Credential-helper failures land here (#9308) — a remote login
12401240
* session can lose access to Docker Desktop's credential store, so the pull
12411241
* fails and every probe run produces empty stdout.
1242+
*
1243+
* Image-absent-after-run-attempts proves the pull failed: `docker run` pulls
1244+
* an absent image before it creates the container, and `--add-host`, policy,
1245+
* and seccomp failures all happen after that pull. Five runs precede this
1246+
* check (three probes, two diagnostics), so a pullable image would be in the
1247+
* cache by now and a run that failed for any post-pull reason keeps the
1248+
* generic runtime diagnostic.
12421249
*/
12431250
function classifyContainerRunFailure(
12441251
dockerCommand: string[],

0 commit comments

Comments
 (0)