You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(onboard): reuse mirrored Windows Ollama (#9345)
<!-- markdownlint-disable MD041 -->
## Summary
Reuse Windows-host Ollama when WSL mirrored networking exposes that
daemon through `127.0.0.1`. Before this change, NemoClaw treated the
loopback response as a WSL-local daemon and could route Ollama 0.32.5
through the Linux upgrade installer even though the usable daemon was
installed on Windows.
## Related Issue
Fixes#9300
## Changes
- Classify WSL loopback as Windows-host Ollama only when `wslinfo`
reports mirrored networking, a Windows Ollama installation is present,
Docker can reach the Windows daemon, and Linux procfs shows no WSL-owned
listener on the Ollama port.
- Exclude that positively identified Windows daemon from the WSL-local
binary and daemon version-upgrade path.
- Keep fail-closed behavior for ordinary WSL loopback daemons,
dual-daemon topologies, unavailable socket identity, and unrecognized
WSL networking modes.
- Add regression coverage for mirrored-network classification, Ollama
0.32.5, local-listener identity, and ambiguous modes; document the
topology rule.
## Type of Change
- [ ] Code change (feature, bug fix, or refactor)
- [x] Code change with doc updates
- [ ] Doc only (prose changes, no code sample modifications)
- [ ] Doc only (includes code sample changes)
## Quality Gates
- [x] Tests added or updated for changed behavior
- [ ] Existing tests cover changed behavior — justification:
- [ ] Tests not applicable — justification:
- [x] Sensitive paths changed (security, policy, credentials, preflight,
onboarding, inference, runner, sandbox, or messaging)
- [x] Sensitive-path review completed or maintainer-approved waiver
recorded — reviewer/approval link/justification: Approved by @cv:
#9345 (review)
- [ ] Non-success, skipped, or missing CI check accepted by maintainer —
check name, approval link, and follow-up issue:
## DGX Station Hardware Evidence
- [ ] Tested on DGX Station
- Tested commit: Not applicable
- Station profile/scenario: Not applicable
- Result: Not applicable
- Supporting evidence: Not applicable
## Verification
- [x] PR description includes a `Signed-off-by:` line and every commit
appears as `Verified` in GitHub
- [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or
`npm run validate:pr` passed after refreshing `origin/main` when hooks
were skipped or unavailable
- [x] Targeted behavior tests pass for the current change set, or tests
are marked not applicable above — `npm run test -- --run
src/lib/onboard/provider-host-state.test.ts
src/lib/onboard/ollama-install-menu.test.ts
src/lib/onboard/provider-menu.test.ts
test/install-express-wsl-ollama.test.ts
test/onboard-selection-windows-provider-rejection.test.ts
test/onboard-selection.test.ts` (133 passed)
- [ ] Applicable broad gate passed — `npm test` for broad
runtime/test-harness changes; `npm run check` for repo-wide
validation/coverage changes — command/result: Not applicable; the change
is isolated to Ollama topology classification and its install menu.
- [x] Quality Gates section completed with required justifications or
waivers
- [x] No secrets, API keys, or credentials committed
- [ ] `npm run docs` builds without warnings (doc changes only) — build
succeeded with 0 errors and 2 pre-existing warnings
- [x] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)
---
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
---------
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Copy file name to clipboardExpand all lines: docs/inference/set-up-ollama.mdx
+2Lines changed: 2 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -49,6 +49,8 @@ When neither side can be read, the failure asks you to check that Ollama is inst
49
49
Fresh installs skip this second probe because the bundled installers provide a daemon at or above the minimum.
50
50
51
51
The version gate does not apply to Windows-host Ollama reached from Docker Desktop through `host.docker.internal`.
52
+
With WSL mirrored networking, the same daemon can answer on `127.0.0.1`; NemoClaw treats it as Windows-host Ollama only when Windows installation and Docker reachability checks match and Linux procfs shows no WSL-local listener on the Ollama port.
53
+
Ambiguous evidence or a separate WSL-local listener stays on the Linux install and upgrade path.
52
54
The Windows-host menu entries perform their own actions on the Windows side.
0 commit comments