test(e2e): wait for portable gateway serve record (#9379)

<!-- markdownlint-disable MD041 -->
## Summary

An injected gateway record failure can return before the asynchronous
gateway process records its `serve` command. The regression test now
waits for that required command. It still validates the launch-record
PID, active process, and cleanup behavior.

## Related Issue

Related to #9208.

## Changes

- Use bounded Vitest polling for the expected `generate-certs` and
`serve` sequence.
- Keep the launch-record PID, active-process, and cleanup assertions
after the command sequence appears.

## Type of Change

- [x] Code change (feature, bug fix, or refactor)
- [ ] Code change with doc updates
- [ ] Doc only (prose changes, no code sample modifications)
- [ ] Doc only (includes code sample changes)

## Quality Gates

- [x] Tests added or updated for changed behavior
- [ ] Existing tests cover changed behavior — justification:
- [ ] Tests not applicable — justification:
- [ ] Sensitive paths changed (security, policy, credentials, preflight,
onboarding, inference, runner, sandbox, or messaging)
- [ ] Sensitive-path review completed or maintainer-approved waiver
recorded — reviewer/approval link/justification:
- [ ] Non-success, skipped, or missing CI check accepted by maintainer —
check name, approval link, and follow-up issue:

## DGX Station Hardware Evidence

- [ ] Tested on DGX Station
- Tested commit:
- Station profile/scenario:
- Result:
- Supporting evidence:

## Verification

- [x] PR description includes a `Signed-off-by:` line and every commit
appears as `Verified` in GitHub
- [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or
`npm run validate:pr` passed after refreshing `origin/main` when hooks
were skipped or unavailable
- [x] Targeted behavior tests pass for the current change set, or tests
are marked not applicable above — command/result or justification: `npx
vitest run --project e2e-support
test/e2e/support/portable-profile-systemctl-shim.test.ts
--reporter=verbose` passed 36/36 on `f33c18283`.
- [ ] Applicable broad gate passed — `npm test` for broad
runtime/test-harness changes; `npm run check` for repo-wide
validation/coverage changes — command/result:
- [x] Quality Gates section completed with required justifications or
waivers
- [x] No secrets, API keys, or credentials committed
- [ ] `npm run docs` builds without warnings (doc changes only)
- [ ] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)

---
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Improved reliability when handling gateway cleanup failures by
ensuring required activity is recorded before results are validated.
* **Tests**
* Increased stability across gateway startup, cleanup-failure, and
launch-failure scenarios.
* Added consistent waiting and log verification to reduce timing-related
test failures and produce more dependable validation results.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Co-authored-by: Carlos Villela <cvillela@nvidia.com>

Author: prekshivyas

test/e2e/support/portable-profile-systemctl-shim.test.ts

@@ -360,6 +360,25 @@ async function waitForFileText(filePath: string, text: string): Promise<void> {
   });
 }
 
+function readGatewayCommands(scope: FixtureScope): Record<string, unknown>[] {
+  return fs
+    .readFileSync(scope.gatewayCommandLog, "utf8")
+    .trim()
+    .split("\n")
+    .map((line) => JSON.parse(line) as Record<string, unknown>);
+}
+
+async function waitForGatewayCommands(
+  scope: FixtureScope,
+  expectedKinds: string[],
+): Promise<Record<string, unknown>[]> {
+  return vi.waitFor(() => {
+    const commands = readGatewayCommands(scope);
+    expect(commands.map((command) => command.kind)).toEqual(expectedKinds);
+    return commands;
+  }, { timeout: 5_000 });
+}
+
 function pidIsActive(pid: number): boolean {
   try {
     process.kill(pid, 0);
@@ -655,12 +674,7 @@ describe("portable profile systemctl fixture", () => {
         expect(activeIdentity.stdout).toContain("ActiveState=active\n");
         expect(activeIdentity.stdout).toContain(`MainPID=${String(gatewayProcess.pid)}\n`);
 
-        const commands = fs
-          .readFileSync(scope.gatewayCommandLog, "utf8")
-          .trim()
-          .split("\n")
-          .map((line) => JSON.parse(line) as Record<string, unknown>);
-        expect(commands.map((command) => command.kind)).toEqual(["generate-certs", "serve"]);
+        const commands = await waitForGatewayCommands(scope, ["generate-certs", "serve"]);
         expect(commands[0]).toMatchObject({
           args: [
             "generate-certs",
@@ -747,12 +761,7 @@ describe("portable profile systemctl fixture", () => {
         );
         expect(fs.existsSync(scope.gatewayPidFile)).toBe(false);
         expect(fs.existsSync(gatewayLaunchPidFile)).toBe(true);
-        const commands = fs
-          .readFileSync(scope.gatewayCommandLog, "utf8")
-          .trim()
-          .split("\n")
-          .map((line) => JSON.parse(line) as Record<string, unknown>);
-        expect(commands.map((command) => command.kind)).toEqual(["generate-certs", "serve"]);
+        const commands = await waitForGatewayCommands(scope, ["generate-certs", "serve"]);
         const gatewayPid = commands[1]!.pid as number;
         expect(readFixtureProcessRecord(gatewayLaunchPidFile).pid).toBe(gatewayPid);
         expect(pidIsActive(gatewayPid)).toBe(true);
@@ -805,12 +814,7 @@ describe("portable profile systemctl fixture", () => {
         expect(launchedPid).not.toBeNull();
         const gatewayPid = Number(launchedPid![1]);
         await vi.waitFor(() => expect(pidIsActive(gatewayPid)).toBe(false));
-        const commands = fs
-          .readFileSync(scope.gatewayCommandLog, "utf8")
-          .trim()
-          .split("\n")
-          .map((line) => JSON.parse(line) as Record<string, unknown>);
-        expect(commands.map((command) => command.kind)).toEqual(["generate-certs"]);
+        await waitForGatewayCommands(scope, ["generate-certs"]);
       } finally {
         await cleanFixture(scope);
       }