Commit 2b2307c
committed
docs: add --tail=-1 to the label-selector log command
Review catch, and it is a defect this PR introduced. kubectl's own help states
the default plainly: 'Defaults to -1 with no selector, showing all log lines
otherwise 10, if a selector is provided.'
So switching from a named pod to a label selector silently capped output at the
last 10 lines per worker, which would omit the 'NCCL INFO ... Using network'
banner NCCL prints during init — the exact line the command greps for. The
check would have reported nothing on a correctly attached job.
Refs #2306
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>1 parent 890be93 commit 2b2307c
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
298 | | - | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
299 | 301 | | |
300 | 302 | | |
301 | 303 | | |
| |||
0 commit comments