fix(k8s): satisfy staticcheck on watch-error classification

FromObject never returns nil, so the nil guard was dead code (SA4023).
Extract the Status checks into a helper to drop the multi-line if, and
build the Gone case from a raw Status instead of the deprecated NewGone.

Signed-off-by: Rohit Rajani <rorajani@nvidia.com>

Author: rorajani

pkg/k8s/pod/job.go

@@ -76,19 +76,27 @@ func isRetryableWatchError(event watch.Event) bool {
 		return false
 	}
 	err := apierrors.FromObject(event.Object)
-	if err == nil {
-		return false
-	}
-	if apierrors.IsResourceExpired(err) || apierrors.IsGone(err) ||
-		apierrors.IsTimeout(err) || apierrors.IsServerTimeout(err) ||
-		apierrors.IsTooManyRequests(err) || apierrors.IsServiceUnavailable(err) {
+	if isTransientAPIStatus(err) {
 		return true
 	}
+	// The StreamWatcher wraps transport failures in a generic InternalError, so
+	// the Reason carries no signal and the message is the only discriminator.
 	msg := strings.ToLower(err.Error())
 	return strings.Contains(msg, "http2: client connection lost") ||
 		strings.Contains(msg, "unable to decode an event from the watch stream")
 }
 
+// isTransientAPIStatus reports whether an apiserver Status error is one the
+// client is expected to retry rather than a terminal rejection.
+func isTransientAPIStatus(err error) bool {
+	return apierrors.IsResourceExpired(err) ||
+		apierrors.IsGone(err) ||
+		apierrors.IsTimeout(err) ||
+		apierrors.IsServerTimeout(err) ||
+		apierrors.IsTooManyRequests(err) ||
+		apierrors.IsServiceUnavailable(err)
+}
+
 // resumeJobWatch reconnects a Job watch that ended — the channel closed or the
 // apiserver emitted a retryable watch.Error (410, HTTP/2 drop) — before the
 // Job reached a terminal state.

pkg/k8s/pod/wait_internal_test.go

@@ -389,9 +389,15 @@ func TestIsRetryableWatchError(t *testing.T) {
 			want:  true,
 		},
 		{
-			name:  "410 Gone is retryable",
-			event: errorEvent(statusOf(apierrors.NewGone("gone"))),
-			want:  true,
+			// Built from a raw Status rather than the deprecated NewGone: a
+			// bare 410 with no expiry semantics is what an LB-terminated
+			// watch returns.
+			name: "410 Gone is retryable",
+			event: errorEvent(&metav1.Status{
+				Status: metav1.StatusFailure,
+				Reason: metav1.StatusReasonGone,
+			}),
+			want: true,
 		},
 		{
 			name:  "503 ServiceUnavailable is retryable",