fix(version): rename HasGKEPrefix→HasRawGKESuffix; remove dead HasGKESuffix; add tests

- Rename HasGKEPrefix → HasRawGKESuffix (clearer: operates on Extras which
  is itself a suffix; 'prefix' referred ambiguously to the -gke. leader)
- Remove HasGKESuffix (no production callers; use ExtractGKEBuild directly)
- Fix stale godoc referencing the removed HasGKESuffix
- Add TestHasRawGKESuffix covering valid, invalid, and non-GKE inputs
- Add no-space lone-= (=ubuntu → OperatorEQ/ubuntu) and empty lone-=
  error (= → ErrCodeInvalidRequest) tests to constraint_test.go

Signed-off-by: Kevin Hawkins <khawkins@nvidia.com>

Author: Kevin-Hawkins

pkg/constraints/constraint.go

@@ -126,7 +126,7 @@ func ParseConstraintExpression(expr string) (*ParsedConstraint, error) {
 		pc.Operator == OperatorLTE || pc.Operator == OperatorLT
 	if isComparisonOp {
 		if parsed, err := version.ParseVersion(pc.Value); err == nil {
-			if version.HasGKEPrefix(parsed.Extras) {
+			if version.HasRawGKESuffix(parsed.Extras) {
 				if _, ok := version.ExtractGKEBuild(parsed.Extras); !ok {
 					return nil, errors.New(errors.ErrCodeInvalidRequest,
 						fmt.Sprintf("constraint value %q has a malformed GKE build suffix (must be -gke.N with N >= 0)", pc.Value))

pkg/constraints/constraint_test.go

@@ -40,6 +40,8 @@ func TestParseConstraintExpression(t *testing.T) {
 		{name: "less than", expression: "< 2.0", wantOp: OperatorLT, wantValue: "2.0"},
 		{name: "equal op", expression: "== ubuntu", wantOp: OperatorEQ, wantValue: "ubuntu"},
 		{name: "lone = is alias for ==", expression: "= ubuntu", wantOp: OperatorEQ, wantValue: "ubuntu"},
+		{name: "lone = no-space is alias for ==", expression: "=ubuntu", wantOp: OperatorEQ, wantValue: "ubuntu"},
+		{name: "lone = with empty value errors", expression: "=", expectError: true, wantErrCode: errors.ErrCodeInvalidRequest},
 		{name: "not equal", expression: "!= rhel", wantOp: OperatorNE, wantValue: "rhel"},
 
 		// Exact match (no operator)

pkg/version/version.go

@@ -24,7 +24,7 @@ import (
 )
 
 // gkeSuffixPrefix is the bare prefix that identifies GKE-specific build number
-// extras of the form "-gke.NNNNNN". Unexported: use HasGKESuffix or
+// extras of the form "-gke.NNNNNN". Unexported: use HasRawGKESuffix or
 // ExtractGKEBuild for cross-package consumption.
 const gkeSuffixPrefix = "gke."
 
@@ -202,18 +202,12 @@ func ExtractGKEBuild(extras string) (int64, bool) {
 	return n, true
 }
 
-// HasGKESuffix reports whether the Extras field carries a valid GKE build
-// suffix ("-gke.N" with N >= 0). Returns false for malformed or non-GKE extras.
-func HasGKESuffix(extras string) bool {
-	_, ok := ExtractGKEBuild(extras)
-	return ok
-}
-
-// HasGKEPrefix reports whether the Extras field begins with the "-gke." prefix,
-// regardless of whether the trailing build number is valid. Use this when you
-// need to distinguish "has a GKE prefix but invalid number" from "no GKE prefix
-// at all" (e.g. to reject malformed constraint values at parse time).
-func HasGKEPrefix(extras string) bool {
+// HasRawGKESuffix reports whether the Extras field begins with the "-gke."
+// prefix, regardless of whether the trailing build number is valid. Use this
+// when you need to distinguish "has the GKE suffix leader but an invalid build
+// number" from "no GKE suffix at all" (e.g. to reject malformed constraint
+// values at parse time). For full validity checking combine with ExtractGKEBuild.
+func HasRawGKESuffix(extras string) bool {
 	return strings.HasPrefix(strings.TrimPrefix(extras, "-"), gkeSuffixPrefix)
 }
 

pkg/version/version_test.go

@@ -901,6 +901,32 @@ func TestExtractGKEBuild(t *testing.T) {
 	}
 }
 
+// TestHasRawGKESuffix verifies that HasRawGKESuffix returns true whenever the
+// -gke. prefix is present, regardless of build-number validity.
+func TestHasRawGKESuffix(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		extras string
+		want   bool
+	}{
+		{"-gke.1318000", true},  // valid
+		{"-gke.-1", true},       // invalid build but prefix present
+		{"-gke.abc", true},      // invalid build but prefix present
+		{"-gke.", true},         // empty build but prefix present
+		{"-eks-3025e55", false}, // non-GKE
+		{"", false},
+	}
+	for _, tt := range tests {
+		t.Run(tt.extras, func(t *testing.T) {
+			t.Parallel()
+			if got := HasRawGKESuffix(tt.extras); got != tt.want {
+				t.Errorf("HasRawGKESuffix(%q) = %v, want %v", tt.extras, got, tt.want)
+			}
+		})
+	}
+}
+
 // ExampleVersion_Compare demonstrates sorting versions
 func ExampleVersion_Compare() {
 	v1, _ := ParseVersion("1.2.0")