Commit 47fbd07
committed
docs(defaults): correct MirrorDefaultKubeVersion rationale comment
The comment claimed the value "tracks the project's minimum supported
Kubernetes version declared in recipes/overlays/base.yaml". It does not,
and must not: base.yaml declares ">= 1.25" while the constant is 1.33.0.
The constant is a render-safe fallback for `helm template --kube-version`
used by pkg/helm/render.go and pkg/mirror/discover.go when no version is
supplied. Two sentences earlier the same comment explains why it exists —
Helm's compiled-in v1.27.0 default is too old for charts declaring
`kubeVersion: >=1.32.0-0`. Lowering the value to 1.25 to match base.yaml
would reintroduce exactly that failure.
The value is correct; only the rationale was wrong. Rewritten to state
that this is a fallback rather than a support floor, and to warn against
the plausible-looking "fix" of aligning it with base.yaml. Also notes
that a recipe declaring K8s.server.version never reaches this default
(mirror.KubeVersionFromConstraints returns the recipe's own value).
Comment-only; no behavior change.
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>1 parent 06d2cbb commit 47fbd07
1 file changed
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1254 | 1254 | | |
1255 | 1255 | | |
1256 | 1256 | | |
1257 | | - | |
1258 | | - | |
| 1257 | + | |
| 1258 | + | |
| 1259 | + | |
| 1260 | + | |
| 1261 | + | |
| 1262 | + | |
| 1263 | + | |
1259 | 1264 | | |
1260 | 1265 | | |
1261 | 1266 | | |
| |||
0 commit comments