Skip to content

Commit d5110a6

Browse files
committed
docs(demos): tell operators to update both halves of the TCPXO pair
The manifest header told the reader to update only the plugin tag when their cluster runs a different installer version. Following it leaves both daemon references untouched, recreating the mismatched pair this change exists to fix. State the coupling, name the pinned pair, and say to update both images, so the manifest carries the same guidance the integrator doc already gives. Also correct the lookup: the installer image lives in initContainers, not containers, so the previous jsonpath returned empty. Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
1 parent 9f6fd4c commit d5110a6

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

demos/workloads/training/gke-nccl-test-tcpxo.yaml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,17 @@
3232
# - GPU Operator with driver.enabled=false (GKE COS manages drivers)
3333
#
3434
# Image version note:
35-
# The nccl-test container image must match the cluster's installed TCPXO
36-
# plugin version. Check with:
35+
# Google ships the plugin installer and the tcpxo-daemon as a coupled release
36+
# pair; running a mismatched pair is unsupported. This manifest is pinned to
37+
# v1.0.15 (nccl-plugin-gpudirecttcpx-dev) with v1.0.21 (tcpgpudmarxd-dev),
38+
# matching the installer the AICR recipe deploys.
39+
#
40+
# If your cluster runs a different installer version, check it with:
3741
# kubectl get ds nccl-tcpxo-installer -n kube-system \
38-
# -o jsonpath='{.spec.template.spec.containers[?(@.name=="nccl-tcpxo-installer")].image}'
39-
# Then update the nccl-plugin-gpudirecttcpx-dev tag below to match.
42+
# -o jsonpath='{.spec.template.spec.initContainers[?(@.name=="nccl-tcpxo-installer")].image}'
43+
# then update BOTH images below to that installer's pair, per Google's
44+
# release table: https://github.com/GoogleCloudPlatform/container-engine-accelerators/blob/master/gpudirect-tcpxo/README.md
45+
# Updating only one half recreates the mismatch this pairing exists to avoid.
4046
#
4147
# Usage:
4248
# kubectl create ns nccl-test

0 commit comments

Comments
 (0)