Skip to content

Commit ed97605

Browse files
authored
Merge branch 'main' into fix/2135-ocp-alias-coverage
2 parents 762c666 + ce34464 commit ed97605

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

pkg/defaults/timeouts.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1254,8 +1254,18 @@ const (
12541254
// recipe constraints. Without this flag Helm uses its compiled-in
12551255
// default (currently v1.27.0 in Helm 3.x), which is too old for
12561256
// charts that declare a kubeVersion constraint (e.g., >=1.32.0-0).
1257-
// The value tracks the project's minimum supported Kubernetes version
1258-
// declared in recipes/overlays/base.yaml.
1257+
//
1258+
// This is a render-safe fallback, not a support floor. This constant
1259+
// must stay at or above the strictest kubeVersion any bundled chart
1260+
// declares. Do NOT lower it to match the ">= 1.25" recipe floor in
1261+
// recipes/overlays/base.yaml: that is the constraint recipes are
1262+
// validated against, and a recipe that declares one never reaches this
1263+
// default (see mirror.KubeVersionFromConstraints).
1264+
//
1265+
// The invariant binds this constant only. The constraint path is
1266+
// unbounded below: KubeVersionFromConstraints returns the recipe's own
1267+
// value, so a recipe carrying nothing but base.yaml's ">= 1.25" renders
1268+
// with --kube-version 1.25.
12591269
MirrorDefaultKubeVersion = "1.33.0"
12601270

12611271
// MirrorDiscoveryConcurrency caps the number of components rendered in

0 commit comments

Comments
 (0)