Skip to content

Commit 03530c3

Browse files
author
Chong Gao
committed
Iceberg: clarify trimmed-coverage comments per review
Address Gera's review nits on #14937: - __init__.py: the distributed transform lists are bound to test params by name, so the tuple order must match the parametrize arg-string order, not the function-signature order; reword the comment accordingly. - delete/merge/update _full_coverage tests: refresh the now-stale "full partition coverage" docstrings to the sanity-check wording used by the CTAS/RTAS/overwrite variants, pointing at the append anchor (test_insert_into_partitioned_table_full_coverage). Signed-off-by: Chong Gao <res_life@163.com>
1 parent 215689a commit 03530c3

4 files changed

Lines changed: 16 additions & 6 deletions

File tree

integration_tests/src/main/python/iceberg/__init__.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,10 @@
119119
]
120120

121121
# Each list pairs (partition_col_sql, <mode>). Always used together as
122-
# `@pytest.mark.parametrize("partition_col_sql,<mode_arg>", <list>)` so the
123-
# parametrize-string order matches the tuple order and the function-signature
124-
# order (`partition_col_sql` first, then the mode arg). Keep them in lockstep.
122+
# `@pytest.mark.parametrize("partition_col_sql,<mode_arg>", <list>)`, so the
123+
# tuple order must match the order of names in the parametrize arg string
124+
# (`partition_col_sql` first, then the mode arg). Pytest binds parameters to the
125+
# test function by name, so the function-signature order does not matter.
125126
#
126127
# Each list is just two cases (one per mode, exercising one transform family):
127128
# the 26-transform partition-writer matrix lives in the append anchor

integration_tests/src/main/python/iceberg/iceberg_delete_test.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,10 @@ def test_iceberg_delete_partitioned_table(spark_tmp_table_factory, partition_col
158158
@pytest.mark.parametrize("partition_col_sql,delete_mode", delete_partition_transforms_distributed)
159159
@allow_non_gpu_conditional(is_spark_400_or_later(), "EmptyRelationExec")
160160
def test_iceberg_delete_partitioned_table_full_coverage(spark_tmp_table_factory, partition_col_sql, delete_mode):
161-
"""Full partition coverage test - skipped for remote catalogs."""
161+
"""Sanity-check DELETE across the two write modes against partition transforms
162+
distinct from those picked by other DML ops. The 26-transform partition-writer
163+
coverage anchor lives in
164+
iceberg_append_test.py::test_insert_into_partitioned_table_full_coverage."""
162165
_do_test_iceberg_delete_partitioned_table(spark_tmp_table_factory, partition_col_sql, delete_mode)
163166

164167
@iceberg

integration_tests/src/main/python/iceberg/iceberg_merge_test.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,10 @@ def test_iceberg_merge(spark_tmp_table_factory, partition_col_sql, merge_mode):
183183
@pytest.mark.parametrize("partition_col_sql,merge_mode", merge_partition_transforms_distributed)
184184
@allow_non_gpu_conditional(is_spark_400_or_later(), "EmptyRelationExec")
185185
def test_iceberg_merge_full_coverage(spark_tmp_table_factory, partition_col_sql, merge_mode):
186-
"""Full partition coverage test - skipped for remote catalogs."""
186+
"""Sanity-check MERGE across the two write modes against partition transforms
187+
distinct from those picked by other DML ops. The 26-transform partition-writer
188+
coverage anchor lives in
189+
iceberg_append_test.py::test_insert_into_partitioned_table_full_coverage."""
187190
_do_test_iceberg_merge(spark_tmp_table_factory, partition_col_sql, merge_mode)
188191

189192

integration_tests/src/main/python/iceberg/iceberg_update_test.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,10 @@ def test_iceberg_update_partitioned_table_single_column(spark_tmp_table_factory,
171171
@pytest.mark.parametrize("partition_col_sql,update_mode", update_partition_transforms_distributed)
172172
@allow_non_gpu_conditional(is_spark_400_or_later(), "EmptyRelationExec")
173173
def test_iceberg_update_partitioned_table_single_column_full_coverage(spark_tmp_table_factory, update_mode, partition_col_sql):
174-
"""Full partition coverage test - skipped for remote catalogs."""
174+
"""Sanity-check UPDATE across the two write modes against partition transforms
175+
distinct from those picked by other DML ops. The 26-transform partition-writer
176+
coverage anchor lives in
177+
iceberg_append_test.py::test_insert_into_partitioned_table_full_coverage."""
175178
_do_test_iceberg_update_partitioned_table_single_column(spark_tmp_table_factory, update_mode, partition_col_sql)
176179

177180
@iceberg

0 commit comments

Comments
 (0)